Status summary: Needs review: 1. Committed: 102. Moved to next CF: 12. Returned with Feedback: 27. Rejected: 6. Total: 148.
| Patch | ID | Status | Tags | Ver | CI status | Stats | Author | Reviewers | Committer | Num cfs | Latest mail |
|---|---|---|---|---|---|---|---|---|---|---|---|
| Bug Fixes | |||||||||||
| Fix handling on XLOG_RUNNING_XACTS generated by bgwriter on idle systems | 398 | Committed | Not processed | Michael Paquier (michael-kun) | Amit Kapila (amitkapila), Simon Riggs (simon), Jeff Janes (jjanes) | Simon Riggs (simon) | 3 | 9 years ago | |||
| Install dynloader.h in MSVC builds | 473 | Committed | Not processed | Michael Paquier (michael-kun), Bruce Momjian (bmomjian) | Bruce Momjian (bmomjian) | 1 | 9 years ago | ||||
| Apply recovery_min_apply_delay once standby has reached consistent state | 478 | Committed | Not processed | Michael Paquier (michael-kun) | Simon Riggs (simon), Julien Rouhaud (rjuju) | Fujii Masao (masaofujii) | 1 | 9 years ago | |||
| Remove service-related code in cygwin for pg_ctl | 479 | Committed | Not processed | Michael Paquier (michael-kun) | Andrew Dunstan (adunstan) | 1 | 9 years ago | ||||
| pg_dump broken with constraint comments of domains using double-quotes | 481 | Committed | Not processed | Michael Paquier (michael-kun) | Álvaro Herrera (alvherre) | 1 | 9 years ago | ||||
| Fix handling of RETURNING tableoid in updating foreign tables | 483 | Committed | Not processed | Etsuro Fujita (efujita) | Thom Brown (thom) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Silent data loss with ext4 / all current versions | 484 | Committed | Not processed | Tomas Vondra (fuzzycz) | Andres Freund (andresfreund), Michael Paquier (michael-kun) | Andres Freund (andresfreund) | 1 | 9 years ago | |||
| pgbench small fixes under low rate | 493 | Committed | Not processed | Fabien Coelho (calvin) | Aleksander Alekseev (a.alekseev) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Mac OS: invalid byte sequence for encoding "UTF8" | 496 | Committed | Not processed | Artur Zakirov (a.zakirov) | Fedor Sigaev (sigaev) | Tom Lane (tgl) | 1 | 9 years ago | |||
| Ensure boolean sounding macros return 0 or 1. | 507 | Committed | Not processed | Andres Freund (andresfreund) | Robert Haas (rhaas), Peter Eisentraut (petere) | Andres Freund (andresfreund) | 1 | 9 years ago | |||
| Fix handling of 0-dimension objects in jsonb_object() | 515 | Committed | Not processed | Michael Paquier (michael-kun) | Andrew Dunstan (adunstan) | 1 | 9 years ago | ||||
| Fix crash when running on old Windows and new CPU | 516 | Committed | Not processed | Christian Ullrich (chrullrich) | Magnus Hagander (mha) | Magnus Hagander (mha) | 1 | 9 years ago | |||
| Fix for OpenSSL error queue bug | 520 | Committed | Not processed | Peter Geoghegan (pgeoghegan) | Peter Eisentraut (petere) | Peter Eisentraut (petere) | 1 | 9 years ago | |||
| Fix handling of invalid sockets returned by PQsocket() | 522 | Committed | Not processed | Michael Paquier (michael-kun) | Peter Eisentraut (petere) | Peter Eisentraut (petere) | 1 | 9 years ago | |||
| Fix handling of TXID wraparound in pg_subtrans at beginning of recovery | 526 | Committed | Not processed | Jeff Janes (jjanes) | Tom Lane (tgl), Michael Paquier (michael-kun) | Simon Riggs (simon) | 1 | 9 years ago | |||
| Sanity checking for configure --with-pgport | 534 | Committed | Not processed | Jim Nasby (decibel) | Alex Shulgin (ash), Peter Eisentraut (petere), Ivan Kartyshov (fenimorkin) | Tom Lane (tgl) | 1 | 9 years ago | |||
| unexpected result from to_tsvector | 537 | Committed | Not processed | Artur Zakirov (a.zakirov) | Dmitrii Golub (houdini) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| Integer overflow in timestamp[tz]_part() and date/time boundaries check | 540 | Committed | Not processed | Vitaly Burovoy (vitaly.burovoy) | Anastasia Lubennikova (lubennikovaav) | Tom Lane (tgl) | 1 | 9 years ago | |||
| Fixing wrong comment on PQmblen and PQdsplen. | 543 | Committed | Not processed | Robert Haas (rhaas) | 1 | 9 years ago | |||||
| Supporting +-Infinity values by to_timestamp(float8) | 546 | Committed | Not processed | Vitaly Burovoy (vitaly.burovoy) | Anastasia Lubennikova (lubennikovaav) | Tom Lane (tgl) | 1 | 9 years ago | |||
| fix DROP OPERATOR to reset links to itself on commutator and negator | 548 | Committed | Not processed | Roma Sokolov (roma.sokolov) | Robert Haas (rhaas), Tomas Vondra (fuzzycz) | Tom Lane (tgl) | 1 | 9 years ago | |||
| Equivalent of --enable-tap-tests in MSVC scripts | 566 | Committed | Not processed | Michael Paquier (michael-kun) | Craig Ringer (ringerc) | Álvaro Herrera (alvherre) | 1 | 9 years ago | |||
| Incorrect error message in InitializeSessionUserId | 570 | Committed | Not processed | Dmitriy Sarafannikov (dsarafannikov) | Haribabu Kommi (haribabu) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Clients | |||||||||||
| extends pgbench expressions with functions | 189 | Committed | Not processed | Fabien Coelho (calvin) | Michael Paquier (michael-kun), Alex Shulgin (ash), BeomYong Lee (leebeomyong) | Robert Haas (rhaas) | 5 | 9 years ago | |||
| Do not use expanded mode for EXPLAIN output in "\x auto" | 471 | Committed | Not processed | Andreas Karlsson (kandreas) | Vik Fearing (xocolatl) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Add \errverbose to psql (and support in libpq) | 475 | Committed | Not processed | Alex Shulgin (ash), Petr Korobeinikov (pkorobeinikov) | Daniel Vérité (danielverite) | Tom Lane (tgl) | 1 | 9 years ago | |||
| Take into account \pset title when using \watch if set | 480 | Committed | Not processed | Michael Paquier (michael-kun) | Vik Fearing (xocolatl) | Tom Lane (tgl) | 1 | 9 years ago | |||
| pgbench with multiline and multistatement of SQL and multiline metacommands. | 499 | Committed | Not processed | Kyotaro Horiguchi (horiguti) | Tom Lane (tgl) | Tom Lane (tgl) | 1 | 9 years ago | |||
| pgbench weights & prefix selection (follow-up to pgbench per-script stats) | 504 | Committed | Not processed | Fabien Coelho (calvin) | Álvaro Herrera (alvherre) | 1 | 9 years ago | ||||
| \crosstabview in psql for crosstab-style display | 521 | Committed | Not processed | Daniel Vérité (danielverite) | Pavel Stehule (okbobcz) | Álvaro Herrera (alvherre) | 1 | 9 years ago | |||
| meta-queries with \gexec psql command | 531 | Committed | Not processed | Corey Huinker (coreyh) | Jim Nasby (decibel), Daniel Vérité (danielverite) | Tom Lane (tgl) | 1 | 9 years ago | |||
| insufficient qualification of some objects in dump files | 542 | Committed | Not processed | Peter Eisentraut (petere) | Michael Paquier (michael-kun) | Peter Eisentraut (petere) | 1 | 9 years ago | |||
| psql completion for ids in multibyte string | 544 | Committed | Not processed | Thomas Munro (macdice) | Robert Haas (rhaas) | 1 | 9 years ago | ||||
| Code Comments | |||||||||||
| Fix some comment typos | 472 | Committed | Not processed | David Rowley (davidrowley) | Robert Haas (rhaas) | 1 | 9 years ago | ||||
| Documentation | |||||||||||
| Add documentation for perl TAP tests | 536 | Committed | Not processed | Craig Ringer (ringerc) | Michael Paquier (michael-kun) | Álvaro Herrera (alvherre) | 1 | 9 years ago | |||
| pg_resetxlog reference page reorganization | 560 | Committed | Not processed | Peter Eisentraut (petere) | Alexander Korotkov (smagen) | Peter Eisentraut (petere) | 1 | 9 years ago | |||
| Miscellaneous | |||||||||||
| Improvements of Hunspell dictionaries support | 420 | Committed | Not processed | Artur Zakirov (a.zakirov) | Fedor Sigaev (sigaev) | Fedor Sigaev (sigaev) | 2 | 9 years ago | |||
| Set of regression tests for standbys using TAP stuff | 438 | Committed | Not processed | Michael Paquier (michael-kun) | Craig Ringer (ringerc), Stas Kelvich (kelvich), Victor Wagner (vitus_wagner) | Álvaro Herrera (alvherre) | 2 | 9 years ago | |||
| Fuzzy substring searching with the pg_trgm extension | 448 | Committed | Not processed | Alexander Korotkov (smagen), Artur Zakirov (a.zakirov) | Fedor Sigaev (sigaev), Jeff Janes (jjanes) | Fedor Sigaev (sigaev) | 2 | 9 years ago | |||
| Improve error messages in format() | 470 | Committed | Not processed | Jim Nasby (decibel) | Fedor Sigaev (sigaev), Vik Fearing (xocolatl) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| Improve unaccent default rules generation script: better support for diacritics and ligatures | 490 | Committed | Not processed | Léonard Benedetti (mlpo) | Fedor Sigaev (sigaev), Vik Fearing (xocolatl) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| parse_ident | 505 | Committed | Not processed | Pavel Stehule (okbobcz) | Fedor Sigaev (sigaev), Jim Nasby (decibel) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| function for converting human readable sizes to bytes - pg_size_bytes | 514 | Committed | Not processed | Pavel Stehule (okbobcz) | Vitaly Burovoy (vitaly.burovoy) | Dean Rasheed (deanr) | 1 | 9 years ago | |||
| GCC 6 warning fixes | 541 | Committed | Not processed | Peter Eisentraut (petere) | Thomas Munro (macdice) | Peter Eisentraut (petere) | 1 | 9 years ago | |||
| New DEPENDENCY_AUTO_EXTENSION/'x' dependency type | 567 | Committed | Not processed | Abhijit Menon-Sen (ams) | Alexander Korotkov (smagen) | Álvaro Herrera (alvherre) | 1 | 9 years ago | |||
| TAP test enhancements | 569 | Committed | Not processed | Craig Ringer (ringerc) | Michael Paquier (michael-kun) | Álvaro Herrera (alvherre) | 1 | 9 years ago | |||
| Monitoring & Control | |||||||||||
| replace pg_stat_activity.waiting with something more descriptive | 287 | Committed | Not processed | Amit Kapila (amitkapila), Ildus Kurbangaliev (ildus) | Alexander Korotkov (smagen) | Robert Haas (rhaas) | 5 | 9 years ago | |||
| Add sample rate to auto_explain | 524 | Committed | Not processed | Craig Ringer (ringerc), Julien Rouhaud (rjuju) | Petr Jelínek (pjmodos) | Magnus Hagander (mha) | 1 | 9 years ago | |||
| VACUUM Progress Checker | 545 | Committed | Not processed | Vinayak-1 Pokale (vinayak-1) | Kyotaro Horiguchi (horiguti), Rahila Syed (rahila.syed), Amit Langote (amitlan) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Identifying a message in emit_log_hook | 576 | Committed | Not processed | Kyotaro Horiguchi (horiguti) | Simon Riggs (simon), Pavel Stehule (okbobcz) | Simon Riggs (simon) | 1 | 9 years ago | |||
| Performance | |||||||||||
| checkpoint continuous flushing | 260 | Committed | Not processed | Andres Freund (andresfreund), Fabien Coelho (calvin) | Andres Freund (andresfreund) | Andres Freund (andresfreund) | 5 | 9 years ago | |||
| index-only scans with partial indexes | 299 | Committed | Not processed | Kyotaro Horiguchi (horiguti), Tomas Vondra (fuzzycz) | Kyotaro Horiguchi (horiguti), Kevin Grittner (kgrittn), Konstantin Knizhnik (knizhnik) | Tom Lane (tgl) | 4 | 9 years ago | |||
| Reusing abbreviated keys during second pass of ordered [set] aggregates | 300 | Committed | Not processed | Peter Geoghegan (pgeoghegan) | Andreas Karlsson (kandreas) | Robert Haas (rhaas) | 4 | 9 years ago | |||
| Using quicksort for every external sort run | 317 | Committed | Not processed | Peter Geoghegan (pgeoghegan) | Robert Haas (rhaas), Tomas Vondra (fuzzycz), Jeff Janes (jjanes), Greg Stark (stark) | Robert Haas (rhaas) | 4 | 9 years ago | |||
| Replace buffer manager spinlock with atomic operations | 408 | Committed | Not processed | Andres Freund (andresfreund), Alexander Korotkov (smagen) | Andres Freund (andresfreund) | 3 | 9 years ago | ||||
| Remove Functionally Dependent GROUP BY Columns | 435 | Committed | Not processed | David Rowley (davidrowley) | Julien Rouhaud (rjuju) | Tom Lane (tgl) | 2 | 9 years ago | |||
| Relation Extension Scalability using Multi Extend | 461 | Committed | Not processed | Andres Freund (andresfreund), Dilip Kumar (dilip.kumar) | Amit Kapila (amitkapila) | Robert Haas (rhaas) | 2 | 9 years ago | |||
| Optimizer patch moving evaluation of non-trivial target list expressions in case of ORDER BY+LIMIT to projection after limit. | 482 | Committed | Not processed | Konstantin Knizhnik (knizhnik) | Tom Lane (tgl) | Tom Lane (tgl) | 1 | 9 years ago | |||
| Fix lock contention for HASHHDR.mutex | 509 | Committed | Not processed | Aleksander Alekseev (a.alekseev) | Anastasia Lubennikova (lubennikovaav) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| GROUP BY cardinality estimation improvement | 538 | Committed | Not processed | Tomas Vondra (fuzzycz) | Alexander Korotkov (smagen), Dean Rasheed (deanr) | Dean Rasheed (deanr) | 1 | 9 years ago | |||
| use foreign keys to improve join estimates | 539 | Committed | Not processed | Tomas Vondra (fuzzycz) | Simon Riggs (simon) | Simon Riggs (simon) | 1 | 9 years ago | |||
| Reduce WAL logging for 2PC GID | 555 | Committed | Not processed | Pavan Deolasee (pavan) | Petr Jelínek (pjmodos), Stas Kelvich (kelvich), Jesper Pedersen (jpedersen) | Simon Riggs (simon) | 1 | 9 years ago | |||
| Upper planner path-ification | 557 | Committed | Not processed | Tom Lane (tgl) | Robert Haas (rhaas) | Tom Lane (tgl) | 1 | 9 years ago | |||
| snapshot too old, configured by time | 562 | Committed | Not processed | Kevin Grittner (kgrittn) | Peter Geoghegan (pgeoghegan), Jose Luis Tallon (jltallon) | Kevin Grittner (kgrittn) | 1 | 9 years ago | |||
| Procedural Languages | |||||||||||
| pl/pgSQL, get diagnostics and big data | 500 | Committed | Not processed | Andreas 'ads' Scherbaum (ads) | Christian Ullrich (chrullrich) | Tom Lane (tgl) | 1 | 9 years ago | |||
| Convert pltcl to using objects instead of strings | 506 | Committed | Not processed | Jim Nasby (decibel), Karl Lehenbauer (karl) | Victor Wagner (vitus_wagner) | Tom Lane (tgl) | 1 | 9 years ago | |||
| enhanced custom error in PLPythonu | 525 | Committed | Not processed | Pavel Stehule (okbobcz) | Catalin Iacob (cataliniacob) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| Improve error reporting in pltcl | 550 | Committed | Not processed | Jim Nasby (decibel) | Pavel Stehule (okbobcz) | Tom Lane (tgl) | 1 | 9 years ago | |||
| Refactoring | |||||||||||
| Refactor Client Log Output Filtering | 431 | Committed | Not processed | David Steele (dsteele) | Petr Jelínek (pjmodos), Fabien Coelho (calvin) | Tom Lane (tgl) | 2 | 9 years ago | |||
| Optimized use of launched workers in parallelism code | 489 | Committed | Not processed | Amit Kapila (amitkapila) | Haribabu Kommi (haribabu) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Reworks of CustomScan serialization/deserialization | 554 | Committed | Not processed | KaiGai Kohei (kaigai) | Petr Jelínek (pjmodos) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Refactor receivelog.c | 577 | Committed | Not processed | Magnus Hagander (mha) | Craig Ringer (ringerc), Daniel Gustafsson (d_gustafsson) | Magnus Hagander (mha) | 1 | 9 years ago | |||
| Replication & Recovery | |||||||||||
| Spurious standby query cancellations | 342 | Committed | Not processed | Jeff Janes (jjanes) | Amit Kapila (amitkapila), Simon Riggs (simon) | Simon Riggs (simon) | 4 | 9 years ago | |||
| remove wal_level archive | 413 | Committed | Not processed | Peter Eisentraut (petere) | David Steele (dsteele) | Peter Eisentraut (petere) | 2 | 9 years ago | |||
| Generic WAL Logical Messages | 468 | Committed | Not processed | Andres Freund (andresfreund), Petr Jelínek (pjmodos) | Simon Riggs (simon), Artur Zakirov (a.zakirov) | Simon Riggs (simon) | 2 | 9 years ago | |||
| Support multiple synchronous standby servers | 517 | Committed | Not processed | Masahiko Sawada (masahikosawada) | Kyotaro Horiguchi (horiguti), Thomas Munro (macdice) | Fujii Masao (masaofujii) | 1 | 9 years ago | |||
| Timeline following for logical slots | 568 | Committed | Not processed | Craig Ringer (ringerc) | Simon Riggs (simon), Petr Jelínek (pjmodos) | Álvaro Herrera (alvherre) | 1 | 9 years ago | |||
| Security | |||||||||||
| Use correct realm name in SSPI authentication | 477 | Committed | Not processed | Christian Ullrich (chrullrich) | Magnus Hagander (mha), Robbie Harwood (rharwood) | Magnus Hagander (mha) | 1 | 9 years ago | |||
| pgcrypto: add s2k-count | 508 | Committed | Not processed | Jeff Janes (jjanes) | Álvaro Herrera (alvherre) | 1 | 9 years ago | ||||
| Server Features | |||||||||||
| postgres_fdw: Options to set fetch_size at the server and table level. | 169 | Committed | Not processed | Kyotaro Horiguchi (horiguti), Corey Huinker (coreyh) | Robert Haas (rhaas) | 5 | 9 years ago | ||||
| Freeze avoidance of very large table | 221 | Committed | Not processed | Masahiko Sawada (masahikosawada) | Amit Kapila (amitkapila), Robert Haas (rhaas), Kyotaro Horiguchi (horiguti), Fujii Masao (masaofujii) | Robert Haas (rhaas) | 4 | 9 years ago | |||
| Access method extendability | 353 | Committed | Not processed | Alexander Korotkov (smagen) | Fedor Sigaev (sigaev), Petr Jelínek (pjmodos), Aleksander Alekseev (a.alekseev) | Fedor Sigaev (sigaev) | 4 | 9 years ago | |||
| DML Pushdown for foreign tables | 453 | Committed | Not processed | Etsuro Fujita (efujita) | Rushabh Lathia (rlathia) | Robert Haas (rhaas) | 2 | 9 years ago | |||
| Add BSD Authentication support | 476 | Committed | Not processed | Marisa Emerson (mje) | Thomas Munro (macdice) | Tom Lane (tgl) | 1 | 9 years ago | |||
| CustomScan/ForeignScan under the Gather node | 495 | Committed | Not processed | KaiGai Kohei (kaigai) | Robert Haas (rhaas) | 1 | 9 years ago | ||||
| Phrase search | 498 | Committed | Not processed | Fedor Sigaev (sigaev), Dmitry Ivanov (funbringer) | Alexander Korotkov (smagen), Artur Zakirov (a.zakirov) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| Detect SSI conflicts before reporting constraint violations | 501 | Committed | Not processed | Thomas Munro (macdice) | Marko Tiikkaja (johto), Kevin Grittner (kgrittn) | Kevin Grittner (kgrittn) | 1 | 9 years ago | |||
| support for box type in SP-GiST index | 519 | Committed | Not processed | Fedor Sigaev (sigaev), Alexander Lebedev (a.lebedev) | Emre Hasegeli (hasegeli) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| Prepared Statement support for Parallel query | 529 | Committed | Not processed | Amit Kapila (amitkapila) | Robert Haas (rhaas) | 1 | 9 years ago | ||||
| jsonb_insert | 530 | Committed | Not processed | Dmitry Dolgov (erthalion) | Petr Jelínek (pjmodos), Vitaly Burovoy (vitaly.burovoy) | Fedor Sigaev (sigaev) | 1 | 9 years ago | |||
| parallel aggregate | 551 | Committed | Not processed | David Rowley (davidrowley), Haribabu Kommi (haribabu) | Robert Haas (rhaas) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Combine Aggs: Serialize/Deserialize Internal aggregate states | 552 | Committed | Not processed | David Rowley (davidrowley) | Robert Haas (rhaas) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| pg_dump dump catalog ACLs | 563 | Committed | Not processed | Stephen Frost (sfrost) | Alexander Korotkov (smagen), Jose Luis Tallon (jltallon) | Stephen Frost (sfrost) | 1 | 9 years ago | |||
| Default Roles | 564 | Committed | Not processed | Stephen Frost (sfrost) | Jose Luis Tallon (jltallon) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| SQL Commands | |||||||||||
| Tsvector editing functions | 385 | Committed | Not processed | Stas Kelvich (kelvich) | Fedor Sigaev (sigaev), Tomas Vondra (fuzzycz) | Fedor Sigaev (sigaev) | 3 | 9 years ago | |||
| Reduce lock levels down to ShareUpdateExclusiveLock for other relation options in ALTER TABLE statement | 558 | Committed | Not processed | Fabrízio Mello (fabriziomello) | Simon Riggs (simon) | Simon Riggs (simon) | 1 | 9 years ago | |||
| System Administration | |||||||||||
| Implement pg_controldata & pg_config as system SRFs/views | 334 | Committed | Not processed | Joe Conway (jconway) | Bernd Helmle (psoo) | Joe Conway (jconway) | 4 | 9 years ago | |||
| pam auth - add rhost item | 392 | Committed | Not processed | Grzegorz Sampolski (grzsmp) | Haribabu Kommi (haribabu) | Peter Eisentraut (petere) | 2 | 9 years ago | |||
| Idle In Transaction Session Timeout | 497 | Committed | Not processed | Vik Fearing (xocolatl) | Stéphane Schildknecht (sas22) | Robert Haas (rhaas) | 1 | 9 years ago | |||
| Updated backup APIs for non-exclusive backups | 510 | Committed | Not processed | Magnus Hagander (mha) | Amit Kapila (amitkapila), David Steele (dsteele) | Magnus Hagander (mha) | 1 | 9 years ago | |||
| Relaxing SSL key permissions check to allow group read access | 532 | Committed | Not processed | Christoph Berg (myon) | Peter Eisentraut (petere) | Peter Eisentraut (petere) | 1 | 9 years ago | |||
| syslog configurable line splitting behavior | 549 | Committed | Not processed | Peter Eisentraut (petere) | Andreas Karlsson (kandreas) | Peter Eisentraut (petere) | 1 | 9 years ago | |||