Fix the optimization to skip WAL-logging on table created in same transaction

Edit
Comment/Review
Change Status
ID 528
Title Fix the optimization to skip WAL-logging on table created in same transaction
Topic Bug Fixes
Created 2016-02-18 05:46:12
Last modified 2020-04-06 07:02:30 (4 years, 7 months ago)
Latest email 2020-04-06 07:04:25 (4 years, 7 months ago)
Status
2020-03: Committed
2020-01: Moved to next CF
2019-11: Moved to next CF
2019-09: Moved to next CF
2019-07: Moved to next CF
2019-03: Moved to next CF
2019-01: Moved to next CF
2018-11: Moved to next CF
2018-09: Moved to next CF
2018-07: Moved to next CF
2018-03: Moved to next CF
2018-01: Moved to next CF
2017-11: Moved to next CF
2017-09: Moved to next CF
2017-03: Moved to next CF
2017-01: Moved to next CF
2016-11: Moved to next CF
2016-09: Moved to next CF
2016-03: Moved to next CF
Target version 13
Authors Heikki Linnakangas (heikki), Michael Paquier (michael-kun), Kyotaro Horiguchi (horiguti)
Reviewers Kyotaro Horiguchi (horiguti), Michael Paquier (michael-kun), satyanarayana Narlapuram (snarlap), Sameer Arora (sameera), Noah Misch (nmisch), Hüseyin Demir (huseyin.demir)Become reviewer
Committer Noah Misch (nmisch)
Links CFbot results (CirrusCI) CFbot GitHub
Checkout latest CFbot patchset Go to your local checkout of the PostgreSQL repository and run: 
git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/528
git checkout commitfest/cf/528
Emails
WAL logging problem in 9.4.3?
First at 2015-07-02 22:05:24 by Martijn van Oosterhout <kleptog at svana.org>
Latest at 2020-04-06 07:04:25 by Noah Misch <noah at leadboat.com>
Latest attachment (skip-wal-v41nm.tar.gz) at 2020-03-30 04:41:01 from Noah Misch <noah at leadboat.com>
    Attachment (skip-wal-v41nm.tar.gz) at 2020-03-30 04:41:01 from Noah Misch <noah at leadboat.com> (Patch: No)
    Attachment (v36-0001-Skip-WAL-for-new-relfilenodes-under-wal_level-mi.patch) at 2020-03-23 08:20:27 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: No)
    Attachment (debug-parallel-skip-wal-v0.patch) at 2020-03-21 22:49:20 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (skip-wal-v38nm.tar.gz) at 2020-03-16 03:46:47 from Noah Misch <noah at leadboat.com> (Patch: No)
    Attachment (wal_skip_optimize_patchset_20200304.tar.gz) at 2020-03-04 07:29:19 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: No)
    Attachment (createsubid-cosmetics-v35nm.patch) at 2020-03-01 19:56:32 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (createsubid-cosmetics-v35nm.patch) at 2020-02-19 07:44:52 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (v34-0001-Rework-WAL-skipping-optimization.patch) at 2020-01-27 10:28:31 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v33-0001-Rework-WAL-skipping-optimization.patch) at 2020-01-21 09:45:57 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v32-0001-Rework-WAL-skipping-optimization.patch) at 2020-01-16 05:20:57 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v31-0001-Rework-WAL-skipping-optimization.patch) at 2020-01-15 08:18:57 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (0001-Rework-WAL-skipping-optimization.patch) at 2020-01-14 10:35:22 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (skip-wal-v30nm.patch) at 2019-12-26 00:15:21 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (v29-0001-Rework-WAL-skipping-optimization.patch) at 2019-12-25 08:26:30 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (0001-Rework-WAL-skipping-optimization.patch) at 2019-12-24 07:35:35 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (result_shmem1GB.tar.gz) at 2019-12-10 07:59:25 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: No)
    Attachment (v27-0001-Rework-WAL-skipping-optimization.patch) at 2019-12-09 09:04:06 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (benchmark_scripts.tar.gz) at 2019-12-04 04:47:35 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: No)
    Attachment (f.txt.gz) at 2019-12-03 11:51:46 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: No)
    Attachment (tps.png) at 2019-11-28 12:35:08 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: No)
    Attachment (v26-0001-version-nm24.patch) at 2019-11-28 11:56:20 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v25-0001-version-nm.patch) at 2019-11-26 12:37:52 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (0001-Revert-FlushRelationBuffersWithoutRelcache.patch) at 2019-11-21 10:48:58 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (use_real_lsn_as_fake_lsn.patch) at 2019-11-21 07:01:07 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (skip-wal-v24nm.patch) at 2019-11-18 04:54:34 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (v23-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-11-06 08:29:27 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v22-0004-Documentation-for-wal_skip_threshold.patch) at 2019-10-25 13:20:32 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v21-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-10-25 04:12:51 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (wal-optimize-noah-tests-v3.patch) at 2019-09-10 11:45:17 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (v20-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-08-28 06:42:10 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v19-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-08-21 07:32:38 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (wal-optimize-noah-tests-v2.patch) at 2019-08-18 03:52:30 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (v18-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-07-25 01:39:36 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v17-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-07-12 08:37:25 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v16-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-07-10 04:19:14 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v14-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-05-23 07:10:35 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v13-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-05-21 12:29:48 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v12-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-05-20 06:54:30 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v11-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-04-05 03:55:20 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v10-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-04-02 10:54:06 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v9-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-03-26 07:35:07 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v8-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-03-25 12:32:04 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (pending_sync_nbtsort_fix.patch) at 2019-03-20 08:17:54 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (wal-optimize-noah-tests-v1.patch) at 2019-03-11 02:27:08 from Noah Misch <noah at leadboat.com> (Patch: Yes)
    Attachment (v7-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-03-04 03:24:48 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v6-0001-TAP-test-for-copy-truncation-optimization.patch) at 2019-01-30 01:26:34 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v5-0001-TAP-test-for-copy-truncation-optimization.patch) at 2018-12-20 08:32:25 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v4-0004-Fix-WAL-skipping-feature.patch) at 2018-11-14 03:47:36 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v3-0004-Fix-WAL-skipping-feature.patch) at 2018-10-11 08:04:53 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (v2-0001-TAP-test-for-copy-truncation-optimization.patch) at 2018-10-11 04:42:35 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (wal-minimal-copy-truncate-v2-v3.diff) at 2018-07-17 09:24:22 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (wal-minimal-copy-truncate-v2.patch) at 2018-07-11 03:32:41 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (test-wal-minimal-2-bash-script) at 2018-07-10 14:35:58 from Heikki Linnakangas <hlinnaka at iki.fi> (Patch: No)
    Attachment (wal-minimal-copy-truncate.patch) at 2018-07-04 04:59:12 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (0001-Fix-WAL-logging-problem.patch) at 2018-03-30 01:06:46 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (0001-Fix-WAL-logging-problem.patch) at 2018-01-11 08:03:55 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (0001-Fix-WAL-logging-problem.patch) at 2017-12-11 08:54:24 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-horiguchi-5.patch) at 2017-09-14 06:34:59 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-horiguchi-3.patch) at 2017-09-12 04:14:41 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-horiguchi-2.patch) at 2017-04-11 08:38:12 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-horiguchi-2.patch) at 2017-04-11 08:33:41 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-horiguchi-2.patch) at 2017-04-07 23:33:21 from Alvaro Herrera <alvherre at 2ndquadrant.com> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-horiguchi-1.patch) at 2016-09-29 13:02:57 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-2.patch) at 2016-07-29 07:54:42 from Michael Paquier <michael.paquier at gmail.com> (Patch: Yes)
    Attachment (fix-wal-level-minimal-michael-1.patch) at 2016-07-28 07:59:15 from Michael Paquier <michael.paquier at gmail.com> (Patch: Yes)
    Attachment (Fix_wal_logging_problem_20160311.patch) at 2016-03-11 08:32:59 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (0001-Fix-the-optimization-to-skip-WAL-logging-on-table-cr.patch) at 2016-02-04 12:24:21 from Heikki Linnakangas <hlinnaka at iki.fi> (Patch: Yes)
    Attachment (fix-wal-level-minimal-heikki-1.patch) at 2015-07-22 16:21:22 from Heikki Linnakangas <hlinnaka at iki.fi> (Patch: Yes)
    Attachment (fix_wal_logging_copy_truncate.v1.patch) at 2015-07-22 08:18:07 from Simon Riggs <simon at 2ndQuadrant.com> (Patch: Yes)
    Attachment (postgresql-test.tgz) at 2015-07-03 06:01:37 from Martijn van Oosterhout <kleptog at svana.org> (Patch: No)

Annotations

When Who Mail Annotation
2019-09-02 19:20:19 Álvaro Herrera (alvherre) From Kyotaro Horiguchi <horikyota.ntt@gmail.com>
at 2019-08-28 06:42:10		 v20
History
When Who What
2020-04-06 07:02:30 Noah Misch (nmisch) Closed in commitfest 2020-03 with status: Committed
2020-02-28 05:34:08 Hüseyin Demir (huseyin.demir) Added huseyin.demir as reviewer
2020-02-14 09:02:18 Vlad Stetsenko (vlads) Removed vlads from reviewers
2020-02-14 09:02:01 Vlad Stetsenko (vlads) Added vlads as reviewer
2020-02-01 12:41:15 Tomas Vondra (fuzzycz) Closed in commitfest 2020-01 with status: Moved to next CF
2020-01-22 02:39:09 Kyotaro Horiguchi (horiguti) New status: Needs review
2020-01-02 05:43:16 Noah Misch (nmisch) New status: Waiting on Author
2019-11-25 07:23:11 Michael Paquier (michael-kun) Closed in commitfest 2019-11 with status: Moved to next CF
2019-11-05 22:50:46 Noah Misch (nmisch) New status: Ready for Committer
2019-09-30 18:35:34 Álvaro Herrera (alvherre) New status: Waiting on Author
2019-09-30 18:34:21 Álvaro Herrera (alvherre) Closed in commitfest 2019-09 with status: Moved to next CF
2019-09-30 18:34:05 Álvaro Herrera (alvherre) New status: Needs review
2019-09-10 11:48:55 Noah Misch (nmisch) New status: Waiting on Author
2019-09-02 19:20:19 Álvaro Herrera (alvherre) Added annotation "v20" to 20190828.154210.204505676.horikyota.ntt@gmail.com
2019-09-02 19:19:46 Álvaro Herrera (alvherre) New status: Needs review
2019-08-18 03:54:28 Noah Misch (nmisch) New status: Waiting on Author
2019-08-01 23:16:04 Thomas Munro (macdice) Closed in commitfest 2019-07 with status: Moved to next CF
2019-07-23 02:23:36 Kyotaro Horiguchi (horiguti) New status: Needs review
2019-06-06 04:03:46 Noah Misch (nmisch) New status: Waiting on Author
2019-04-09 03:50:50 Kyotaro Horiguchi (horiguti) Changed targetversion to 13
2019-04-08 05:29:55 Michael Paquier (michael-kun) Closed in commitfest 2019-03 with status: Moved to next CF
2019-04-02 10:56:18 Kyotaro Horiguchi (horiguti) New status: Needs review
2019-03-31 22:37:56 Noah Misch (nmisch) New status: Waiting on Author
2019-03-26 07:48:48 Kyotaro Horiguchi (horiguti) New status: Needs review
2019-03-11 02:35:39 Noah Misch (nmisch) Added nmisch as committer
2019-03-11 02:35:32 Noah Misch (nmisch) New status: Waiting on Author
2019-03-09 07:39:11 Noah Misch (nmisch) Added nmisch as reviewer
2019-03-02 13:01:41 亮 王 (liangwang) Removed liangwang from reviewers
2019-03-02 13:01:34 亮 王 (liangwang) Added liangwang as reviewer
2019-02-15 01:50:11 Sameer Arora (sameera) Added sameera as reviewer
2019-02-02 01:18:54 Michael Paquier (michael-kun) Closed in commitfest 2019-01 with status: Moved to next CF
2018-11-30 17:25:46 Dmitry Dolgov (erthalion) Closed in commitfest 2018-11 with status: Moved to next CF
2018-11-23 03:39:24 movead li (lichuancheng) Removed lichuancheng from reviewers
2018-11-23 03:39:15 movead li (lichuancheng) Added lichuancheng as reviewer
2018-10-01 02:17:15 Michael Paquier (michael-kun) Closed in commitfest 2018-09 with status: Moved to next CF
2018-08-10 22:10:16 Andrew Dunstan (adunstan) Closed in commitfest 2018-07 with status: Moved to next CF
2018-04-10 18:17:29 David Steele (dsteele) Closed in commitfest 2018-03 with status: Moved to next CF
2018-03-27 08:34:23 satyanarayana Narlapuram (snarlap) Added snarlap as reviewer
2018-01-31 07:12:14 Kyotaro Horiguchi (horiguti) Closed in commitfest 2018-01 with status: Moved to next CF
2018-01-11 08:03:43 Kyotaro Horiguchi (horiguti) New status: Needs review
2017-11-28 01:36:58 Michael Paquier (michael-kun) New status: Waiting on Author
2017-11-28 01:36:47 Michael Paquier (michael-kun) Closed in commitfest 2017-11 with status: Moved to next CF
2017-10-19 12:32:46 Álvaro Herrera (alvherre) Removed alvherre from committers
2017-10-02 00:15:46 Daniel Gustafsson (d_gustafsson) Closed in commitfest 2017-09 with status: Moved to next CF
2017-09-13 09:11:27 Aleksander Alekseev (a.alekseev) New status: Needs review
2017-09-12 14:30:37 Aleksander Alekseev (a.alekseev) New status: Waiting on Author
2017-09-05 10:03:33 Daniel Gustafsson (d_gustafsson) Changed authors to Michael Paquier (michael-kun), Heikki Linnakangas (heikki), Kyotaro Horiguchi (horiguti)
2017-09-05 09:59:05 Daniel Gustafsson (d_gustafsson) New status: Needs review
2017-04-08 13:54:21 David Steele (dsteele) New status: Waiting on Author
2017-04-08 13:54:02 David Steele (dsteele) Closed in commitfest 2017-03 with status: Moved to next CF
2017-04-08 13:53:56 David Steele (dsteele) New status: Needs review
2017-04-07 23:35:45 Álvaro Herrera (alvherre) Added alvherre as committer
2017-01-31 04:33:36 Michael Paquier (michael-kun) New status: Waiting on Author
2017-01-31 04:33:28 Michael Paquier (michael-kun) Closed in commitfest 2017-01 with status: Moved to next CF
2017-01-31 04:33:22 Michael Paquier (michael-kun) New status: Needs review
2016-12-02 04:39:31 Haribabu Kommi (haribabu) New status: Waiting on Author
2016-12-02 04:39:11 Haribabu Kommi (haribabu) Closed in commitfest 2016-11 with status: Moved to next CF
2016-12-02 04:39:04 Haribabu Kommi (haribabu) New status: Needs review
2016-11-22 10:53:12 Haribabu Kommi (haribabu) New status: Waiting on Author
2016-11-09 00:24:52 Michael Paquier (michael-kun) New status: Needs review
2016-10-31 06:56:45 Michael Paquier (michael-kun) New status: Ready for Committer
2016-10-02 12:42:59 Michael Paquier (michael-kun) Closed in commitfest 2016-09 with status: Moved to next CF
2016-09-26 08:04:45 Kyotaro Horiguchi (horiguti) Added horiguti as reviewer
2016-04-06 06:11:43 Michael Paquier (michael-kun) Changed authors to Heikki Linnakangas (heikki), Michael Paquier (michael-kun)
2016-04-06 06:11:25 Michael Paquier (michael-kun) Closed in commitfest 2016-03 with status: Moved to next CF
2016-04-06 06:11:22 Michael Paquier (michael-kun) New status: Needs review
2016-02-19 13:27:42 Michael Paquier (michael-kun) New status: Waiting on Author
2016-02-18 05:46:31 Michael Paquier (michael-kun) Changed reviewers to Michael Paquier (michael-kun)
2016-02-18 05:46:31 Michael Paquier (michael-kun) Changed authors to Heikki Linnakangas (heikki)
2016-02-18 05:46:31 Michael Paquier (michael-kun) Changed committer to heikki
2016-02-18 05:46:12 Michael Paquier (michael-kun) Attached mail thread 20150702220524.GA9392@svana.org
2016-02-18 05:46:12 Michael Paquier (michael-kun) Created patch record
Edit
Comment/Review
Change Status