Incorrect error message for cancellation triggered by statement_timeout & flaky test

Edit
ID 5070
Title Incorrect error message for cancellation triggered by statement_timeout & flaky test
CI (CFBot) Summary
Stats (from CFBot) Patch version: v7, Patch count: 1, First patch: +33−15, All patches: +33−15
Tags Bugfix Flakyfix
Created 2024-06-24 12:45:50
Last modified 2026-08-01 05:57:46 (2 hours ago)
Latest email 2026-01-14 11:25:14 (6 months ago)
Status
PG20-2 (2026-09-01 – 2026-09-30): Ready for Committer
PG20-1 (2026-07-01 – 2026-07-31): Moved to different CF
PG19-Final (2026-03-01 – 2026-04-09): Moved to different CF
PG19-4 (2026-01-01 – 2026-01-31): Moved to different CF
PG19-3 (2025-11-01 – 2025-11-30): Moved to different CF
PG19-2 (2025-09-01 – 2025-09-30): Moved to different CF
PG19-1 (2025-07-01 – 2025-07-31): Moved to different CF
2025-03 (2025-03-01 – 2025-04-08): Moved to different CF
2025-01 (2025-01-01 – 2025-01-31): Moved to different CF
2024-11 (2024-11-01 – 2024-11-30): Moved to different CF
2024-09 (2024-09-01 – 2024-09-30): Moved to different CF
2024-07 (2024-07-01 – 2024-07-31): Moved to different CF
Target version stable
Authors Jelte Fennema-Nio (jeltef)
Reviewers Yogesh Sharma (sharmay), Akshat Jaimini (akshatj) Become reviewer
Committer
Links
Emails
Add non-blocking version of PQcancel
First at 2022-01-12 15:22:18 by Jelte Fennema <Jelte.Fennema at microsoft.com>
Latest at 2024-12-23 20:15:40 by Tom Lane <tgl at sss.pgh.pa.us>
Latest attachment (reissue-cancel-requests.patch) at 2024-11-21 01:30:54 from Tom Lane <tgl at sss.pgh.pa.us>
    Attachment (reissue-cancel-requests.patch) at 2024-11-21 01:30:54 from Tom Lane <tgl at sss.pgh.pa.us> (Patch: Yes)
    Attachment (reproduce-postgres_fdw-query_cancel-failure.pathch) at 2024-10-01 12:00:00 from Alexander Lakhin <exclusion at gmail.com> (Patch: Yes)
    Attachment (cancel-request-failures.txt) at 2024-08-30 19:21:25 from Tom Lane <tgl at sss.pgh.pa.us> (Patch: No)
    Attachment (libpqsrv_cancel-debugging.patch) at 2024-08-28 18:00:00 from Alexander Lakhin <exclusion at gmail.com> (Patch: Yes)
    Attachment (strace.log) at 2024-07-17 19:00:00 from Alexander Lakhin <exclusion at gmail.com> (Patch: No)
    Attachment (0001-Split-out-the-query_cancel-test-in-postgres_fdw.patch) at 2024-07-16 15:22:25 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v4-0001-Make-postgres_fdw-cancel-test-not-flaky-anymore.patch) at 2024-07-10 12:10:55 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v3-0001-Make-postgres_fdw-cancel-test-not-flaky-anymore.patch) at 2024-06-30 22:38:46 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v2-0001-Make-postgres_fdw-cancel-test-not-flaky-anymore.patch) at 2024-06-25 08:24:37 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (postmaster.log.txt) at 2024-06-25 05:00:00 from Alexander Lakhin <exclusion at gmail.com> (Patch: No)
    Attachment (v1-0001-Do-not-reset-statement_timeout-indicator-outside-.patch) at 2024-06-23 22:59:48 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (0001-Make-libpqsrv_cancel-s-return-type-const-char.patch) at 2024-04-04 08:45:33 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (libpqsrv_cancel.patch) at 2024-03-27 15:34:57 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v37-0001-postgres_fdw-Start-using-new-libpq-cancel-APIs.patch) at 2024-03-22 08:54:29 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v39-0001-postgres_fdw-Start-using-new-libpq-cancel-APIs.patch) at 2024-03-18 18:40:10 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v38-0001-Use-simple-query-protocol-for-cancel-test.patch) at 2024-03-14 09:51:13 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (repro.diff.txt) at 2024-03-13 19:08:30 from Jacob Champion <jacob.champion at enterprisedb.com> (Patch: Yes)
    Attachment (v37-0001-Hopefully-make-cancel-test-more-reliable.patch) at 2024-03-13 10:04:43 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v36-0001-libpq-Add-encrypted-and-non-blocking-query-cance.patch) at 2024-03-12 15:45:41 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v35-0002-Start-using-new-libpq-cancel-APIs.patch) at 2024-03-12 14:04:21 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v34-0001-libpq-Add-encrypted-and-non-blocking-query-cance.patch) at 2024-03-12 09:19:27 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v33-0003-libpq-Move-pg_cancel-to-fe-cancel.c.patch) at 2024-03-07 10:11:32 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v32-0001-Add-missing-connection-statuses-to-docs.patch) at 2024-03-06 18:09:35 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (0001-fixup-libpq-Add-encrypted-and-non-blocking-versions-.patch) at 2024-03-06 14:03:20 from Denis Laxalde <denis.laxalde at dalibo.com> (Patch: Yes)
    Attachment (v32-0005-Start-using-new-libpq-cancel-APIs.patch) at 2024-02-14 18:22:06 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v31-0004-libpq-Add-encrypted-and-non-blocking-versions-of.patch) at 2024-02-14 17:20:44 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v30-0003-libpq-Change-some-static-functions-to-extern.patch) at 2024-02-02 14:03:39 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (0001-pgindent.patch.txt) at 2024-02-02 12:19:38 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v29-0004-Add-non-blocking-version-of-PQcancel.patch) at 2024-01-29 12:28:22 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v28-0002-libpq-Add-pq_release_conn_hosts-function.patch) at 2024-01-28 12:39:42 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v27-0002-libpq-Add-pq_release_conn_hosts-function.patch) at 2024-01-28 09:51:48 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v26-0005-Start-using-new-libpq-cancel-APIs.patch) at 2024-01-26 16:52:45 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v25-0002-Add-non-blocking-version-of-PQcancel.patch) at 2024-01-26 10:44:24 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v24-0003-Start-using-new-libpq-cancel-APIs.patch) at 2023-12-20 13:46:52 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v23-0002-Return-2-from-pqReadData-on-EOF.patch) at 2023-12-14 12:57:47 from Jelte Fennema-Nio <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v22-0003-Add-non-blocking-version-of-PQcancel.patch) at 2023-07-17 13:00:50 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v21-0002-Return-2-from-pqReadData-on-EOF.patch) at 2023-06-19 10:52:48 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v20-0003-Add-non-blocking-version-of-PQcancel.patch) at 2023-04-21 08:20:35 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v19-0002-Return-2-from-pqReadData-on-EOF.patch) at 2023-03-30 10:17:21 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (0001-fixup-Start-using-new-libpq-cancel-APIs.patch) at 2023-03-30 08:07:28 from Denis Laxalde <denis.laxalde at dalibo.com> (Patch: Yes)
    Attachment (v18-0004-Add-non-blocking-version-of-PQcancel.patch) at 2023-03-29 15:58:51 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v17-0002-Copy-and-store-addrinfo-in-libpq-owned-private-m.patch) at 2023-03-28 15:54:06 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (0001-fixup-Add-non-blocking-version-of-PQcancel.patch) at 2023-03-28 14:53:18 from Denis Laxalde <denis.laxalde at dalibo.com> (Patch: Yes)
    Attachment (v16-0003-Return-2-from-pqReadData-on-EOF.patch) at 2023-03-22 12:32:30 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v15-0003-Return-2-from-pqReadData-on-EOF.patch) at 2023-03-15 08:49:23 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v14-0004-Add-non-blocking-version-of-PQcancel.patch) at 2023-03-06 15:42:13 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v13-0002-Refactor-libpq-to-store-addrinfo-in-a-libpq-owne.patch) at 2023-03-01 20:00:49 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v12-0003-Return-2-from-pqReadData-on-EOF.patch) at 2023-03-01 19:47:46 from Jelte Fennema <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v11-0003-Return-2-from-pqReadData-on-EOF.patch) at 2023-01-27 11:50:27 from Jelte Fennema <me at jeltef.nl> (Patch: Yes)
    Attachment (v10-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch) at 2023-01-26 16:42:37 from Jelte Fennema <me at jeltef.nl> (Patch: Yes)
    Attachment (v9-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch) at 2022-11-30 09:20:42 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0001-Add-non-blocking-version-of-PQcancel.patch) at 2022-11-15 11:38:00 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0001-Add-non-blocking-version-of-PQcancel.patch) at 2022-10-05 13:23:34 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0001-Add-documentation-for-libpq_pipeline-tests.patch) at 2022-06-27 09:29:39 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0002-Add-non-blocking-version-of-PQcancel.patch) at 2022-04-04 15:21:54 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0002-Add-non-blocking-version-of-PQcancel.patch) at 2022-04-01 16:13:07 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0001-Add-documentation-for-libpq_pipeline-tests.patch) at 2022-03-30 16:08:16 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0001-Add-non-blocking-version-of-PQcancel.patch) at 2022-01-13 14:51:40 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
    Attachment (0001-Add-non-blocking-version-of-PQcancel.patch) at 2022-01-12 15:22:18 from Jelte Fennema <Jelte.Fennema at microsoft.com> (Patch: Yes)
Always show correct error message for statement timeouts, fixes random buildfarm failures
First at 2025-02-18 09:29:35 by Jelte Fennema-Nio <me at jeltef.nl>
Latest at 2026-01-14 11:25:14 by "Jelte Fennema-Nio" <postgres at jeltef.nl>
Latest attachment (v7-0001-Do-not-reset-statement_timeout-indicator-outside-.patch) at 2026-01-14 11:25:14 from "Jelte Fennema-Nio" <postgres at jeltef.nl>
    Attachment (v7-0001-Do-not-reset-statement_timeout-indicator-outside-.patch) at 2026-01-14 11:25:14 from "Jelte Fennema-Nio" <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v6-0001-Do-not-reset-statement_timeout-indicator-outside-.patch) at 2026-01-09 22:08:15 from "Jelte Fennema-Nio" <postgres at jeltef.nl> (Patch: Yes)
    Attachment (v5-0001-Do-not-reset-statement_timeout-indicator-outside-.patch) at 2025-02-18 09:29:35 from Jelte Fennema-Nio <me at jeltef.nl> (Patch: Yes)
History
When Who What
2026-08-01 05:57:46 Jelte Fennema-Nio (jeltef) Moved from CF PG20-1 to CF PG20-2
2026-04-11 02:56:00 Jelte Fennema-Nio (jeltef) Moved from CF PG19-Final to CF PG20-1
2026-04-09 02:06:25 Yogesh Sharma (sharmay) Added sharmay as reviewer
2026-02-01 00:00:08 CFbot Moved from CF PG19-4 to CF PG19-Final
2025-12-07 14:38:59 Akshat Jaimini (akshatj) Posted review with messageid <176511833932.1475507.5111967663635215418.pgcf@coridan.postgresql.org>
2025-12-07 14:38:59 Akshat Jaimini (akshatj) New status: Ready for Committer
2025-12-01 23:58:00 Jelte Fennema-Nio (jeltef) Moved from CF PG19-3 to CF PG19-4
2025-11-30 11:59:59 Akshat Jaimini (akshatj) Added akshatj as reviewer
2025-10-01 17:30:35 Jelte Fennema-Nio (jeltef) Moved from CF PG19-2 to CF PG19-3
2025-08-01 22:28:01 Jelte Fennema-Nio (jeltef) Changed tags to Bugfix, Flakyfix
2025-08-01 22:24:35 Jelte Fennema-Nio (jeltef) Moved from CF PG19-1 to CF PG19-2
2025-06-22 21:33:41 Jelte Fennema-Nio (jeltef) Changed tags to Bugfix
2025-04-13 20:50:31 Jelte Fennema-Nio (jeltef) Closed in commitfest 2025-03 with status: Moved to next CF
2025-02-18 10:15:43 CFbot Patch does not need rebase anymore
2025-02-18 09:30:07 Jelte Fennema-Nio (jeltef) Attached mail thread CAGECzQQD5f9ce-D1v6vCTT94hG=JbGdTHuf8vQ=HBLz9T4dA1g@mail.gmail.com
2025-02-18 02:14:25 CFbot Patch needs rebase
2025-02-05 21:55:13 Jelte Fennema-Nio (jeltef) Closed in commitfest 2025-01 with status: Moved to next CF
2024-12-05 15:16:21 Jelte Fennema-Nio (jeltef) Closed in commitfest 2024-11 with status: Moved to next CF
2024-10-07 04:25:18 Michael Paquier (michael-kun) Closed in commitfest 2024-09 with status: Moved to next CF
2024-08-01 05:54:53 Corey Huinker (coreyh) Closed in commitfest 2024-07 with status: Moved to next CF
2024-06-25 08:29:26 Jelte Fennema-Nio (jeltef) Changed name to Incorrect error message for cancellation triggered by statement_timeout & flaky test
2024-06-25 08:28:41 Jelte Fennema-Nio (jeltef) Changed authors to Jelte Fennema-Nio (jeltef)
2024-06-24 12:46:04 Jelte Fennema-Nio (jeltef) Changed targetversion to stable
2024-06-24 12:45:51 Jelte Fennema-Nio (jeltef) Attached mail thread AM5PR83MB0178D3B31CA1B6EC4A8ECC42F7529@AM5PR83MB0178.EURPRD83.prod.outlook.com
2024-06-24 12:45:50 Jelte Fennema-Nio (jeltef) Created patch record
Edit