WAL Insertion Lock Improvements

Edit

ID 4141

Title WAL Insertion Lock Improvements

Topic Performance

Created 2023-01-24 07:32:56

Last modified 2023-07-26 03:18:39 (1 year, 3 months ago)

Latest email 2023-07-28 11:27:18 (1 year, 3 months ago)

Status

2023-07: Committed

2023-03: Moved to next CF

Target version

Authors Bharath Rupireddy (bharathrupireddy)

Reviewers Andres Freund (andresfreund), Michael Paquier (michael-kun), Nathan Bossart (bossartn)Become reviewer

Committer Michael Paquier (michael-kun)

Links CFbot results (CirrusCI) CFbot GitHub

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/4141
git checkout commitfest/cf/4141

Emails

Avoid LWLockWaitForVar() for currently held WAL insertion lock in WaitXLogInsertionsToFinish(): First at 2022-11-24 12:43:10 by Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com>
Latest at 2023-07-28 11:27:18 by Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com>
Latest attachment (v10-0001-Optimize-WAL-insertion-lock-acquisition-and-rele.patch) at 2023-07-22 07:38:49 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com>
    Attachment (v10-0001-Optimize-WAL-insertion-lock-acquisition-and-rele.patch) at 2023-07-22 07:38:49 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v9-0001-Optimize-WAL-insertion-lock-acquisition-and-relea.patch) at 2023-07-20 09:08:29 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v8-0001-Optimize-WAL-insertion-lock-acquisition-and-relea.patch) at 2023-05-19 15:04:16 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v7-0001-Optimize-WAL-insertion-lock-acquisition-and-relea.patch) at 2023-05-18 05:48:25 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (test-case 2 -T900 WAL ~256 bytes.png) at 2023-05-10 17:10:20 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: No)
    Attachment (TestArtifacts.zip) at 2023-05-08 12:27:09 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: No)
    Attachment (lwlock_test.tar.gz) at 2023-04-10 04:08:43 from Michael Paquier <michael at paquier.xyz> (Patch: No)
    Attachment (v5-0001-Optimize-WAL-insertion-lock-acquisition-and-relea.patch) at 2023-02-09 06:21:28 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v4-0001-Optimize-WAL-insertion-lock-acquisition-and-relea.patch) at 2023-02-02 13:30:00 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v3-0001-Optimize-WAL-insertion-lock-acquisition-and-relea.patch) at 2023-01-24 13:30:00 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v2-0001-Make-insertingAt-64-bit-atomic.patch) at 2022-12-02 11:02:38 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v1-0001-WAL-Insertion-Lock-Improvements.patch) at 2022-11-25 11:24:19 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)
    Attachment (v1-0001-Avoid-LWLockWaitForVar-for-currently-held-WAL-ins.patch) at 2022-11-24 12:43:10 from Bharath Rupireddy <bharath.rupireddyforpostgres at gmail.com> (Patch: Yes)

History

When	Who	What
2023-07-26 03:18:39	Michael Paquier (michael-kun)	Closed in commitfest 2023-07 with status: Committed
2023-05-24 02:57:34	Michael Paquier (michael-kun)	Added michael-kun as committer
2023-05-22 00:25:51	Michael Paquier (michael-kun)	New status: Ready for Committer
2023-05-22 00:25:35	Michael Paquier (michael-kun)	Changed reviewers to Andres Freund (andresfreund), Michael Paquier (michael-kun), Nathan Bossart (bossartn)
2023-05-18 11:55:22	Bharath Rupireddy (bharathrupireddy)	New status: Needs review
2023-04-10 05:15:33	Michael Paquier (michael-kun)	New status: Waiting on Author
2023-04-09 23:57:36	Michael Paquier (michael-kun)	Closed in commitfest 2023-03 with status: Moved to next CF
2023-02-21 05:49:55	Nathan Bossart (bossartn)	New status: Ready for Committer
2023-01-24 07:33:21	Bharath Rupireddy (bharathrupireddy)	Changed reviewers to Andres Freund (andresfreund), Nathan Bossart (bossartn)
2023-01-24 07:33:21	Bharath Rupireddy (bharathrupireddy)	Changed authors to Bharath Rupireddy (bharathrupireddy)
2023-01-24 07:32:56	Bharath Rupireddy (bharathrupireddy)	Attached mail thread CALj2ACVF+6jLvqKe6xhDzCCkr=rfd6upaGc3477Pji1Ke9G7Bg@mail.gmail.com
2023-01-24 07:32:56	Bharath Rupireddy (bharathrupireddy)	Created patch record

Edit