remove_useless_groupby_columns is too enthusiastic

Title

Topic

Performance

Created

2022-07-12 17:38:23

Last modified

2022-10-12 05:42:07 (2 years, 1 month ago)

Latest email

2022-10-12 05:42:02 (2 years, 1 month ago)

Status

2022-09: Returned with feedback

Target version

Authors

Tom Lane (tgl)

Reviewers

David Rowley (davidrowley)Become reviewer

Committer

Links

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/3766
git checkout commitfest/cf/3766

Emails

remove_useless_groupby_columns is too enthusiastic: First at 2022-07-12 17:31:13 by Tom Lane <tgl at sss.pgh.pa.us>
Latest at 2022-10-12 05:42:02 by Michael Paquier <michael at paquier.xyz>
Latest attachment (prevent-removing-ORDER-BY-columns-from-GROUP-BY-1.patch) at 2022-07-12 17:31:13 from Tom Lane <tgl at sss.pgh.pa.us>
Attachment (prevent-removing-ORDER-BY-columns-from-GROUP-BY-1.patch) at 2022-07-12 17:31:13 from Tom Lane <tgl at sss.pgh.pa.us> (Patch: Yes)

History

When	Who	What
2022-10-12 05:42:07	Michael Paquier (michael-kun)	Closed in commitfest 2022-09 with status: Returned with feedback
2022-09-16 00:23:00	David Rowley (davidrowley)	New status: Waiting on Author
2022-09-16 00:22:54	David Rowley (davidrowley)	Added davidrowley as reviewer
2022-07-12 17:38:35	Tom Lane (tgl)	Changed authors to Tom Lane (tgl)
2022-07-12 17:38:23	Tom Lane (tgl)	Attached mail thread 1657885.1657647073@sss.pgh.pa.us
2022-07-12 17:38:23	Tom Lane (tgl)	Created patch record