BitmapHeapScan table AM violation removal (and use streaming read API)

Edit
ID 4874
Title BitmapHeapScan table AM violation removal (and use streaming read API)
CI (CFBot) Summary
Stats (from CFBot) Patch version: v36, Patch count: 9, First patch: +80−25, All patches: +826−911
Topic Refactoring
Tags
Created 2024-03-01 01:52:02
Last modified 2025-03-15 14:41:05 (7 months ago)
Latest email 2025-04-08 02:33:45 (6 months ago)
Status
2025-03 (2025-03-01 – 2025-04-08): Committed
2025-01 (2025-01-01 – 2025-01-31): Moved to different CF
2024-11 (2024-11-01 – 2024-11-30): Moved to different CF
2024-09 (2024-09-01 – 2024-09-30): Moved to different CF
2024-07 (2024-07-01 – 2024-07-31): Moved to different CF
2024-03 (2024-03-01 – 2024-04-08): Moved to different CF
Target version
Authors Melanie Plageman (melanieplageman)
Reviewers Heikki Linnakangas (heikki), Andres Freund (andresfreund), Tomas Vondra (fuzzycz)Become reviewer
Committer Melanie Plageman (melanieplageman)
Links
Emails
BitmapHeapScan streaming read user and prelim refactoring
First at 2024-02-13 23:11:25 by Melanie Plageman <melanieplageman at gmail.com>
Latest at 2025-04-08 02:33:45 by Thomas Munro <thomas.munro at gmail.com>
Latest attachment (0001-Teach-Parallel-Bitmap-Heap-Scan-to-combine-I-O.patch) at 2025-04-08 02:33:45 from Thomas Munro <thomas.munro at gmail.com>
    Attachment (0001-Teach-Parallel-Bitmap-Heap-Scan-to-combine-I-O.patch) at 2025-04-08 02:33:45 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (Fix-bitmapheapscan-incorrect-recheck-of-NULL-tupl.patch) at 2025-03-24 16:14:46 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (Increase-default-maintenance_io_concurrency-to-16.patch) at 2025-03-17 21:46:04 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v36-0005-Support-buffer-forwarding-in-read_stream.c.patch) at 2025-03-13 21:41:14 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v35-0002-Add-READ_STREAM_RANDOM-flag.patch) at 2025-03-10 23:45:38 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (eic1_drilldown.png) at 2025-03-10 22:11:52 from Melanie Plageman <melanieplageman at gmail.com> (Patch: No)
    Attachment (eic_timing.png) at 2025-03-10 19:06:34 from Melanie Plageman <melanieplageman at gmail.com> (Patch: No)
    Attachment (v34-0002-BitmapHeapScan-uses-the-read-stream-API.patch) at 2025-02-24 22:07:31 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v33-0003-Separate-TBM-Shared-Private-Iterator-and-TBMIter.patch) at 2025-02-24 16:18:01 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v32-0001-Add-lossy-indicator-to-TBMIterateResult.patch) at 2025-02-21 22:00:49 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v31-0001-Delay-extraction-of-TIDBitmap-per-page-offsets.patch) at 2025-02-20 22:17:10 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v30-0004-Remove-table-AM-callback-scan_bitmap_next_block.patch) at 2025-02-19 21:14:30 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (results.pdf) at 2025-02-16 12:29:35 from Tomas Vondra <tomas at vondra.me> (Patch: No)
    Attachment (results.pdf) at 2025-02-16 01:15:15 from Tomas Vondra <tomas at vondra.me> (Patch: No)
    Attachment (0001-Streaming-BHS.patch) at 2025-02-14 17:31:14 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (results.pdf) at 2025-02-14 17:18:47 from Tomas Vondra <tomas at vondra.me> (Patch: No)
    Attachment (pg_test_iorates.c) at 2025-02-14 09:04:41 from Jakub Wartak <jakub.wartak at enterprisedb.com> (Patch: No)
    Attachment (v29-0002-Separate-TBM-Shared-Private-Iterator-and-TBMIter.patch) at 2025-02-10 22:31:19 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v28-0003-BitmapHeapScan-uses-read-stream-API.patch) at 2025-01-30 20:36:12 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v27-0004-BitmapHeapScan-uses-read-stream-API.patch) at 2025-01-29 21:38:31 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v26-0001-Move-BitmapTableScan-per-scan-setup-into-a-helpe.patch) at 2025-01-22 21:24:19 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v25-0001-Remove-unused-rs_cindex-condition-in-heap-AM-bit.patch) at 2024-10-18 20:48:24 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v24-0001-table_scan_bitmap_next_block-implementations-cou.patch) at 2024-10-15 00:34:24 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (0002-Move-BitmapHeapScan-specific-members-into-suffix.patch) at 2024-09-27 20:13:35 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v23-0005-BitmapHeapScan-initialize-some-prefetch-state-el.patch) at 2024-06-19 15:55:20 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v22b-0001-table_scan_bitmap_next_block-counts-lossy-and-e.patch) at 2024-06-18 22:02:56 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: Yes)
    Attachment (v22-0005-BitmapHeapScan-initialize-some-prefetch-state-el.patch) at 2024-06-17 21:22:12 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v21-0001-table_scan_bitmap_next_block-counts-lossy-and-ex.patch) at 2024-06-14 23:56:42 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v7-0001-BitmapHeapScan-Remove-incorrect-assert-and-reset-.patch) at 2024-05-14 21:19:29 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v6-0001-BitmapHeapScan-Remove-incorrect-assert-and-reset-.patch) at 2024-05-14 19:11:39 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v5-0001-BitmapHeapScan-Remove-incorrect-assert-and-reset-.patch) at 2024-05-14 17:42:09 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v4-0001-BitmapHeapScan-Replace-incorrect-assert-with-rein.patch) at 2024-05-13 14:05:03 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v3-0001-BitmapHeapScan-Remove-incorrect-assert.patch) at 2024-05-10 19:48:24 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v2-0001-BitmapHeapScan-Remove-incorrect-assert.patch) at 2024-04-25 23:03:57 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v1-0001-BitmapHeapScan-Remove-incorrect-assert.patch) at 2024-04-23 16:05:05 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v20-0001-table_scan_bitmap_next_block-counts-lossy-and-ex.patch) at 2024-04-07 04:17:34 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v19-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-04-06 21:34:50 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v18-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-04-06 16:04:23 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v17-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-04-06 13:40:11 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v15-review.tgz) at 2024-04-06 00:51:45 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (v16-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-04-05 23:53:30 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v15-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-04-05 08:06:34 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v14-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-04-04 14:35:45 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: Yes)
    Attachment (v13-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-04-03 22:57:59 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v12-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-03-31 15:45:51 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (run-randomized.sh) at 2024-03-29 15:52:58 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (bt.txt) at 2024-03-28 21:43:42 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (v11-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-03-27 19:37:50 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v10-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-03-25 16:07:09 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v9-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-03-24 17:38:33 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (crash.txt) at 2024-03-24 12:36:19 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (v8-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-03-23 00:26:07 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (i5-uncached-cyclic.pdf) at 2024-03-21 14:55:14 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (reproducer.txt) at 2024-03-19 20:34:53 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (v7-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-03-18 15:19:47 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (relative-optimal.png) at 2024-03-17 19:21:12 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (v6-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-03-14 18:16:25 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v2-0001-Remove-redundant-snapshot-copying-from-parallel-l.patch) at 2024-03-14 10:37:02 from Heikki Linnakangas <hlinnaka at iki.fi> (Patch: Yes)
    Attachment (0001-Remove-redundant-snapshot-copying-from-parallel-lead.patch) at 2024-03-13 13:34:15 from Heikki Linnakangas <hlinnaka at iki.fi> (Patch: Yes)
    Attachment (pathed-locks.png) at 2024-03-03 14:36:23 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (cached-transfer-reduced.pdf) at 2024-03-02 23:59:19 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (uniform-pages.pdf) at 2024-03-02 15:05:07 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (prefetch-charts.pdf) at 2024-02-29 23:44:32 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (patch-comparison.pdf) at 2024-02-29 12:54:05 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (bitmapscan-refactoring-results-optimal.pdf) at 2024-02-28 19:23:28 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (bitmapscan-results.pdf) at 2024-02-28 13:22:29 from Tomas Vondra <tomas.vondra at enterprisedb.com> (Patch: No)
    Attachment (v5-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-02-27 14:22:30 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v4-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-02-27 01:50:28 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v3-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch) at 2024-02-16 17:35:59 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v2-0003-BitmapHeapScan-begin-scan-after-bitmap-setup.patch) at 2024-02-16 03:31:02 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
    Attachment (v1-0003-BitmapHeapScan-begin-scan-after-bitmap-setup.patch) at 2024-02-13 23:11:25 from Melanie Plageman <melanieplageman at gmail.com> (Patch: Yes)
History
When Who What
2025-03-15 14:41:05 Melanie Plageman (melanieplageman) Closed in commitfest 2025-03 with status: Committed
2025-03-15 14:41:05 Melanie Plageman (melanieplageman) Changed committer to melanieplageman
2025-03-13 22:01:47 CFbot Patch does not need rebase anymore
2025-03-13 05:33:45 CFbot Patch needs rebase
2025-02-03 14:34:40 Melanie Plageman (melanieplageman) Closed in commitfest 2025-01 with status: Moved to next CF
2024-12-11 04:07:00 Michael Paquier (michael-kun) Closed in commitfest 2024-11 with status: Moved to next CF
2024-10-08 02:19:13 Michael Paquier (michael-kun) Closed in commitfest 2024-09 with status: Moved to next CF
2024-08-01 02:13:31 Corey Huinker (coreyh) Closed in commitfest 2024-07 with status: Moved to next CF
2024-04-08 14:32:40 Andrey Borodin (x4m) Changed targetversion to None
2024-04-07 14:31:35 Melanie Plageman (melanieplageman) Closed in commitfest 2024-03 with status: Moved to next CF
2024-03-13 13:36:18 Heikki Linnakangas (heikki) Added heikki as reviewer
2024-03-02 20:16:44 Melanie Plageman (melanieplageman) Changed targetversion to 17
2024-03-01 01:52:52 Melanie Plageman (melanieplageman) Changed reviewers to Andres Freund (andresfreund), Tomas Vondra (fuzzycz)
2024-03-01 01:52:12 Melanie Plageman (melanieplageman) Changed authors to Melanie Plageman (melanieplageman)
2024-03-01 01:52:02 Melanie Plageman (melanieplageman) Attached mail thread CAAKRu_ZwCwWFeL_H3ia26bP2e7HiKLWt0ZmGXPVwPO6uXq0vaA@mail.gmail.com
2024-03-01 01:52:02 Melanie Plageman (melanieplageman) Created patch record
Edit