standby recovery fails when re-replaying due to missing directory which was removed in previous replay.

Edit
ID 2161
Title standby recovery fails when re-replaying due to missing directory which was removed in previous replay.
Topic Bug Fixes
Created 2019-06-19 08:11:38
Last modified 2022-07-28 06:42:43 (2 years, 2 months ago)
Latest email 2022-08-01 02:01:04 (2 years, 2 months ago)
Status
2022-07: Committed
2022-03: Moved to next CF
2022-01: Moved to next CF
2021-11: Moved to next CF
2021-09: Moved to next CF
2021-07: Moved to next CF
2021-03: Moved to next CF
2021-01: Moved to next CF
2020-11: Moved to next CF
2020-09: Moved to next CF
2020-07: Moved to next CF
2020-03: Moved to next CF
2020-01: Moved to next CF
2019-11: Moved to next CF
2019-09: Moved to next CF
2019-07: Moved to next CF
Target version stable
Authors Kyotaro Horiguchi (horiguti), Paul Guo (paulguo)
Reviewers Michael Paquier (michael-kun)Become reviewer
Committer Álvaro Herrera (alvherre)
Links CFbot results (CirrusCI) CFbot GitHub
Checkout latest CFbot patchset Go to your local checkout of the PostgreSQL repository and run:
git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/2161
git checkout commitfest/cf/2161
Emails
standby recovery fails (tablespace related) (tentative patch and discussion)
First at 2019-04-17 07:56:30 by Paul Guo <pguo at pivotal.io>
Latest at 2022-08-01 02:01:04 by Andres Freund <andres at anarazel.de>
Latest attachment (fix_tsp_drop_test_error.diff) at 2022-07-29 05:20:08 from Kyotaro Horiguchi <horikyota.ntt at gmail.com>
    Attachment (fix_tsp_drop_test_error.diff) at 2022-07-29 05:20:08 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v27-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-07-27 18:54:49 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v26-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-07-20 10:50:49 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v25-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-07-14 21:47:40 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v24-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-07-13 16:43:45 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v23-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-04-05 08:18:57 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v22-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-04-05 07:38:06 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (0001-Tentative-test-for-tsp-replay-fix_12.txt) at 2022-03-28 08:20:42 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v21-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-03-21 18:43:52 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v20-0001-Fix-replay-of-create-database-records-on-standby.patch) at 2022-03-07 08:39:27 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v18-0001-Add-tablespace-support-to-TAP-framework.patch) at 2022-03-04 00:10:48 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v17-0001-Add-tablespace-support-to-TAP-framework.patch) at 2022-03-02 10:31:24 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v16-0001-Add-tablespace-support-to-TAP-framework.patch) at 2022-03-02 07:59:09 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v15-0001-Add-tablespace-support-to-TAP-framework.patch) at 2022-01-20 08:19:04 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v15-0001-Add-tablespace-support-to-TAP-framework.patch) at 2022-01-20 06:07:22 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v14-0001-Add-tablespace-support-to-TAP-framework.patch) at 2021-11-12 07:43:27 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v13-0001-Support-node-initialization-from-backup-with-tab.patch) at 2021-11-08 08:55:16 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (v12-0002-Tests-to-replay-create-database-operation-on-sta.patch) at 2021-08-05 10:20:44 from Paul Guo <guopa at vmware.com> (Patch: Yes)
    Attachment (v11-0001-Support-node-initialization-from-backup-with-tab.patch) at 2021-03-30 07:12:19 from Paul Guo <guopa at vmware.com> (Patch: Yes)
    Attachment (v10-0001-Support-node-initialization-from-backup-with-tab.patch) at 2020-07-08 12:56:44 from Paul Guo <guopa at vmware.com> (Patch: Yes)
    Attachment (v9-0001-Support-node-initialization-from-backup-with-tabl.patch) at 2020-01-15 10:18:15 from Paul Guo <pguo at pivotal.io> (Patch: Yes)
    Attachment (v8-0001-Support-node-initialization-from-backup-with-tabl.patch) at 2020-01-10 00:22:45 from Alvaro Herrera <alvherre at 2ndquadrant.com> (Patch: Yes)
    Attachment (v6-0001-Support-node-initialization-from-backup-with-tabl.patch) at 2019-12-26 14:45:19 from Anastasia Lubennikova <a.lubennikova at postgrespro.ru> (Patch: Yes)
    Attachment (v6-0001-Support-node-initialization-from-backup-with-tabl.patch) at 2019-09-20 12:23:56 from Asim R P <apraveen at pivotal.io> (Patch: Yes)
    Attachment (0001-Tests-for-replay-of-create-database-operation-on-sta.patch) at 2019-09-19 11:59:59 from Asim R P <apraveen at pivotal.io> (Patch: Yes)
    Attachment (v1-0001-Create-restartpoint-when-replaying-drop-database.patch) at 2019-09-12 12:02:41 from Asim R P <apraveen at pivotal.io> (Patch: Yes)
    Attachment (v5-0001-skip-copydir-if-either-src-directory-or-dst-direc.patch) at 2019-08-22 13:13:20 from Paul Guo <pguo at pivotal.io> (Patch: Yes)
    Attachment (v4-0001-skip-copydir-if-either-src-directory-or-dst-direc.patch) at 2019-07-15 10:52:01 from Paul Guo <pguo at pivotal.io> (Patch: Yes)
    Attachment (v3-0001-skip-copydir-if-either-src-directory-or-dst-direc.patch) at 2019-06-19 07:21:54 from Paul Guo <pguo at pivotal.io> (Patch: Yes)
    Attachment (v2-0001-skip-copydir-if-either-src-directory-or-dst-direc.patch) at 2019-04-30 06:33:47 from Paul Guo <pguo at pivotal.io> (Patch: Yes)
    Attachment (v2-0004-Fix-failure-of-standby-startup-caused-by-tablespace-.patch) at 2019-04-24 08:13:54 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (0001-Allow-TAP-test-to-excecise-tablespace.patch) at 2019-04-22 12:19:33 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (ignore_dir_create_error_before_consistency_v2.patch) at 2019-04-22 07:40:27 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (ignore_dir_create_error_before_consistency.patch) at 2019-04-22 07:15:13 from Kyotaro HORIGUCHI <horiguchi.kyotaro at lab.ntt.co.jp> (Patch: Yes)
    Attachment (0001-Recursively-create-tablespace-directories-if-those-a.patch) at 2019-04-17 07:56:30 from Paul Guo <pguo at pivotal.io> (Patch: Yes)
History
When Who What
2022-07-28 06:42:43 Álvaro Herrera (alvherre) Closed in commitfest 2022-07 with status: Committed
2022-07-20 12:06:31 Álvaro Herrera (alvherre) Added alvherre as committer
2022-07-18 22:51:09 Jacob Champion (jchampion) Changed reviewers to Michael Paquier (michael-kun)
2022-07-15 18:58:58 Jacob Champion (jchampion) Changed reviewers to
2022-06-29 21:25:41 Jacob Champion (jchampion) Closed in commitfest 2022-03 with status: Moved to next CF
2022-05-30 12:47:30 Bo Li (hope-lee) Removed hope-lee from reviewers
2022-05-30 12:47:26 Bo Li (hope-lee) Added hope-lee as reviewer
2022-04-08 03:47:24 Greg Stark (stark) New status: Needs review
2022-04-02 17:12:19 Álvaro Herrera (alvherre) Changed committer to None
2022-03-29 16:16:23 Álvaro Herrera (alvherre) New status: Waiting on Author
2022-03-25 12:30:31 Álvaro Herrera (alvherre) Closed in commitfest 2022-03 with status: Committed
2022-03-21 11:09:07 Álvaro Herrera (alvherre) Added alvherre as committer
2022-03-14 21:32:21 Robert Haas (rhaas) New status: Needs review
2022-03-04 06:46:25 Michael Paquier (michael-kun) New status: Waiting on Author
2022-02-02 15:41:53 Julien Rouhaud (rjuju) Closed in commitfest 2022-01 with status: Moved to next CF
2022-01-23 02:52:49 Justin Pryzby (justinpryzby) New status: Needs review
2022-01-16 04:43:25 Julien Rouhaud (rjuju) New status: Waiting on Author
2021-12-02 11:09:58 Daniel Gustafsson (d_gustafsson) Closed in commitfest 2021-11 with status: Moved to next CF
2021-11-08 05:35:16 Michael Paquier (michael-kun) Added michael-kun as reviewer
2021-10-01 06:45:13 Michael Paquier (michael-kun) Closed in commitfest 2021-09 with status: Moved to next CF
2021-08-05 10:26:16 Paul Guo (paulguo-vmware) New status: Needs review
2021-08-03 02:35:53 Masahiko Sawada (masahikosawada) New status: Waiting on Author
2021-08-03 02:35:11 Masahiko Sawada (masahikosawada) Closed in commitfest 2021-07 with status: Moved to next CF
2021-08-03 02:35:06 Masahiko Sawada (masahikosawada) New status: Needs review
2021-07-11 07:48:22 shi yuefei (shiyuefei) Removed shiyuefei from reviewers
2021-07-11 07:48:01 shi yuefei (shiyuefei) Added shiyuefei as reviewer
2021-07-09 19:38:42 Ibrar Ahmed (ibrar) New status: Waiting on Author
2021-04-08 15:35:57 David Steele (dsteele) Closed in commitfest 2021-03 with status: Moved to next CF
2021-02-09 09:14:39 Fujii Masao (masaofujii) Removed masaofujii from reviewers
2021-02-01 12:01:49 Masahiko Sawada (masahikosawada) Closed in commitfest 2021-01 with status: Moved to next CF
2021-01-18 08:24:26 Anastasia Lubennikova (lubennikovaav) Removed lubennikovaav from reviewers
2020-11-30 15:23:27 Anastasia Lubennikova (lubennikovaav) Closed in commitfest 2020-11 with status: Moved to next CF
2020-09-30 06:10:31 Michael Paquier (michael-kun) Closed in commitfest 2020-09 with status: Moved to next CF
2020-08-02 21:47:28 Daniel Gustafsson (d_gustafsson) Closed in commitfest 2020-07 with status: Moved to next CF
2020-07-08 13:02:46 Paul Guo (paulguo-vmware) New status: Needs review
2020-07-08 12:37:46 Paul Guo (paulguo-vmware) New status: Waiting on Author
2020-07-07 21:12:57 Daniel Gustafsson (d_gustafsson) Closed in commitfest 2020-07 with status: Returned with feedback
2020-04-08 13:00:00 David Steele (dsteele) New status: Waiting on Author
2020-04-08 12:59:30 David Steele (dsteele) Closed in commitfest 2020-03 with status: Moved to next CF
2020-04-08 12:59:25 David Steele (dsteele) New status: Needs review
2020-03-25 05:52:21 Fujii Masao (masaofujii) New status: Waiting on Author
2020-02-26 11:07:21 Fujii Masao (masaofujii) Added masaofujii as reviewer
2020-02-01 11:57:23 Tomas Vondra (fuzzycz) Closed in commitfest 2020-01 with status: Moved to next CF
2019-12-26 14:48:40 Anastasia Lubennikova (lubennikovaav) New status: Ready for Committer
2019-11-29 03:01:32 Michael Paquier (michael-kun) Closed in commitfest 2019-11 with status: Moved to next CF
2019-09-30 18:33:05 Álvaro Herrera (alvherre) Closed in commitfest 2019-09 with status: Moved to next CF
2019-09-18 14:51:56 Álvaro Herrera (alvherre) New status: Needs review
2019-08-22 16:21:53 Anastasia Lubennikova (lubennikovaav) Added lubennikovaav as reviewer
2019-08-22 16:21:51 Anastasia Lubennikova (lubennikovaav) New status: Waiting on Author
2019-08-19 20:10:29 Álvaro Herrera (alvherre) Changed targetversion to stable
2019-08-01 22:37:42 Thomas Munro (macdice) Closed in commitfest 2019-07 with status: Moved to next CF
2019-06-19 08:12:51 Paul Guo (paulguo-pivotal) Changed authors to Kyotaro Horiguchi (horiguti), Paul Guo (paulguo)
2019-06-19 08:12:03 Paul Guo (paulguo-pivotal) Changed authors to Paul Guo (paulguo)
2019-06-19 08:12:03 Paul Guo (paulguo-pivotal) Changed targetversion to 12
2019-06-19 08:11:38 Paul Guo (paulguo-pivotal) Attached mail thread CAEET0ZGx9AvioViLf7nbR_8tH9-=27DN5xWJ2P9-ROH16e4JUA@mail.gmail.com
2019-06-19 08:11:38 Paul Guo (paulguo-pivotal) Created patch record
Edit