Fix ExecRTCheckPerms() inefficiency with many prunable partitions

Edit

ID 3224

Title Fix ExecRTCheckPerms() inefficiency with many prunable partitions

Topic Performance

Created 2021-06-30 13:37:35

Last modified 2022-12-06 19:34:23 (1 year, 11 months ago)

Latest email 2023-06-30 06:54:38 (1 year, 4 months ago)

Status

2022-11: Committed

2022-09: Moved to next CF

2022-07: Moved to next CF

2022-03: Moved to next CF

2022-01: Moved to next CF

2021-11: Moved to next CF

2021-09: Moved to next CF

2021-07: Moved to next CF

Target version 16

Authors Amit Langote (amitlan)

Reviewers Álvaro Herrera (alvherre), Tom Lane (tgl)Become reviewer

Committer Álvaro Herrera (alvherre)

Links CFbot results (CirrusCI) CFbot GitHub

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/3224
git checkout commitfest/cf/3224

Emails

ExecRTCheckPerms() and many prunable partitions: First at 2021-06-30 13:33:44 by Amit Langote <amitlangote09 at gmail.com>
Latest at 2023-06-30 06:54:38 by Amit Langote <amitlangote09 at gmail.com>
Latest attachment (v2-0001-Add-a-test-case-for-a316a3bc.patch) at 2023-06-28 07:30:54 from Amit Langote <amitlangote09 at gmail.com>
    Attachment (v2-0001-Add-a-test-case-for-a316a3bc.patch) at 2023-06-28 07:30:54 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v1-0001-postgres_fdw-test-userid-propagation-to-rels-unde.patch) at 2023-02-21 07:12:14 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v4-0001-Correctly-set-userid-of-subquery-rel-s-child-rels.patch) at 2023-02-20 07:56:22 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v3-0001-Correctly-set-userid-of-subquery-rel-s-child-rels.patch) at 2023-02-17 12:02:46 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v3-0001-Add-test-case-to-test-a-bug-of-build_simple_rel.patch) at 2023-01-19 11:16:16 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (refactor-0001.patch) at 2023-01-17 10:26:54 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v2-0001-Remove-some-dead-code-in-selfuncs.c.patch) at 2022-12-12 06:23:22 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v1-0001-Remove-some-dead-code-in-selfuncs.c.patch) at 2022-12-11 09:25:48 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (ApplyRetrieveRule-comment-thinko.patch) at 2022-12-07 08:47:13 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v33-0001-Rework-query-relation-permission-checking.patch) at 2022-12-05 03:09:27 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v32-0001-Rework-query-relation-permission-checking.patch) at 2022-12-02 11:13:28 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v31-0001-Generalize-ri_RootToPartitionMap-to-use-for-non-.patch) at 2022-12-02 07:44:05 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v30-0001-Add-ri_RootToChildMap-and-ExecGetRootToChildMap.patch) at 2022-12-01 10:49:54 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (add_rteperminfo_to_flat_rtepermlist.patch) at 2022-11-30 02:56:54 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v29-0003-Rework-query-relation-permission-checking.patch) at 2022-11-29 13:37:56 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v28-0001-Rework-query-relation-permission-checking.patch) at 2022-11-29 09:27:08 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: No)
    Attachment (v27-0002-Fix-AclMode-node-support.patch) at 2022-11-25 11:28:37 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v26-0003-Do-not-add-the-NEW-entry-to-view-rule-action-s-r.patch) at 2022-11-21 12:03:43 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v25-0001-Rework-query-relation-permission-checking.patch) at 2022-11-16 11:44:02 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: No)
    Attachment (0002-Simplify-comment-a-little-bit.patch.txt) at 2022-11-10 11:58:01 from Alvaro Herrera <alvherre at alvh.no-ip.org> (Patch: Yes)
    Attachment (v24-0003-Allow-adding-Bitmapsets-as-Nodes-into-plan-trees.patch) at 2022-11-07 07:03:45 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v23-0004-Add-per-result-relation-extraUpdatedCols-to-Modi.patch) at 2022-10-15 06:00:58 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v22-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-ru.patch) at 2022-10-07 07:31:16 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v22-0004-Add-per-result-relation-extraUpdatedCols-to-Modi.patch) at 2022-10-07 06:49:56 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v21-0001-Rework-query-relation-permission-checking.patch) at 2022-10-07 04:25:42 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v20-0001-Rework-query-relation-permission-checking.patch) at 2022-10-07 01:04:26 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v19-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-ru.patch) at 2022-10-06 13:29:46 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v18-0001-Rework-query-relation-permission-checking.patch) at 2022-10-03 09:10:13 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v17-0001-Rework-query-relation-permission-checking.patch) at 2022-09-07 09:23:06 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v16-0001-Rework-query-relation-permission-checking.patch) at 2022-07-27 03:14:10 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v15-0001-Rework-query-relation-permission-checking.patch) at 2022-07-13 08:00:29 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v14-0001-Rework-query-relation-permission-checking.patch) at 2022-07-06 03:25:42 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v13-0001-Rework-query-relation-permission-checking.patch) at 2022-04-11 05:41:16 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v12-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-ru.patch) at 2022-04-06 01:18:48 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v11-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-ru.patch) at 2022-03-31 03:16:02 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v10-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-ru.patch) at 2022-03-23 07:03:04 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v9-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-rul.patch) at 2022-03-14 07:36:53 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v8-0001-Rework-query-relation-permission-checking.patch) at 2022-01-17 11:50:42 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v7-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-rul.patch) at 2022-01-13 06:39:12 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v6-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-rul.patch) at 2021-12-20 07:13:04 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v5-0001-Rework-query-relation-permission-checking.patch) at 2021-09-10 03:22:30 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v4-0001-Rework-query-relation-permission-checking.patch) at 2021-08-26 09:13:33 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (v3-0002-Remove-UpdateRangeTableOfViewParse.patch) at 2021-08-20 13:46:17 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)
    Attachment (v2-0001-Rework-query-relation-permission-checking.patch) at 2021-07-29 08:40:00 from Amit Langote <amitlangote09 at gmail.com> (Patch: No)
    Attachment (0001-Explicitly-track-RT-indexes-of-relations-to-check-pe.patch) at 2021-06-30 13:33:44 from Amit Langote <amitlangote09 at gmail.com> (Patch: Yes)

History

When	Who	What
2022-12-06 19:34:23	Álvaro Herrera (alvherre)	Closed in commitfest 2022-11 with status: Committed
2022-11-29 08:40:33	Álvaro Herrera (alvherre)	Added alvherre as committer
2022-11-10 04:32:54	Amit Langote (amitlan)	New status: Needs review
2022-11-03 23:44:52	Ian Barwick (barwick)	New status: Waiting on Author
2022-10-12 06:58:00	Michael Paquier (michael-kun)	Closed in commitfest 2022-09 with status: Moved to next CF
2022-08-01 16:52:52	Jacob Champion (jchampion)	Closed in commitfest 2022-07 with status: Moved to next CF
2022-07-28 07:44:56	Amit Langote (amitlan)	Changed targetversion to 16
2022-07-27 20:02:21	Tom Lane (tgl)	Added tgl as reviewer
2022-04-08 14:14:43	Greg Stark (stark)	Closed in commitfest 2022-03 with status: Moved to next CF
2022-02-02 16:33:42	Julien Rouhaud (rjuju)	Closed in commitfest 2022-01 with status: Moved to next CF
2022-01-13 07:45:19	Amit Langote (amitlan)	New status: Needs review
2022-01-13 03:10:14	Julien Rouhaud (rjuju)	New status: Waiting on Author
2021-12-03 02:31:57	Michael Paquier (michael-kun)	Closed in commitfest 2021-11 with status: Moved to next CF
2021-10-04 16:22:37	Jaime Casanova (jcasanov)	Closed in commitfest 2021-09 with status: Moved to next CF
2021-09-01 16:30:03	Álvaro Herrera (alvherre)	Added alvherre as reviewer
2021-07-29 08:35:55	Amit Langote (amitlan)	Closed in commitfest 2021-07 with status: Moved to next CF
2021-07-29 08:35:48	Amit Langote (amitlan)	New status: Needs review
2021-07-07 04:40:20	David Rowley (davidrowley)	New status: Waiting on Author
2021-06-30 13:38:21	Amit Langote (amitlan)	Changed authors to Amit Langote (amitlan)
2021-06-30 13:38:21	Amit Langote (amitlan)	Changed targetversion to 15
2021-06-30 13:37:35	Amit Langote (amitlan)	Attached mail thread CA+HiwqGjJDmUhDSfv-U2qhKJjt9ST7Xh9JXC_irsAQ1TAUsJYg@mail.gmail.com
2021-06-30 13:37:35	Amit Langote (amitlan)	Created patch record

Edit