Fix oldest LSN calculation for WAL segments removal when slots are advancing during checkpoint

5627

Title

CI (CFBot)

Summary

Stats (from CFBot)

Patch version: v3, Patch count: 2, First patch: +65−0, All patches: +361−0

Topic

Bug Fixes

Created

2025-03-03 14:53:27

Last modified

2025-03-03 16:35:05 (3 months ago)

Latest email

2025-06-10 20:14:16 (14 hours ago)

Status

2025-07: Needs review

Target version

Authors

Vitaly Davydov (vitprof)

Reviewers

Become reviewer

Committer

Links

Emails

Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly: First at 2024-10-31 10:18:34 by "Vitaly Davydov" <v.davydov at postgrespro.ru>
Latest at 2025-06-10 20:14:16 by Alexander Korotkov <aekorotkov at gmail.com>
Latest attachment (v3-0001-Keep-WAL-segments-by-slot-s-flushed-restart-LSN.patch) at 2025-06-10 20:14:16 from Alexander Korotkov <aekorotkov at gmail.com>
    Attachment (v3-0001-Keep-WAL-segments-by-slot-s-flushed-restart-LSN.patch) at 2025-06-10 20:14:16 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (v2-0001-Keep-WAL-segments-by-slot-s-flushed-restart-LSN.patch) at 2025-06-03 13:21:19 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (v7-0003-Remove-redundant-ReplicationSlotsComputeRequiredLSN-.patch) at 2025-05-26 10:22:51 from "Vitaly Davydov" <v.davydov at postgrespro.ru> (Patch: Yes)
    Attachment (v6-0003-Remove-redundant-ReplicationSlotsComputeRequiredL.patch) at 2025-05-24 13:28:55 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (v5-0003-Remove-redundant-ReplicationSlotsComputeRequiredL.patch) at 2025-05-24 10:37:52 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (v4-0001-Keep-WAL-segments-by-the-flushed-value-of-the-slo.patch) at 2025-05-22 21:10:27 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (0002-Add-TAP-test-to-check-logical-repl-slot-advance-duri.v3.patch) at 2025-05-20 15:44:44 from "Vitaly Davydov" <v.davydov at postgrespro.ru> (Patch: Yes)
    Attachment (0003-Add-TAP-test-to-check-physical-repl-slot-advance-dur.v2.patch) at 2025-05-02 17:47:48 from "Vitaly Davydov" <v.davydov at postgrespro.ru> (Patch: Yes)
    Attachment (0001-Keep-WAL-segments-by-slot-s-flushed-restart-LSN.patch) at 2025-03-03 15:12:12 from "Vitaly Davydov" <v.davydov at postgrespro.ru> (Patch: Yes)
    Attachment (0001-Keep-WAL-segments-by-slot-s-flushed-restart-LSN.patch) at 2024-12-13 14:34:01 from "Vitaly Davydov" <v.davydov at postgrespro.ru> (Patch: Yes)
    Attachment (0002-TAP-test.patch) at 2024-11-21 23:05:40 from Tomas Vondra <tomas at vondra.me> (Patch: Yes)
    Attachment (restartlsn.pl) at 2024-11-21 16:13:23 from Давыдов Виталий <v.davydov at postgrespro.ru> (Patch: No)
    Attachment (0001-Keep-WAL-segments-by-slot-s-flushed-restart-LSN.patch) at 2024-11-07 13:30:39 from "Vitaly Davydov" <v.davydov at postgrespro.ru> (Patch: Yes)
    Attachment (0001-Keep-WAL-segments-by-slot-s-flushed-restart-LSN.patch) at 2024-10-31 10:32:36 from "Vitaly Davydov" <v.davydov at postgrespro.ru> (Patch: Yes)

History

When	Who	What
2025-05-21 19:11:35	CFbot	Patch does not need rebase anymore
2025-05-20 00:32:29	CFbot	Patch needs rebase
2025-03-03 16:35:05	Vitaly Davydov (vitprof)	New status: Needs review
2025-03-03 14:56:05	Vitaly Davydov (vitprof)	New status: Waiting on Author
2025-03-03 14:54:57	Vitaly Davydov (vitprof)	Changed authors to Vitaly Davydov (vitprof)
2025-03-03 14:53:27	Vitaly Davydov (vitprof)	Attached mail thread 1d12d2-67235980-35-19a406a0@63439497
2025-03-03 14:53:27	Vitaly Davydov (vitprof)	Created patch record