walsender.c comment with no context is hard to understand

Title

Topic

Code Comments

Created

2024-06-19 06:46:13

Last modified

2024-07-26 06:37:14 (3 months, 3 weeks ago)

Latest email

2024-07-09 06:01:33 (4 months, 1 week ago)

Status

2024-07: Committed

Target version

Authors

Peter Smith (smithpb2250)

Reviewers

Committer

Amit Kapila (amitkapila)

Links

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/5056
git checkout commitfest/cf/5056

Emails

walsender.c comment with no context is hard to understand: First at 2024-06-03 05:50:55 by Peter Smith <smithpb2250 at gmail.com>
Latest at 2024-07-09 06:01:33 by Peter Smith <smithpb2250 at gmail.com>
Latest attachment (v4-0001-To-improve-the-code-move-the-error-check-in-logic.patch) at 2024-07-08 03:16:19 from Amit Kapila <amit.kapila16 at gmail.com>
    Attachment (v4-0001-To-improve-the-code-move-the-error-check-in-logic.patch) at 2024-07-08 03:16:19 from Amit Kapila <amit.kapila16 at gmail.com> (Patch: Yes)
    Attachment (v3-0001-To-improve-the-code-move-the-error-check-in-logic.patch) at 2024-07-05 06:50:49 from Amit Kapila <amit.kapila16 at gmail.com> (Patch: Yes)
    Attachment (v2-0001-Relocate-the-flushptr-checking-code.patch) at 2024-06-30 23:34:04 from Peter Smith <smithpb2250 at gmail.com> (Patch: Yes)
    Attachment (v1-0001-Fix-walsender-comment.patch) at 2024-06-27 23:44:38 from Peter Smith <smithpb2250 at gmail.com> (Patch: Yes)

History

When	Who	What
2024-07-26 06:37:14	Peter Smith (smithpb2250)	Closed in commitfest 2024-07 with status: Committed
2024-07-26 06:37:14	Peter Smith (smithpb2250)	Changed committer to amitkapila
2024-06-19 06:46:37	Peter Smith (smithpb2250)	Changed authors to Peter Smith (smithpb2250)
2024-06-19 06:46:13	Peter Smith (smithpb2250)	Attached mail thread CAHut+PvqX49fusLyXspV1Mmd_EekPtXG0oT146vZjcb9XDvNgw@mail.gmail.com
2024-06-19 06:46:13	Peter Smith (smithpb2250)	Created patch record