fix possible overflow in MaybeRemoveOldWalSummaries()

4897

Title

Topic

Bug Fixes

Created

2024-03-15 21:14:29

Last modified

2024-03-20 18:35:35 (8 months ago)

Latest email

2024-03-20 19:24:00 (8 months ago)

Status

2024-07: Committed

Target version

Authors

Nathan Bossart (bossartn)

Reviewers

Become reviewer

Committer

Nathan Bossart (bossartn)

Links

CFbot results (CirrusCI) CFbot GitHub

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/4897
git checkout commitfest/cf/4897

Emails

cleanup patches for incremental backup: First at 2024-01-05 14:37:21 by Robert Haas <robertmhaas at gmail.com>
Latest at 2024-03-20 19:24:00 by Nathan Bossart <nathandbossart at gmail.com>
Latest attachment (v1-0001-Revert-Temporary-patch-to-help-debug-pg_walsummar.patch) at 2024-03-15 01:52:55 from Nathan Bossart <nathandbossart at gmail.com>
    Attachment (v1-0001-Revert-Temporary-patch-to-help-debug-pg_walsummar.patch) at 2024-03-15 01:52:55 from Nathan Bossart <nathandbossart at gmail.com> (Patch: Yes)
    Attachment (overflow_fix.patch) at 2024-03-14 21:00:10 from Nathan Bossart <nathandbossart at gmail.com> (Patch: Yes)
    Attachment (v1-0001-Revise-pg_walsummary-s-002_blocks-test-to-avoid-s.patch) at 2024-01-30 16:52:54 from Robert Haas <robertmhaas at gmail.com> (Patch: Yes)
    Attachment (repro_and_fix.patch) at 2024-01-27 16:31:09 from Nathan Bossart <nathandbossart at gmail.com> (Patch: Yes)
    Attachment (v2-0001-Temporary-patch-to-help-debug-pg_walsummary-test-.patch) at 2024-01-26 16:04:37 from Robert Haas <robertmhaas at gmail.com> (Patch: Yes)
    Attachment (v1-0001-Temporary-patch-to-help-debug-pg_walsummary-test-.patch) at 2024-01-25 15:06:41 from Robert Haas <robertmhaas at gmail.com> (Patch: Yes)
    Attachment (v3-0001-incremental-backups-Add-new-items-to-glossary-mon.patch) at 2024-01-17 18:42:37 from Matthias van de Meent <boekewurm+postgres at gmail.com> (Patch: Yes)
    Attachment (v2-0001-incremental-backups-Add-new-items-to-glossary-mon.patch) at 2024-01-16 20:22:15 from Matthias van de Meent <boekewurm+postgres at gmail.com> (Patch: Yes)
    Attachment (v1-0001-incremental-backups-Add-new-items-to-glossary-mon.patch) at 2024-01-15 20:31:18 from Matthias van de Meent <boekewurm+postgres at gmail.com> (Patch: Yes)
    Attachment (pg_walsummary-fixes.patch) at 2024-01-13 18:00:00 from Alexander Lakhin <exclusion at gmail.com> (Patch: Yes)
    Attachment (pg_walsummary_sgml_v1.diff) at 2024-01-12 00:58:49 from "Shinoda, Noriyoshi (HPE Services Japan - FSIP)" <noriyoshi.shinoda at hpe.com> (Patch: Yes)
    Attachment (v2-0002-Add-new-pg_walsummary-tool.patch) at 2024-01-09 18:18:51 from Robert Haas <robertmhaas at gmail.com> (Patch: Yes)
    Attachment (v1-0002-Add-new-function-pg_get_wal_summarizer_state.patch) at 2024-01-05 14:37:21 from Robert Haas <robertmhaas at gmail.com> (Patch: Yes)

History

When	Who	What
2024-03-20 18:35:36	Nathan Bossart (bossartn)	Closed in commitfest 2024-07 with status: Committed
2024-03-19 19:25:33	Nathan Bossart (bossartn)	New status: Ready for Committer
2024-03-19 19:25:31	Nathan Bossart (bossartn)	Added bossartn as committer
2024-03-15 21:14:37	Nathan Bossart (bossartn)	Changed authors to Nathan Bossart (bossartn)
2024-03-15 21:14:37	Nathan Bossart (bossartn)	Changed targetversion to 17
2024-03-15 21:14:29	Nathan Bossart (bossartn)	Attached mail thread CA+Tgmobvqqj-DW9F7uUzT-cQqs6wcVb-Xhs=w=hzJnXSE-kRGw@mail.gmail.com
2024-03-15 21:14:29	Nathan Bossart (bossartn)	Created patch record