Fix checksum verification in base backups for zero page headers

Edit
Comment/Review
Change Status
ID 2719
Title Fix checksum verification in base backups for zero page headers
Topic Bug Fixes
Created 2020-09-01 10:23:42
Last modified 2021-09-13 11:45:20 (3 years, 2 months ago)
Latest email 2021-09-13 11:45:08 (3 years, 2 months ago)
Status
2021-09: Returned with feedback
2021-07: Moved to next CF
2021-03: Moved to next CF
2021-01: Moved to next CF
2020-11: Moved to next CF
2020-09: Moved to next CF
Target version
Authors Michael Banck (mbanck)
Reviewers Anastasia Lubennikova (lubennikovaav), David Steele (dsteele)Become reviewer
Committer
Links CFbot results (CirrusCI) CFbot GitHub
Checkout latest CFbot patchset Go to your local checkout of the PostgreSQL repository and run: 
git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/2719
git checkout commitfest/cf/2719
Emails
Online verification of checksums
First at 2018-07-26 11:59:33 by Michael Banck <michael.banck at credativ.de>
Latest at 2021-09-13 11:45:08 by Daniel Gustafsson <daniel at yesql.se>
Latest attachment (v8-master-0001-Fix-page-verifications-in-base-backups.patch) at 2020-10-30 02:30:28 from Michael Paquier <michael at paquier.xyz>
    Attachment (v8-master-0001-Fix-page-verifications-in-base-backups.patch) at 2020-10-30 02:30:28 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (checksums-zeros-v7.patch) at 2020-10-22 01:41:53 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random_V4.patch) at 2020-04-06 19:59:15 from Tom Lane <tgl at sss.pgh.pa.us> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random_V3.patch) at 2020-03-12 06:32:12 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random_V2.patch) at 2020-02-25 17:28:54 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random.patch) at 2019-10-18 09:05:52 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V18.patch) at 2019-03-28 20:09:22 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V17.patch) at 2019-03-28 16:08:33 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_checksums_tap_tests_random_empty_pageheader.patch) at 2019-03-27 10:37:25 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_basebackup_random_or_zero_pageheader_V2.patch) at 2019-03-26 18:23:19 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_basebackup_random_or_zero_pageheader.patch) at 2019-03-26 17:22:55 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V16.patch) at 2019-03-18 20:15:42 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V15.patch) at 2019-03-18 07:39:42 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V14.patch) at 2019-03-18 07:18:18 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V13.patch) at 2019-03-08 11:51:21 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V12.patch) at 2019-03-02 10:45:48 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V11.patch) at 2019-03-01 00:05:14 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V10.patch) at 2019-02-16 12:22:58 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V9.patch) at 2019-02-04 07:57:17 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V8.patch) at 2018-12-20 15:19:11 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V7.patch) at 2018-11-21 12:35:35 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V6.patch) at 2018-10-30 13:22:26 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V5.patch) at 2018-09-26 15:15:27 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V4.patch) at 2018-09-26 14:37:18 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V3.patch) at 2018-09-19 13:52:53 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V2.patch) at 2018-09-18 14:37:22 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_verify_checksums_recheck_lsn.patch) at 2018-09-18 10:37:02 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V1.patch) at 2018-07-26 11:59:33 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)

Annotations

When Who Mail Annotation
2020-11-16 07:14:48 Michael Paquier (michael-kun) From Michael Paquier <michael@paquier.xyz>
at 2020-11-05 01:57:16		 We may consider removing the feature in stable branches instead.
[patch] Fix checksum verification in base backups for zero page headers
First at 2020-09-01 10:22:29 by Michael Banck <michael.banck at credativ.de>
Latest at 2020-10-30 02:33:42 by Michael Paquier <michael at paquier.xyz>
Latest attachment (checksums-zeros-v8.patch) at 2020-10-26 01:13:15 from Michael Paquier <michael at paquier.xyz>
    Attachment (checksums-zeros-v8.patch) at 2020-10-26 01:13:15 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (checksums-zeros-v7.patch) at 2020-10-22 01:25:19 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (checksums-zeros-v6.patch) at 2020-10-20 06:24:32 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-zero-p.V5.patch) at 2020-10-16 15:02:52 from Anastasia Lubennikova <a.lubennikova at postgrespro.ru> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-zero-p.V4.patch) at 2020-09-25 06:53:27 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-zero-p.V3.patch) at 2020-09-22 14:30:19 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-zero-p.V2.patch) at 2020-09-22 14:26:31 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-zero-p.patch) at 2020-09-01 10:22:29 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
History
When Who What
2021-09-13 11:45:20 Daniel Gustafsson (d_gustafsson) Closed in commitfest 2021-09 with status: Returned with feedback
2021-08-03 02:37:48 Masahiko Sawada (masahikosawada) New status: Waiting on Author
2021-08-03 02:36:39 Masahiko Sawada (masahikosawada) Closed in commitfest 2021-07 with status: Moved to next CF
2021-08-03 02:36:36 Masahiko Sawada (masahikosawada) New status: Needs review
2021-07-09 19:58:31 Ibrar Ahmed (ibrar) New status: Waiting on Author
2021-04-08 15:37:50 David Steele (dsteele) Closed in commitfest 2021-03 with status: Moved to next CF
2021-03-09 17:08:14 David Steele (dsteele) Added dsteele as reviewer
2021-02-01 12:05:01 Masahiko Sawada (masahikosawada) Closed in commitfest 2021-01 with status: Moved to next CF
2020-12-01 12:34:19 Anastasia Lubennikova (lubennikovaav) Closed in commitfest 2020-11 with status: Moved to next CF
2020-12-01 12:34:11 Anastasia Lubennikova (lubennikovaav) New status: Needs review
2020-11-16 07:14:48 Michael Paquier (michael-kun) Added annotation "We may consider removing the feature in stable branches instead." to 20201105015716.GC1632@paquier.xyz
2020-11-16 07:14:24 Michael Paquier (michael-kun) Attached mail thread 1532606373.3422.5.camel@credativ.de
2020-10-30 16:59:28 Anastasia Lubennikova (lubennikovaav) New status: Ready for Committer
2020-10-16 15:04:15 Anastasia Lubennikova (lubennikovaav) New status: Needs review
2020-10-12 06:53:45 Michael Paquier (michael-kun) Removed michael-kun from committers
2020-10-07 08:19:23 Michael Paquier (michael-kun) New status: Waiting on Author
2020-09-30 06:26:24 Michael Paquier (michael-kun) Closed in commitfest 2020-09 with status: Moved to next CF
2020-09-25 04:38:31 Michael Paquier (michael-kun) Added michael-kun as committer
2020-09-24 14:24:36 Anastasia Lubennikova (lubennikovaav) New status: Ready for Committer
2020-09-22 14:29:33 Michael Banck (mbanck) New status: Needs review
2020-09-07 14:31:25 Anastasia Lubennikova (lubennikovaav) New status: Waiting on Author
2020-09-02 13:50:50 Anastasia Lubennikova (lubennikovaav) Added lubennikovaav as reviewer
2020-09-01 10:23:52 Michael Banck (mbanck) Changed authors to Michael Banck (mbanck)
2020-09-01 10:23:42 Michael Banck (mbanck) Attached mail thread 2439c2d6cee13d611e23ba651e5eb4ab0469bf99.camel@credativ.de
2020-09-01 10:23:42 Michael Banck (mbanck) Created patch record
Edit
Comment/Review
Change Status