pg_upgrade: fail early if tablespace dir already exists for new cluster version

ID 2739

Title pg_upgrade: fail early if tablespace dir already exists for new cluster version

Topic System Administration

Created 2020-09-25 02:53:21

Last modified 2020-10-24 00:26:34 (4 years ago)

Latest email 2020-10-27 02:17:19 (4 years ago)

Status

2020-11: Committed

Target version

Authors Justin Pryzby (justinpryzby)

Reviewers Become reviewer

Committer Bruce Momjian (bmomjian)

Links CFbot results (CirrusCI) CFbot GitHub

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/2739
git checkout commitfest/cf/2739

Emails

First at 2020-09-25 00:55:31 by Justin Pryzby <pryzby at telsasoft.com>
Latest at 2020-10-27 02:17:19 by Bruce Momjian <bruce at momjian.us>
Latest attachment (v3-0001-Avoid-failure-if-tablespace-dirs-exist-and-empty.patch) at 2020-10-20 23:06:38 from Justin Pryzby <pryzby at telsasoft.com>

    Attachment (v3-0001-Avoid-failure-if-tablespace-dirs-exist-and-empty.patch) at 2020-10-20 23:06:38 from Justin Pryzby <pryzby at telsasoft.com> (Patch: Yes)
    Attachment (tablespace.diff) at 2020-10-09 23:42:51 from Bruce Momjian <bruce at momjian.us> (Patch: Yes)
    Attachment (tablespace.diff) at 2020-10-09 18:53:25 from Bruce Momjian <bruce at momjian.us> (Patch: Yes)
    Attachment (v2-0001-pg_upgrade-check-to-avoid-tablespace-failure-mode.patch) at 2020-09-25 20:47:49 from Justin Pryzby <pryzby at telsasoft.com> (Patch: Yes)
    Attachment (v1-0001-pg_upgrade-check-to-avoid-tablespace-failure-mode.patch) at 2020-09-25 00:55:31 from Justin Pryzby <pryzby at telsasoft.com> (Patch: Yes)

When	Who	Mail	Annotation
2020-10-24 00:26:34	Justin Pryzby (justinpryzby)	From Justin Pryzby <pryzby@telsasoft.com> at 2020-10-21 11:54:17	The earlier patches in this thread caused --check to notice a failure. The v3 patch now (also) sometimes avoids the failure altogether

History

When	Who	What
2020-10-24 00:26:34	Justin Pryzby (justinpryzby)	Added annotation "The earlier patches in this thread caused --check to notice a failure. The v3 patch now (also) sometimes avoids the failure altogether" to 20201021115416.GK9241@telsasoft.com
2020-10-16 01:24:08	Justin Pryzby (justinpryzby)	Closed in commitfest 2020-11 with status: Committed
2020-10-08 21:54:53	Bruce Momjian (bmomjian)	Added bmomjian as committer
2020-09-26 21:14:35	Justin Pryzby (justinpryzby)	Changed name to pg_upgrade: fail early if tablespace dir already exists for new cluster version
2020-09-25 02:53:32	Justin Pryzby (justinpryzby)	Changed authors to Justin Pryzby (justinpryzby)
2020-09-25 02:53:21	Justin Pryzby (justinpryzby)	Attached mail thread 20200925005531.GJ23631@telsasoft.com
2020-09-25 02:53:21	Justin Pryzby (justinpryzby)	Created patch record