vacuum_set_xid_limits() can set multiXactCutoff to an unsafe value

Title

Topic

Bug Fixes

Created

2019-09-06 17:05:16

Last modified

2019-10-17 02:10:10 (5 years, 1 month ago)

Latest email

2019-10-16 23:25:08 (5 years, 1 month ago)

Status

2019-11: Committed

Target version

Authors

Nathan Bossart (bossartn), Jeremy Schneider (jer)

Reviewers

Thomas Munro (macdice)Become reviewer

Committer

Thomas Munro (macdice)

Links

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/2280
git checkout commitfest/cf/2280

Emails

ERROR: multixact X from before cutoff Y found to be still running: First at 2019-09-05 00:37:40 by "Bossart, Nathan" <bossartn at amazon.com>
Latest at 2019-10-16 23:25:08 by Thomas Munro <thomas.munro at gmail.com>
Latest attachment (0001-Fix-bug-that-could-try-to-freeze-running-multixacts.patch) at 2019-10-16 06:10:48 from Thomas Munro <thomas.munro at gmail.com>
    Attachment (0001-Fix-bug-that-could-try-to-freeze-running-multixacts.patch) at 2019-10-16 06:10:48 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (fix_multixact_limit_v2.patch) at 2019-09-05 01:01:05 from Jeremy Schneider <schnjere at amazon.com> (Patch: Yes)
    Attachment (fix_multixact_limit.patch) at 2019-09-05 00:37:40 from "Bossart, Nathan" <bossartn at amazon.com> (Patch: Yes)

History

When	Who	What
2019-10-17 02:10:10	Thomas Munro (macdice)	Closed in commitfest 2019-11 with status: Committed
2019-10-17 02:10:10	Thomas Munro (macdice)	Changed committer to macdice
2019-09-06 17:05:54	Nathan Bossart (bossartn)	Changed reviewers to Thomas Munro (macdice)
2019-09-06 17:05:54	Nathan Bossart (bossartn)	Changed authors to Nathan Bossart (bossartn), Jeremy Schneider (jer)
2019-09-06 17:05:16	Nathan Bossart (bossartn)	Attached mail thread DAFB8AFF-2F05-4E33-AD7F-FF8B0F760C17@amazon.com
2019-09-06 17:05:16	Nathan Bossart (bossartn)	Created patch record