Log In - Home Page

Patch: Show all errors in postgresql.conf instead of only the first one

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2011-06
Topic Server Administration
Patch Status Returned with Feedback
Author Alexey Klyukin
Reviewers Florian Pflug, Alvaro Herrera
Committer Nobody
Close Date 2011-07-19
Comments
Patch by alexk on 2011-05-13 11:03:43 PM: Initial version.
Review by fgp on 2011-06-16 11:37:56 AM: Suggested to report multiple errors on startup also, not only on SIGUP. There's also a small bug regarding included files and some coding style nitpicks.
Patch by alexk on 2011-06-17 01:33:05 PM: V2, address the problems found during Florian's review.
Patch by fgp on 2011-06-18 02:43:55 PM: Some stylistic improvements on top of V2 plus removal of the early abort if IsUnderPostmater for fear of inconsistent results.
Patch by alexk on 2011-06-21 11:25:55 AM: New version, V2b, minor improvements over the V2, derived from the Florian's patch. Return of early aborts.
Review by alexk on 2011-06-21 11:30:34 AM: Florian's review. He still thinks that aborting the parser early for the normal backend case makes code harder to read and potentially error-prone, although he states this is his personal opinion and the patch can be marked as 'ready for committer'.
Comment by tgl on 2011-07-16 12:03:59 AM: I think we should take another look at what behavior we actually want overall.
Patch by tgl on 2011-07-19 04:01:04 PM: This is Alvaro's V3, which for some reason he didn't add to the CF entry.
Comment by alvherre on 2011-07-19 11:17:00 PM: Alexey is going to rework per Tom's comments above. I'm going to mark it as returned with feedback.

Add Comment

Please log in to comment on this patch.