Log In - Home Page

Patch: Add Support for building with Visual Studio 2010

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2011-11
Topic Miscellaneous
Patch Status Committed
Author Brar Piening
Reviewers Craig Ringer
Committer Andrew Dunstan
Close Date 2012-01-03
Comments
Patch by brar on 2011-01-17 05:57:35 PM: Initial version.
Patch by brar on 2011-01-17 05:59:00 PM: Revision 2 with linefeeds fixed
Patch by brar on 2011-01-17 06:01:28 PM: Revision 3 - Refactored and fixed some issues with pgbison.bat and pgflex.bat
Patch by brar on 2011-01-17 06:22:19 PM: Revision 4 - After running perltidy
Comment by rhaas on 2011-01-30 02:49:48 PM: Commit ping.
Comment by rhaas on 2011-02-03 10:25:12 PM: Marking this one Returned with Feedback.
Comment by brar on 2011-02-07 02:18:18 AM: If anyone is willing to test this patch in an environment with a custom config.pl that is known to work in an unpatched source tree that would be greatly appreciated.
Patch by brar on 2011-04-06 08:16:10 PM: Revision 5 - Rebased patch and reverted changes to the header files.
Patch by brar on 2011-05-11 05:25:40 AM: Revision 6 - reflects recent fixes to pgflex.bat (yywrap macro definition for non-reentrant scanners) in pgflex.pl
Comment by brar on 2011-05-13 09:43:45 PM: No longer considered WIP - please go ahead and test/review it if you're interested in VS2010/SDK7.1 builds.
Patch by brar on 2011-06-06 10:54:54 PM: Updated for code drift - no real changes
Patch by brar on 2011-06-07 05:34:12 AM: Separated out perltidying before. Submitted patch on-list.
Review by ringerc on 2011-07-06 09:09:02 AM: Revision needed to cover documentation, split formatting/cleanup from functional code, and import the pgflex.pl and pgbison.pl mentioned in the reply to this message. 64-bit tests pending, but 32-bit tests worked fine and didn't break anything.
Patch by brar on 2011-07-07 12:37:47 AM: Added documentation, removed pgflex.pl and pgbison.pl.
No changes to the existing code.
Review by ringerc on 2011-07-07 02:47:41 PM: Tests OK with a variety of configurations. Docs and pgflex/pgbison issues now covered. Ready for committer.
Comment by aglio on 2011-07-17 10:52:39 PM: No committer can commit this patch for at least a week. As such, moving this patch to next commitfest.
Patch by brar on 2011-09-28 07:57:15 PM: New Version - the old one didn't apply cleanly anymore.
Comment by rhaas on 2011-10-12 07:39:54 PM: magnus can't deal with this until after pgconf.eu
Comment by adunstan on 2011-12-09 08:37:45 PM: Waiting on rearrangement of code to make it cleaner and more symmetric.
Patch by brar on 2011-12-27 12:59:38 AM: Updated patch - rearranged code as suggested.
Patch by brar on 2012-01-01 07:24:06 AM: Updated patch - Fixed problems in src/include/port/win32.h that prevented postgres built with VS 2010 from connecting.

Add Comment

Please log in to comment on this patch.