Patch: Pgbench Shell command
Move To Another CommitFest
Returned with Feedback
Dan Colish, Gabrielle Roth, Greg Smith
by michael-kun on 2009-08-06 10:19:42 PM:
by michael-kun on 2009-08-12 09:58:48 PM:
Considering the comments emitted, edition of version 2.
Deletion of -P option.
by sfrost on 2009-09-15 08:05:30 PM:
ping'd Michael on patch status/any updates.
by gabrielle on 2009-09-15 09:25:40 PM:
- You have DOS-style carriage returns, which interfere with the patch application on Unix systems.
- We'd like to see return specifically return a value (lines 1008 and 1022 in the patched version)
- We'd like to see something done with the return value from system (line 1026 in patched version)
- pg_bench functions as expected, however, your example script given on the wiki page for this patch fails (http://wiki.postgresql.org/wiki/Pgbench:_shell_command). Can we have an example that works so we can check it out? It's not really clear to us how this will be useful to others.
by michael-kun on 2009-09-17 03:52:20 AM:
Patch version 3.0 based on last comments.
Addition of system error management
by michael-kun on 2009-09-18 12:38:39 AM:
Review in process
by michael-kun on 2009-09-18 12:39:46 AM:
patch version 4: error handling stuff added
by michael-kun on 2009-09-24 06:01:46 PM:
setshell command feature added, which permits to load a parameter from a shell script output. Usefull for statistical models
by gsmith on 2009-10-08 02:25:48 PM:
Still needs a number of fixes, details in the message.
to comment on this patch.