Log In - Home Page

Patch: Allow passing a connection string to pg_basebackup and pg_receivexlog

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-01
Topic System Administration
Patch Status Committed
Author Amit Kapila, Hari Babu
Reviewers Zoltán Böszörményi, Abhijit Menon-Sen
Committer Nobody
Close Date 2013-02-25
Comments
Patch by amitkapila on 2012-11-16 07:22:31 AM: This patch will allow pg_basebackup and pg_receivexlog to use non-blocking socket communication. It will help to detect network breakdown in a much lesser time than earlier.
Review by zboszor on 2013-01-01 04:50:07 PM: Patch looks good and works nicely.
Patch by haribabu on 2013-01-04 12:58:10 PM: V2 patch: Fixed review comments given by Boszormenyi Zoltan
Patch by haribabu on 2013-01-09 04:05:41 AM: V3 patch rebased to head
Review by ams on 2013-01-16 07:51:27 AM: Various comments about wording etc.
Comment by ams on 2013-01-17 03:00:28 AM: Heikki says we should use TCP keepalives instead
Patch by haribabu on 2013-01-26 05:52:45 AM: Connection string has been introduced to pg_basebackup and pg_receivexlog as per comments from Heikki.
Comment by heikki on 2013-02-11 09:21:52 PM: This could be simplified with the "Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq" patch
Patch by heikki on 2013-02-21 08:44:25 AM: Actually, the "Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq" patch was of no use.
Comment by heikki on 2013-02-25 05:57:14 PM: Committed after more rework.

Add Comment

Please log in to comment on this patch.