Log In - Home Page

Patch: SQL Command to edit postgresql.conf ("ALTER SYSTEM" patch)

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-11
Topic System Administration
Patch Status Committed
Author Amit Kapila
Reviewers Hari Babu
Committer Tatsuo Ishii
Close Date 2013-12-18
Comments
Patch by amitkapila on 2012-11-16 07:12:24 AM: This patch is to provide user SQL Command or built-in function to edit the server configuration file.
Patch by amitkapila on 2012-11-22 12:52:39 PM: Updated patch to handle SET PERSISTENT command.
Review by masaofujii on 2012-11-23 04:13:46 AM: Found several problems.
Patch by amitkapila on 2012-11-29 05:49:41 AM: Fixed problems and other review comments by Fujii masao and Tom Lane.
Comment by andresfreund on 2012-12-08 03:52:42 PM: Amit will remove RESET PERSISTENT
Patch by amitkapila on 2012-12-10 02:46:53 PM: Updated patch to remove syntax RESET PERSISTENT and handle delete of entry for syntax "SET PERSISTENT... TO DEFAULT".
Review by zboszor on 2013-01-04 05:33:36 PM: Review, comments and request for enhancement.
Patch by amitkapila on 2013-01-09 11:23:48 AM: Handled all review comments and suggestions by Zoltan.
Patch by zboszor on 2013-01-18 09:18:08 PM: Lots of cleanup.
Comment by ringerc on 2013-01-21 02:05:01 AM: Pending testing by author
Patch by amitkapila on 2013-01-22 02:06:57 PM: Changed to make auto.conf.d path w.r.t postgresql.conf
Review by andresfreund on 2013-01-23 08:28:24 PM: several issues noticed, waiting for author to respond
Patch by ringerc on 2013-01-26 11:44:43 PM: Revised by author based on comments and review.
Patch by amitkapila on 2013-01-27 06:04:16 AM: Fixed the review comments of Andres Freund and Fujii Masao.
Patch by amitkapila on 2013-02-15 03:09:33 AM: updated patch to handle comments of Andres Freund
Review by gsmith on 2013-03-04 01:09:12 AM: Suggestions on file naming, length reduction, and some minor bit rot.
Patch by amitkapila on 2013-03-06 11:40:52 AM: This handles comments raised by Greg Smith.
Review by gsmith on 2013-03-10 03:14:44 PM: Functional review. List of surprising behavior and issues with error messages.
Patch by amitkapila on 2013-03-15 12:11:04 PM: Handled review comments of Greg Smith.
Patch by amitkapila on 2013-03-25 12:29:43 PM: to remove SIGHUP from end of command
Review by gsmith on 2013-04-01 07:35:11 AM: Suggestions for eventual code commit sequence.
Patch by amitkapila on 2013-06-14 03:25:25 AM: Updated patch for Alter System Command
Review by aglio on 2013-06-18 05:27:53 PM: Reviewed as OK. Remaining issue is to set the name of the autoconfig file, issue with reload on Windows.
Patch by amitkapila on 2013-06-19 12:54:18 PM: Updated patch to handle suggestions by Zoltan. Windows issue is not due to this patch, so we should handle it separately.
Patch by amitkapila on 2013-06-26 04:47:46 AM: change the file name to postgresql.auto.conf
Review by masaofujii on 2013-07-04 06:05:16 PM: Review comments by Alvaro
Patch by amitkapila on 2013-07-05 06:23:03 AM: Fixed comments given by Alvaro
Patch by amitkapila on 2013-07-16 05:18:21 AM: Fixed issues and review comments given by Fujii Masao
Comment by aglio on 2013-07-18 09:26:50 PM: Still discussing spec for how it integrates with postgresql.conf.
Comment by gsmith on 2013-07-19 03:02:40 AM: Defense of value to using a conf.d directory
Patch by gsmith on 2013-07-22 06:44:16 PM: Updated patch, slims down changes with less regression and user error testing.
Patch by amitkapila on 2013-07-29 12:51:17 PM: Modified patch to have postgresql.auto.conf in $PGDATA
Patch by amitkapila on 2013-09-28 07:11:13 AM: modified patch for left over issues.
Patch by amitkapila on 2013-10-01 02:50:07 AM: updated patch to fix regression failure.
Comment by maiku41 on 2013-10-16 01:39:10 PM: Moved to CF 2013-11
Patch by amitkapila on 2013-11-14 08:04:43 AM: Rebased patch.
Comment by petere on 2013-11-15 04:48:45 PM: build failed: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/196/
Review by haribabu on 2013-11-16 11:07:48 AM: review comments
Patch by amitkapila on 2013-11-18 03:49:20 AM: Fixed review comments raised by Hari babu.

Add Comment

Please log in to comment on this patch.