Log In - Home Page

CommitFest 2010-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 23, Returned with Feedback: 14, Rejected: 6. Total: 43.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
Improve docs for archive_cleanup_command
Patch by direvus on 2010-10-14: Initial version.
Committed Brendan Jurd Simon Riggs 2010-10-14
psql autocompletion for \z and \dg
Patch by schmiddy on 2010-10-21: Initial version.
Committed Josh Kupershmidt Peter Eisentraut 2010-10-28
timestamp of the last replayed transaction
Patch by MasaoFujii on 2010-11-04: Initial version.
Patch by MasaoFujii on 2010-11-09: Change the function name to pg_last_xact_replay_timestamp, per discussion.
Committed Fujii Masao Robert Haas 2010-11-09
Fix cube picksplit implementation
Patch by smagen on 2010-10-26: Initial version.
Committed Alexander Korotkov Robert Haas 2010-11-14
Code cleanup for comparison with "true"
Patch by itagaki on 2010-11-03: Initial version.
Committed Itagaki Takahiro Robert Haas 2010-11-14
Count backend self-sync calls
Patch by gsmith on 2010-11-14: Initial version.
Committed Greg Smith Robert Haas 2010-11-15
Bug in plpython's Python Generators
Patch by rhaas on 2010-11-15: Initial version.
Committed Jan Urbański Oleg Bartunov 2010-11-15
rollback sequence reset for TRUNCATE ... RESTART IDENTITY
Patch by ssinger on 2010-10-26: Initial version.
Review by marco44 on 2010-11-17: Reviewed. Seems OK to me.
Committed Steve Singer Marc Cousin 2010-11-17
Custom code int(32|64) => text conversions out of performance reasons
Patch by andresfreund on 2010-11-01: Initial version.
Patch by rhaas on 2010-11-15: Partially committed, remaining patch needs some cosmetic work.
Patch by andresfreund on 2010-11-19: Comments hopefully addressed
Committed Andres Freund Robert Haas 2010-11-19
function format
Patch by okbobcz on 2010-10-22: Initial version.
Patch by okbobcz on 2010-11-19: changed allocated oids on pg_proc.h
Review by jjanes on 2010-11-20: Looks good, some changes to docs
Committed Pavel Stehule Jeff Janes 2010-11-20
ALTER TYPE recursion
Patch by petere on 2010-11-09: Initial version.
Review by dim on 2010-11-17: Ready for Commit.
Committed Peter Eisentraut Dimitri Fontaine 2010-11-23
Aditional docs index entries and table sorting
Patch by thom on 2010-10-05: Initial version.
Patch by thom on 2010-11-05: Version 2
Committed Thom Brown Peter Eisentraut, Josh Kupershmidt 2010-11-23
Security hooks on object creation
Patch by kaigai on 2010-11-12: Revised patch according to the comments.
Review by rhaas on 2010-11-21: Looks mostly OK, but where's the right place to put the necessary header-file bits?
Patch by kaigai on 2010-11-25: Patch revised. Location of the header file and Name of the invocation macro was revised. Also, hooks added for FDW.
Committed KaiGai Kohei Robert Haas 2010-11-25
ALTER OBJECT any_name SET SCHEMA name
Patch by dim on 2010-11-21: Update v8, adds regression tests for newly added commands.
Review by rhaas on 2010-11-22: Still needs tab completion.
Patch by dim on 2010-11-25: Update v9, including tab completion support for psql, per Robert Haas.
Committed Dimitri Fontaine Robert Haas 2010-11-26
contrib: auth_delay module
Patch by kaigai on 2010-11-04: Initial version.
Review by rhaas on 2010-11-14: Would anyone use this? Should we remove the log-superuser-connections bit? Also, needs docs!
Patch by kaigai on 2010-11-25: Patch revised - Logger part has gone, and Documentation was added
Committed KaiGai Kohei Robert Haas 2010-11-27
cfparser
Patch by dim on 2010-11-23: Update v4, fixes relative path when calling_file is NULL, per Alvaro
Patch by dim on 2010-11-24: Update v5, fixes an open/close/open sequence by extending current ParseConfigFile API, per Itagaki
Comment by itagaki on 2010-11-25: list of items to be re-checked by committers
Committed Dimitri Fontaine Itagaki Takahiro 2010-12-03
Revert default wal_sync_method to fdatasync on Linux 2.6.33+
Patch by gsmith on 2010-11-14: Initial version.
Review by gsmith on 2010-11-16: Background look at changes in recent kernels
Comment by gsmith on 2010-12-01: Related bugs in kernel may force preferred behavior and backpatching here
Committed Marti Raudsepp Greg Smith 2010-12-09
libpq changes for synchronous replication
Patch by MasaoFujii on 2010-11-25: Patch v3, adds protocol documentation.
Review by gsmith on 2010-12-05: Concerns about Copy Both addition
Patch by MasaoFujii on 2010-12-06: Patch v4
Committed Fujii Masao Alvaro Herrera, Tom Lane, Robert Haas 2010-12-11
Label switcher function (trusted procedure)
Patch by kaigai on 2010-11-25: Patch revised according to the previous discussion.
Review by rhaas on 2010-12-06: A few more comments.
Patch by kaigai on 2010-12-07: Patch revised, according to the above comments.
Committed KaiGai Kohei Robert Haas 2010-12-13
Instrument checkpoint sync calls
Review by jjanes on 2010-12-07: Looks good
Patch by gsmith on 2010-12-14: Improve precision of mathematical operations on the time deltas
Review by rhaas on 2010-12-14: Some remaining concerns from Alvaro; I committed before I saw these.
Committed Greg Smith Jeff Janes 2010-12-14
Fix for seg picksplit function
Review by rhaas on 2010-11-15: Review comments.
Patch by smagen on 2010-11-16: Original version of loop was restored
Comment by yhavinga on 2010-11-30: Rationale for marking ready for committer
Committed Alexander Korotkov Yeb Havinga 2010-12-15
pg_execute_from_file()
Comment by dim on 2010-12-03: Some comments and nitpicking
Patch by dim on 2010-12-12: Update v10, the replacement VARIADIC forms are useless, per Tom's review, so removed
Review by rhaas on 2010-12-13: What do we need this for?
Committed Dimitri Fontaine Joshua Tolley, Itagaki Takahiro 2010-12-16
Crash dump handler for Windows
Comment by ringerc on 2010-12-16: Response to review - ack of portability issues, reason, alternate approach suggested
Patch by ringerc on 2010-12-16: Updated patch; see also https://github.com/ringerc/postgres/tree/crashdump
Patch by mha on 2010-12-16: Review + updated patch
Committed Craig Ringer Magnus Hagander 2010-12-19

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Field-specific keywords in pg_hba.conf
Patch by direvus on 2010-10-16: Initial version.
Patch by direvus on 2010-10-16: Original email describes patch but didn't have it attached. See this mail for the patch.
Comment by tgl on 2010-11-17: This patch was already reviewed, and author agreed to pursue a different approach.
Returned with Feedback Brendan Jurd Nobody 2010-11-17
Improving perfromance of prep_buildtree script used in VPATH builds
Review by gsmith on 2010-11-18: Initial performance test doesn't show an improvement
Comment by gsmith on 2010-11-18: Some portability concerns with older BSD systems
Comment by rhaas on 2010-11-21: Marking as Returned With Feedback.
Returned with Feedback Gurjeet Singh Nobody 2010-11-21
JDBC Statement Timout - Client Side
Patch by rsmogura on 2010-10-14: The massage containing patch.
Comment by rhaas on 2010-11-23: JDBC patches do not go through the core CF process.
Returned with Feedback Radosław Smogura Nobody 2010-11-23
KNN-GiST
Review by RhodiumToad on 2010-09-22: Preliminary review
Comment by tgl on 2010-12-03: Applied except for the contrib/btree_gist additions, which I lack the patience to fix, so that part is RWF.
Patch by oleg on 2011-01-21: Revised version of contrib/btree_gist compatible with new API
Returned with Feedback teodor, oleg Andrew Gierth 2010-12-03
Spread checkpoint sync
Comment by rhaas on 2010-11-15: Some preliminary thoughts; needs more review.
Comment by jjanes on 2010-11-20: Applies over "Instrument checkpoint sync calls", so waiting on update of that.
Patch by gsmith on 2010-12-01: Updated patch to address bit-rot
Returned with Feedback Greg Smith, Simon Riggs Nobody 2010-12-05
PLpython exception handling is suprising
Comment by gsmith on 2010-11-18: Tom suggests fixing the underlying behavior may be the right approach here
Comment by gsmith on 2010-12-01: Suggested improved behavior
Comment by gsmith on 2010-12-05: Preferred cleanup added as TODO item
Returned with Feedback Marti Raudsepp Nobody 2010-12-05
Explain Analyze Getrusage Resource tracking
Review by rhaas on 2010-11-15: A few gripes.
Review by gsmith on 2010-12-05: Windows build issues
Comment by rhaas on 2010-12-13: no updates since 11/22
Returned with Feedback Gregory Stark Robert Haas 2010-12-13
Synchronous Replication
Patch by MasaoFujii on 2010-09-15: Updated version
Patch by MasaoFujii on 2010-12-06: Initial patch for replication timeout (I extracted the timeout feature part from synchronous replication)
Review by rhaas on 2010-12-13: Does not apply.
Returned with Feedback Fujii Masao Thom Brown 2010-12-13
Synchronous Replication, transaction-controlled
Comment by simon on 2010-09-16: v4 added below main post
Patch by simon on 2010-10-08: New v5 first hack with changes suggested by Dimitri and Heikki
Review by rhaas on 2010-12-13: Does not apply.
Returned with Feedback Simon Riggs Nobody 2010-12-13
Add a primary key using an existing index
Patch by singh.gurjeet on 2010-11-22: Revised patch, per Steve's review.
Patch by ssinger on 2010-11-25: Fixes issue in regression test expected output
Review by itagaki on 2010-11-29: We need another syntax and checking for TABLESPACE.
Returned with Feedback Gurjeet Singh Steve Singer, Itagaki Takahiro 2010-12-14
IDLE IN TRANSACTION cancellation V3
Comment by gsmith on 2010-12-05: Concerns about levels/flags sizes
Review by kgrittn on 2010-12-05: Passes regression tests, useful for SSI, minor formatting complaint, still needs review for hot standby purposes.
Review by rhaas on 2010-12-14: Possible alternate approach?
Returned with Feedback Andres Freund Kevin Grittner, Robert Haas 2010-12-16
Per-column collation
Patch by gsmith on 2010-12-05: Updated patch addressing feedback
Review by itagaki on 2010-12-09: Issues in contrib/citext and ILIKE.
Patch by gsmith on 2010-12-16: Updated patch to fix issues found
Returned with Feedback Peter Eisentraut Itagaki Takahiro 2010-12-16
Tab completion in psql for triggers on views
Patch by dfetter on 2010-11-30: Fixed CREATE TRIGGER trg [TIMING] [tab]
Patch by itagaki on 2010-11-30: Fixed unexpected schema expansion
Patch by rhaas on 2010-12-13: Partially committed, rest is here.
Returned with Feedback David Fetter Itagaki Takahiro, Robert Haas 2010-12-16
Extensions
Patch by dim on 2010-12-12: Update v17, remove control.in mechanism and rework psql interface (\dx, \dx[+] PATTERN, \dX)
Patch by dim on 2010-12-16: Update v18, bitrot fixes after pg_execute_from_file went in
Patch by dim on 2010-12-16: Update v19, 2 one-liner fixes for 2 problems with script file encoding (that just got removed from the pg_execute_from_file() patch)
Returned with Feedback Dimitri Fontaine David Wheeler 2010-12-16

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Extensible executor nodes
Patch by itagaki on 2010-10-26: Initial version.
Comment by tgl on 2010-11-16: This is trying to do way too much. Let's just pull out the idea of a function pointer for ExecProcNode.
Comment by itagaki on 2010-11-17: There is no measurable improvement actually.
Rejected Itagaki Takahiro Tom Lane 2010-11-17
Issue with non-unicode aware downcase_truncate_identifier() function.
Patch by rdchirmade on 2010-10-13: Initial version.
Comment by rhaas on 2010-11-21: tgl says this approach isn't really standards complaint; and it seems likely also to be slow.
Rejected Rajanikant Chirmade Nobody 2010-11-21
for-in-array
Patch by okbobcz on 2010-09-30: This patch allows iteration over a array via "FOR" statement
Patch by okbobcz on 2010-10-04: this patch contains a implementation of "subscripts" function. It is important for iteration "for-in-array" of multidimensional arrays.
Review by jcasanov on 2010-11-22: Tom objects to this patch for beign syntactic sugar that will complicate the various FOR sub-syntaxes while it's better to accomplish the same performance benefit this patch provides to this specific case by internal optimizations
Rejected Pavel Stehule Jaime Casanova 2010-11-22
column-level update privs + lock table
Review by kaigai on 2010-11-25: It seems to me reasonable.
Review by rhaas on 2010-11-27: Not sure this is the right behavior.
Comment by rhaas on 2010-12-03: comments from tgl
Rejected Josh Kupershmidt KaiGai Kohei 2010-12-03
ALTER EXTENSION ... SET SCHEMA ...
Patch by dim on 2010-11-04: Update v2, implement AlterObjectNamespace_internal in alter.c
Patch by dim on 2010-11-05: Update v3, cleanup (#includes in particular)
Comment by dim on 2010-12-09: Now included in the main Extensions patch where we already need it to implement relocatable extensions.
Rejected Dimitri Fontaine Nobody 2010-12-09
serializable lock consistency
Patch by rhaas on 2010-10-21: Merged up to head of master branch, other minor cleanups.
Patch by fgp on 2010-12-15: Merged up to head of master branch, improved documentation and added additional asserts for safety.
Patch also available via https://github.com/fgp/postgres/tree/serializable_lock_consistency
Comment by heikki on 2010-12-20: Fatal bug found, marking as "rejected".
Rejected Florian G. Pflug Kevin Grittner 2010-12-20