Log In - Home Page

CommitFest 2010-07 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 34, Returned with Feedback: 18, Rejected: 1. Total: 53.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 for MSVC
Patch by itagaki on 2010-03-29: Initial version.
Comment by itagaki on 2010-05-27: committed in 9.0
Committed Itagaki Takahiro Nobody 2010-05-27
keepalive on libpq
Patch by MasaoFujii on 2010-02-15: Initial version.
Comment by rhaas on 2010-06-23: committed to 9.0
Committed Fujii Masao Robert Haas 2010-06-23
Ability to quickly cancel a change of tablespace
Patch by gleu on 2010-07-01: Initial version.
Review by rhaas on 2010-07-01: Looks good. Committed and back-patched (one part to 8.0, the other part to 8.4).
Committed Guillaume Lelarge Robert Haas 2010-07-01
ExecutorCheckPerms() hook
Patch by kaigai on 2010-05-26: Revised patch, according to Stephen's comment
Patch by kaigai on 2010-05-27: 'error_on_violation' was replaced by 'ereport_on_violation'
Patch by kaigai on 2010-06-14: Reorder to apply a series of patches
Committed Robert Haas Tom Lane 2010-07-09
Exclusion constraints support for operators where "x <operator> x" is false (tiny patch)
Patch by jdavis on 2010-05-21: Initial version.
Review by itagaki on 2010-07-12: No issues found.
Committed Jeff Davis Itagaki Takahiro 2010-07-15
dividing money by money
Review by kgrittn on 2010-06-21: Overall good. Could use minor changes so new code "blends" better.
Patch by kgrittn on 2010-06-21: Revised patch.
Review by kgrittn on 2010-06-23: Looks good. Ran pgindent (attached).
Committed Andy Balholm Kevin Grittner 2010-07-15
eliminate code duplication at DefineOpFamily()
Patch by kaigai on 2010-03-03: Initial version.
Review by kgrittn on 2010-06-17: The patch eliminates duplicate code as expected.
Committed KaiGai Kohei Brent Dombrowski 2010-07-15
log_file_mode GUC
Patch by itagaki on 2010-07-12: updated patch by author
Review by itagaki on 2010-07-12: almost ready to commit except 3 issues.
Patch by martin.pihlak on 2010-07-16: Updated patch, log_file_mode is now an integer GUC.
Committed Martin Pihlak Itagaki Takahiro 2010-07-16
server authentication over Unix-domain sockets
Patch by petere on 2010-06-01: Initial version.
Review by kaigai on 2010-06-21: getpwuid() is not thread-safe, although it seems to me working fine.
Committed Peter Eisentraut KaiGai Kohei 2010-07-18
psql \conninfo option
Review by ssinger on 2010-06-20: Generally okay but a things should be addressed before it is ready for a committer
Patch by davidchristensen on 2010-07-18: Version 2 of the patch incorporating all feedback.
Review by rhaas on 2010-07-19: Fixed NULL-handling issue; question about output format.
Committed David Christensen Steve Singer 2010-07-19
standard_conforming_strings on by default
Patch by rhaas on 2010-07-14: Initial version.
Committed Robert Haas Peter Eisentraut 2010-07-19
option to suppress automatic recovery after backend crash
Patch by rhaas on 2010-06-28: Initial version.
Patch by MasaoFujii on 2010-07-14: Updated version
Patch by MasaoFujii on 2010-07-15: Corrected version
Committed Robert Haas Fujii Masao 2010-07-19
Reworks of DML permission checks
Patch by kaigai on 2010-07-11: Patch revised not to move ExecCheckRTPerms().
Review by rhaas on 2010-07-19: A few minor issues.
Patch by kaigai on 2010-07-19: A revised patch
Committed KaiGai Kohei Robert Haas 2010-07-21
pg_dump(all) --quote-all-identifiers
Patch by rhaas on 2010-06-13: Initial version.
Comment by rhaas on 2010-06-13: References to server version 90000 will need to be changed to 90100 before commit.
Review by alexhunsaker on 2010-07-17: looks good, the docs might need a bit of work but im marking ready anyhow
Committed Robert Haas Alex Hunsaker 2010-07-21
CREATE TABLE IF NOT EXISTS
Patch by rhaas on 2010-05-01: Initial version.
Review by psoo on 2010-07-21: Initial review.
Committed Robert Haas Bernd Helmle 2010-07-25
Reduce lock levels for various DDL statements (ALTER TABLE, TRIGGERs)
Review by rhaas on 2010-07-18: A few fairly minor questions.
Comment by rhaas on 2010-07-19: Ready to commit, once agreed changes are made.
Review by rhaas on 2010-07-28: petere reports that AccessExclusiveLock is still taken
Committed Simon Riggs Robert Haas 2010-07-28
Distinguish between unique indexes and unique constraints
Patch by schmiddy on 2010-04-18: Initial version.
Comment by schmiddy on 2010-04-18: Please see "psql's \d display of unique index vs. constraint" on -general for the original thread.

Without this patch, one has to dig through pg_catalog in order to know whether to use ALTER TABLE or DROP INDEX to remove a unique constraint or index.
Review by kgrittn on 2010-07-29: Looks good. Attached new patch to fix minor format issue and suggest more readable arrangement.
Committed Josh Kupershmidt Kevin Grittner 2010-07-31
btree_gist support for searching on <> ("not equals")
Patch by jdavis on 2010-05-21: Initial version.
Review by itagaki on 2010-07-12: No issues found, but additional docs for btree_gist is preferred.
Patch by jdavis on 2010-07-15: Docs included.
Committed Jeff Davis Itagaki Takahiro 2010-08-02
Multibyte charater set in levenshtein function
Patch by kgrittn on 2010-07-29: Add attribution to levenshtein.c file.
Comment by rhaas on 2010-07-29: Partially committed; recommend splitting the remainder of these changes into two patches.
Patch by rhaas on 2010-08-01: Rewrote patch to improve multi-byte performance and reduce code duplication; please review.
Committed Alexander Korotkov Itagaki Takahiro, Robert Haas 2010-08-02
reducing NUMERIC size on-disk
Review by kgrittn on 2010-07-28: Tom answers questions.
Patch by rhaas on 2010-07-30: Updated patch.
Review by direvus on 2010-08-03: New version checks out fine.
Committed Robert Haas Brendan Jurd, Tom Lane 2010-08-03
phypot - Pygmy Hippotause
Review by ageery on 2010-07-16: A couple of little tweaky formatting issues + a performance and accuracy question
Comment by kgrittn on 2010-07-17: Kevin: Performance hit seems reasonable; on differences, which is more accurate?
Patch by kgrittn on 2010-07-23: Patch attempts to address all points raised by Andrew and Tom.
Committed Paul Matthews Andrew Geery 2010-08-03
Add XMLEXISTS Function
Patch by mlfowler on 2010-06-29: Added SGML documentation and tests for XML literals.
Review by kgrittn on 2010-07-21: Peter Eisentraut initial review.
Patch by mlfowler on 2010-07-24: Revised patch addressing issues raised in Peter's review.
Committed Mike Fowler Peter Eisentraut 2010-08-04
get_whatever_oid, part 1
Patch by rhaas on 2010-06-28: Updated patch.
Review by kaigai on 2010-07-02: Nothing to comment anymore, except for patch format.
Patch by rhaas on 2010-07-06: Rebased.
Committed Robert Haas KaiGai Kohei 2010-08-05
get_whatever_oid, part 2
Review by kaigai on 2010-07-05: Incorrect missing_ok handling in DropCast()
Patch by rhaas on 2010-07-06: Updated version.
Patch by rhaas on 2010-07-09: Updated patch, with more consistent naming, per review comments from KaiGai Kohei.
Committed Robert Haas KaiGai Kohei 2010-08-05
Functional dependencies and GROUP BY
Review by alexhunsaker on 2010-07-17: partial review, performance review pending
Comment by alexhunsaker on 2010-07-23: performance testing, looks good
Patch by alexhunsaker on 2010-07-23: new patch, only uses primary key as the not null pg_constraint patch got punted.
Committed Peter Eisentraut Alex Hunsaker 2010-08-06
Accessor functions to get so far collected statistics for the current transaction
Patch by glue on 2010-05-20: Patch again 9.0beta1, works for function statistics, but needs fix for table statistics.
Patch by glue on 2010-06-08: New version of the patch
Review by itagaki on 2010-07-12: Suggestion to use _xact_ instead of _transaction_.
Committed Joel Jacobson Itagaki Takahiro 2010-08-08
Adding xpath_exists function
Patch by mlfowler on 2010-06-29: Added SGML documentation and two more test cases using XML literals.
Review by dfetter on 2010-07-27: Looks good. Marking as "Ready for Committer."
Patch by mlfowler on 2010-08-07: Updated the patch so that it will apply to head and re-worked the function to use the new xpath internal function.
Committed Mike Fowler David Fetter 2010-08-08
make RAISE without arguments work like Oracle
Patch by rhaas on 2010-05-26: Initial version.
Review by dfetter on 2010-07-19: Reviewed patch, added basic docs, scrubbed off some bit rot.
Committed Piyush Newe David Fetter 2010-08-08
unlimited parameters for xslt_process
Comment by tgl on 2010-08-06: No, that test is wrong ...
Patch by okbobcz on 2010-08-07: regress test enhancing
Review by mlfowler on 2010-08-08: Patch works, however there are unresolved issues to address
Committed Pavel Stehule Mike Fowler 2010-08-10
string_to_array and array_to_string functions (not implode, explode)
Comment by tgl on 2010-08-08: v4 patch is MIA, I pinged Brendan to repost it
Patch by direvus on 2010-08-08: Reposted patch v4.
Patch by tgl on 2010-08-09: This is the correct message-ID for Brendan's repost of patch v4.
Committed Pavel Stehule Brendan Jurd 2010-08-10
pgbench show average latency per statement
Patch by fgp on 2010-08-04: Updated the documentation and added a few comments to the code.
Patch by fgp on 2010-08-05: Last path didn't include the for-loop formatting fix, this one does (v4).
Patch by gsmith on 2010-08-10: Updated patch with docs cleanup
Committed Florian G. Pflug Greg Smith 2010-08-12
Add xml_is_well_formed Function
Comment by rhaas on 2010-08-11: Another idea, and a note that we are out of time.
Patch by mlfowler on 2010-08-11: Revised patch based on document/content behaviour discussion
Review by okbobcz on 2010-08-12: all looking well
Committed Mike Fowler Pavel Stehule 2010-08-13
include Backend ID in relpath for temp rels
Review by tgl on 2010-08-12: Comments on v4
Patch by rhaas on 2010-08-12: v5
Review by tgl on 2010-08-13: Last couple of nitpicks.
Committed Robert Haas Jaime Casanova, Tom Lane 2010-08-13
Specify cursor row for psql \e
Comment by tgl on 2010-08-11: The \e / \ef part of this is committed.
Comment by rhaas on 2010-08-11: \sf portion of this patch can be resubmitted for next CF, after rework.
Patch by okbobcz on 2010-08-12: reimplementation of \sf command
Committed Pavel Stehule Jan Urbański 2010-08-14

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Access control reworks on ALTER TABLE
Patch by kaigai on 2010-03-17: Initial version.
Comment by kaigai on 2010-05-24: We agreed not to be consolidate checks between prep and exec stages.
Returned with Feedback KaiGai Kohei Nobody 2010-05-24
add a hook on ClientAuthentication()
Patch by kaigai on 2010-06-15: The hook was moved to ClientAuthentication() for more clarification of the purpose.
Comment by rhaas on 2010-07-08: I think we've decided not to pursue this, at least for now; and maybe not ever.
Comment by rhaas on 2010-07-08: comments from tgl
Returned with Feedback KaiGai Kohei Robert Haas 2010-07-08
Partitioning syntax
Review by kgrittn on 2010-06-23: doesn't apply to head anymore
Patch by kgrittn on 2010-06-23: updated patch
Review by rhaas on 2010-07-06: Needs quite a bit of work.
Returned with Feedback Itagaki Takahiro Jaime Casanova, Robert Haas 2010-07-12
ispell dictionary preloading
Patch by okbobcz on 2010-04-01: actualised version - modificated AllocSet allocator
Review by itagaki on 2010-07-07: Basically OK, but required test cases and plan for Windows port.
Comment by rhaas on 2010-07-08: tgl advocates precompiler approach.
Returned with Feedback Pavel Stehule Itagaki Takahiro 2010-07-20
Fix leaky VIEWs for RLS
Review by rhaas on 2010-07-08: use explicit pg_proc flag?
Comment by rhaas on 2010-07-19: Does anyone else have an opinion on this?
Comment by rhaas on 2010-07-21: Marking Returned with Feedback, per discussion.
Returned with Feedback KaiGai Kohei Robert Haas 2010-07-21
Snapshot materialized views
Comment by kgrittn on 2010-07-12: Discussion on refreshing the view.
Comment by kgrittn on 2010-07-12: Discussion on initial implementation work.
Comment by kgrittn on 2010-07-12: Robert Haas comments on patch.
Returned with Feedback Pavel Baros Nobody 2010-07-23
Synchronous replication via SR
Patch by zboszor on 2010-04-29: Initial version.
Comment by Harald Kolb on 2010-07-15: After setting up a cluster with strict sync. replication and using pgbench to verify transaction performance, it's obvious that the current performance (about 10 TPS) is not sufficient. Can you explain the performance limitation and what is necessary to improve the situation ? Is there a plan to continue with this solution ?

Thanks, Harald.
Review by yhavinga on 2010-07-26: Besides that the patch was a bit outdated, the bulk of the patch was handling the acknowledged XIDs on the master, which was more complex and intrusive than the way the other syncrep patch waited for standby's. The guc parameters however were more clear to me than the other patch.
Returned with Feedback Zoltán Böszörményi Yeb Havinga 2010-07-26
Another synchronous replication
Patch by MasaoFujii on 2010-07-14: Initial version.
Patch by MasaoFujii on 2010-07-21: Updated version
Review by yhavinga on 2010-07-26: Besides the already mentioned TODOs for this patch (remove poll loops), some comments, unification with the other syncrep patch would be nice.
Returned with Feedback Fujii Masao Yeb Havinga 2010-07-26
initdb add to postgresql.conf
Patch by bmomjian on 2010-03-31: Initial version.
Comment by kaigai on 2010-07-15: Here was previous suggestions.
Comment by rhaas on 2010-07-26: Remarks from kgrittn; patch appears to have minimal benefit.
Returned with Feedback David Christensen KaiGai Kohei 2010-07-26
support multiple -f options
Patch by rhaas on 2010-03-08: Initial version.
Review by kgrittn on 2010-06-17: Some problems, including a segfault.
Patch by markwkm on 2010-07-20: proposed change to original patch
Returned with Feedback David Christensen Mark Wong & Gabrielle Roth 2010-07-28
dynamically allocating chunks from shared memory
Patch by markus on 2010-07-16: Initial version.
Returned with Feedback Markus Wanner Nobody 2010-07-28
internal messaging
Patch by markus on 2010-07-16: Initial version.
Returned with Feedback Markus Wanner Nobody 2010-07-28
lock_timeout GUC
Comment by marco44 on 2010-08-02: lock_timeout is triggered at deadlock_timeout if lock_timeout > deadlock_timeout

Asked -hackers for advice
Comment by kgrittn on 2010-08-02: Both author and reviewer think Zoltán's WiP patch for a timeout framework would be a better approach. Marking Returned with Feedback.
Comment by gbatumbya on 2011-06-29: Just wondering, what is the status on implementing lock_timeout, the reason i ask is that I couldn't seem to find any thing about the timeout framework
Returned with Feedback Zoltán Böszörményi Marc Cousin 2010-08-02
COPY optimization in pg_restore
Review by marco44 on 2010-07-06: No problem found during review. Neat win in a very simple non-indexed table test.
Comment by rhaas on 2010-07-14: Need to address Tom's concerns.
Comment by rhaas on 2010-07-25: changed status to 'Waiting on Author', pending resolution of Tom's concerns
Returned with Feedback Itagaki Takahiro Marc Cousin 2010-08-03
SQL/MED foreign table
Patch by kgrittn on 2010-07-20: Revised patch by Itagaki.
Comment by okbobcz on 2010-07-21: is some reason why non super user cannot to use a foreign tables based on files?
Comment by okbobcz on 2010-07-30: current patch has a security issue
Returned with Feedback Itagaki Takahiro Pavel Stehule 2010-08-03
Performance improvements for Array utility functions with large arrays
Patch by mikelewis on 2010-06-16: Fixed naming issue.
Comment by tgl on 2010-07-16: Concerned about added costs for cases it doesn't optimize.
Comment by rhaas on 2010-07-27: Setting to "Waiting on Author".
Returned with Feedback Mike Lewis Daniel Farina (fdr) 2010-08-05
Security Label support
Review by rhaas on 2010-07-22: Some concerns about the design.
Patch by kaigai on 2010-07-26: Revised patch (part.1 and 2)
Comment by rhaas on 2010-08-09: Would like to apply this after the comment.c refactoring patch, and other comments. Looks generally good.
Returned with Feedback KaiGai Kohei Robert Haas 2010-08-09
WiP: Per-column collation
Patch by petere on 2010-07-14: Initial version.
Review by jcasanov on 2010-08-02: Main question i have is if lc_collate (in CREATE DATABASE) should use pg_collation
Comment by kgrittn on 2010-08-03: Peter responds to questions.
Returned with Feedback Peter Eisentraut Jaime Casanova 2010-08-14

Rejected Patches

Patch Name Status Author Reviewers Date Closed
WAL streaming from WAL buffers
Patch by MasaoFujii on 2010-06-11: Initial version.
Review by rhaas on 2010-07-06: Can't do this; not safe.
Rejected Fujii Masao Nobody 2010-07-07