Log In - Home Page

CommitFest 2010-01 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 49, Returned with Feedback: 11. Total: 60.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
hstore documentation update
Patch by theory on 2009-11-21: Initial version.
Committed David E. Wheeler Nobody 2009-11-30
Fix auto-prepare
Patch by zboszor on 2009-12-15: Initial version.
Patch by zboszor on 2009-12-15: Another approach requested by Michael Meskes
Committed Zoltan Boszormenyi Michael Meskes 2009-12-16
int2vectorin() improved error handling
Patch by cwelton on 2009-12-02: Initial version.
Review by rhaas on 2009-12-28: looks good to me. intend to commit.
Committed Caleb Welton Robert Haas 2009-12-29
Remove all declarations from pg_attribute.h, consolidate BKI scripts
Patch by jnaylor on 2010-01-03: Version 2
Patch by jnaylor on 2010-01-04: Copyright date synced with master.
Committed John Naylor Tom Lane 2010-01-04
pg_read_file() and non-ascii input file
Patch by itagaki on 2009-12-02: Needs more discussion about backward compatibility.
Review by rhaas on 2009-12-30: +1 for alternative approach that is backward-compatible
Patch by itagaki on 2010-01-03: Don't change the result type.
Committed Itagaki Takahiro Robert Haas 2010-01-05
SQLDA support for ECPG
Patch by zboszor on 2009-12-15: New version, small fixes.
Patch by zboszor on 2009-12-16: Rebased to current CVS after the auto-prepare fix was applied.
Patch by zboszor on 2010-01-05: DB2/Sybase compatible SQLDA was added for native mode
Informix-specific FETCH ... USING DESCRIPTOR sqlda is accepted for native mode
Committed Zoltan Boszormenyi Michael Meskes 2010-01-05
New VACUUM FULL
Patch by itagaki on 2009-12-15: rebased to current CVS
Comment by gsmith on 2009-12-15: Simon will work on getting this committed
Comment by rhaas on 2009-12-29: This is needed for HS, but needs changes. sriggs inquires whether itagaki will update.
Committed Itagaki Takahiro Jeff Davis 2010-01-06
Verifying variable names in pgbench
Review by rhaas on 2009-12-30: a few suggestions regarding the implementation
Patch by itagaki on 2010-01-03: Simplified version.
Patch by rhaas on 2010-01-04: latest version from itagaki (which looks good to me)
Committed Itagaki Takahiro Robert Haas 2010-01-06
Buffer statistics for pg_stat_statements
Patch by itagaki on 2009-12-22: Initial version.
Review by rhaas on 2009-12-29: Other than minor whitespace nits, I think this is ready to commit.
Patch by rhaas on 2010-01-07: latest version from itagaki looks good
Committed Itagaki Takahiro Robert Haas 2010-01-08
Initial refactoring of plperl.c
Patch by timbunce on 2009-12-21: Initial version.
Patch by timbunce on 2009-12-21: Initial refactoring of plperl.c - rebased (also checked against alpha3)
Patch by timbunce on 2010-01-08: Updated to apply to current cvs head. Removed problematic utf8fix test. Optimized pg_verifymbstr calls.
Committed Tim Bunce Andrew Dunstan 2010-01-08
point_ops
Patch by teodor on 2009-11-23: Initial version.
Patch by rhaas on 2009-12-30: updated patch from teodor
Review by rhaas on 2009-12-31: looks good. one question, plus some minor suggestions for improvement.
Committed Teodor Sigaev, Oleg Bartunov Robert Haas 2010-01-14
Windows x64
Patch by tsutomu@sraoss on 2009-12-02: Initial version. [repost]
Comment by mha on 2010-01-02: I'm applying this piece by piece with some fairly heavy editorializing. Will soon have it all done.
Comment by mha on 2010-01-10: I've applied all parts now, and I'm just working on finishing off the documentation. I won't "close" this issue here until docs are in.
Committed Tsutomu Yamada Magnus Hagander 2010-01-14
Streaming Replication
Review by gsmith on 2009-12-15: Concerns about linking with the backend here and downthread
Comment by rhaas on 2010-01-07: Do we need to slip this to 8.6?
Comment by heikki on 2010-01-15: Committed, but there's still some loose ends
Committed Fujii Masao Heikki Linnakangas 2010-01-15
DESCRIBE [OUTPUT] support for ECPG
Patch by zboszor on 2009-12-14: New patch rebased to latest SQLDA patch
Patch by zboszor on 2009-12-15: New version, small fixes.
Patch by zboszor on 2010-01-05: Adjust for DB2/Sybase compatible SQLDA
Informix-specific DESCRIBE ... INTO sqlda syntax is accepted for native mode
Committed Zoltan Boszormenyi Michael Meskes 2010-01-15
plpgsql: add USING clause to OPEN FOR EXECUTE statement
Patch by okbobcz on 2009-11-17: Initial version.
Patch by okbobcz on 2010-01-13: revised version
Committed Pavel Stehule Itagaki Takahiro 2010-01-18
Calculate table and indexes size more user friendly
Patch by psoo on 2010-01-14: Initial version.
Review by gsmith on 2010-01-18: Patch works as expected, test program attached
Committed Bernd Helmle Greg Smith 2010-01-18
Add utility functions to plperl
Patch by timbunce on 2010-01-13: Initial version.
Comment by timbunce on 2010-01-14: The description says "Stored procedure subs are now given names" but that's included in a later patch, not this one.
Comment by timbunce on 2010-01-14: Specifically "Miscellaneous changes to plperl"
https://commitfest.postgresql.org/action/patch_view?id=268
Committed Tim Bunce Andrew Dunstan 2010-01-19
Clearing global statistics
Patch by gsmith on 2010-01-14: Initial version.
Review by gsmith on 2010-01-17: Suggestion for error handling
Committed Greg Smith Magnus Hagander 2010-01-19
per-user .pg_service.conf
Patch by petere on 2010-01-15: Initial version.
Review by Myon on 2010-01-15: +1 from me.
Committed Peter Eisentraut Christoph Berg 2010-01-20
New XLOG record indicating WAL-skipping
Patch by MasaoFujii on 2009-12-09: Initial version.
Patch by MasaoFujii on 2010-01-05: Updated version.
Patch by MasaoFujii on 2010-01-17: Heikki updated the patch.
Committed Fujii Masao Heikki Linnakangas 2010-01-21
psql to print triggers pretty
Comment by BradSliger on 2010-01-18: I tried to apply this patch to the latest version of PostgreSQL in git (bbfc96e). Some of the patch did not apply.
Patch by itagaki on 2010-01-18: Rebased.
Review by BradSliger on 2010-01-18: As far as I can tell, everything looks reasonable.
Committed Itagaki Takahiro PDXPUG 2010-01-21
plpythonu DO support (inline call handler)
Patch by ormod on 2009-12-02: Initial version.
Comment by ormod on 2009-12-02: Initial version.
Committed Hannu Valtonen Peter Eisentraut 2010-01-22
attoptions
Patch by rhaas on 2010-01-10: Initial version.
Review by alexhunsaker on 2010-01-15: few questions, probably needs one more patch
Patch by rhaas on 2010-01-20: Updated version.
Committed Robert Haas Alex Hunsaker 2010-01-22
Fix auto-prepare vs multiple connections
Patch by zboszor on 2010-01-18: Initial version.
Patch by itagaki on 2010-01-18: Added fixes for memory leak and a regression test.
Patch by zboszor on 2010-01-19: Third version to save some cycles for auto-prepare by factoring out most of the code out of ECPGprepare() into a common function. Test case made by Takahiro Itagaki is added.
Committed Zoltán Böszörményi Itagaki Takahiro 2010-01-22
Fix for memory leak in dblink
Patch by itagaki on 2010-01-11: Initial version.
Review by jconway on 2010-01-21: Looks good to me. Will commit in day or two if no objections...
Comment by jconway on 2010-01-24: Commited
Committed Itagaki Takahiro Joe Conway 2010-01-25
Add get_bit set_bit overlay for bit string
Review by kgrittn on 2010-01-18: Needs doc fix, other issues raised which might merit action.
Patch by leonardof on 2010-01-20: Added overlay for bin strings, more tests, minor fixes
Review by kgrittn on 2010-01-20: Concerns addressed. Ready for committer (with small adjustment to docs).
Committed Leonardo F Kevin Grittner 2010-01-25
Miscellaneous changes to plperl
Patch by timbunce on 2010-01-14: Initial version.
Review by alexhunsaker on 2010-01-22: looks good waiting for feedback before marking it as ready
Committed Tim Bunce Alex Hunsaker 2010-01-26
Out of scope cursor handling for ECPG
Patch by zboszor on 2009-12-15: Second variant, feature introduced for native mode
Patch by zboszor on 2010-01-05: Rebased to the new SQLDA/DESCRIBE patches
Patch by zboszor on 2010-01-19: Modified regression tests as per Michael's request.
Committed Zoltan Boszormenyi Michael Meskes 2010-01-26
Documentation for ECPG changes
Patch by zboszor on 2009-10-08: Initial version.
Patch by zboszor on 2010-01-15: New patch
Committed Zoltan Boszormenyi Michael Meskes 2010-01-26
RADIUS authentication
Patch by mha on 2010-01-10: Initial version.
Review by kaigai on 2010-01-18: Initial review
Patch by mha on 2010-01-24: Updated patch
Committed Magnus Hagander KaiGai Kohei 2010-01-27
libpq new connect function (PQconnectParams)
Patch by gleu on 2010-01-15: New patches because the old ones didn't apply anymore, due to recent CVS
commits.
Patch by jconway on 2010-01-25: Questions about how to handle the parsing details
Patch by gleu on 2010-01-27: Add documentation
Committed Guillaume Lelarge Joe Conway 2010-01-27
Typed tables
Patch by petere on 2010-01-14: Initial version.
Comment by umitanuki on 2010-01-18: Almost everything is OK. A crash case should be fixed.
Review by umitanuki on 2010-01-27: Issues fixed, so review done.
Committed Peter Eisentraut Hitoshi Harada 2010-01-28
quoting psql variables
Comment by rhaas on 2010-01-21: Discussion of proper error handling.
Patch by rhaas on 2010-01-27: Pavel's latest version
Patch by rhaas on 2010-01-27: My proposed version.
Committed Pavel Stehule Robert Haas 2010-01-29
Add on_perl_init and proper destruction to plperl
Comment by timbunce on 2010-01-19: The changes related to running END blocks fix bug #5066
Patch by timbunce on 2010-01-28: Updated patch.
Patch by timbunce on 2010-01-29: Updated to avoid Perl_sv_clean_objs.
Committed Tim Bunce Andrew Dunstan 2010-01-29
Fix out-ouf-scope cursor handling
Patch by zboszor on 2010-01-28: Initial version to fix order of ECPGset_var() calls.
Don't test NaNs here, it has to be fixed separately.
Committed Zoltán Böszörményi Nobody 2010-01-29
listagg aggregate
Review by theory on 2010-01-22: Initial review.
Patch by rhaas on 2010-01-27: Pavel's latest version
Review by itagaki on 2010-01-27: Review and adjusted patch.
Committed Pavel Stehule David Wheeler 2010-02-01
Prevent renaming on multiple inherited column
Review by rhaas on 2010-01-27: Logic is wrong - here's a case where it breaks.
Patch by kaigai on 2010-01-31: Revised patch. Logic and performance issues are solved, and ALTER COLUMN TYPE issue was separated to.
Patch by rhaas on 2010-02-01: the version I intend to commit
Committed KaiGai Kohei Bernd Helmle 2010-02-01
Remove obscure permission checks in FindConversion()
Patch by kaigai on 2009-12-16: Initial version.
Committed KaiGai Kohei Robert Haas 2010-02-02
Fix NaN/Infinity in ECPG
Patch by zboszor on 2010-01-28: Initial version.
Patch by zboszor on 2010-01-30: More fixes to send the proper strings to the server if the input variable is float or double.
Committed Zoltán Böszörményi Michael Meskes 2010-02-02
Make PostgreSQL binaries use the new PQconnectdbParams() libpq functions
Patch by gleu on 2010-01-31: Initial version.
Comment by rhaas on 2010-02-02: Joe Conway intends to take a look at this.
Committed Guillaume Lelarge Joe Conway 2010-02-04
rbtree
Comment by markca on 2010-02-01: Further comments from Robert.
Comment by markca on 2010-02-01: Further comments from Tom.
Comment by rhaas on 2010-02-06: Seems to be getting close.
Committed Teodor Sigaev, Oleg Bartunov Robert Haas, Mark Cave-Ayland 2010-02-11
Remove gcc dependency in definition of "inline" functions
Comment by harriman on 2010-02-10: author accepts advice, denies imperviousness
Patch by harriman on 2010-02-10: 4th edition
Review by rhaas on 2010-02-11: looks generally sane
Committed Kurt Harriman Peter Eisentraut 2010-02-12
More frame options in window functions
Comment by tgl on 2010-01-18: Moved state back to Waiting on Author, since that's what we seem to be doing.
Patch by umitanuki on 2010-01-19: Fix redundant sort key problem.
Review by okbobcz on 2010-01-20: the problem on 64bit are fixed
Committed Hitoshi Harada Pavel Stehule 2010-02-12
Add on_trusted_init and on_untrusted_init to plperl
Patch by timbunce on 2010-02-08: Update patch with revised docs per comments from Andrew Dunstan.
Comment by rhaas on 2010-02-11: commit ping
Comment by rhaas on 2010-02-12: adunstan is working on getting this committed.
Committed Tim Bunce Alex Hunsaker 2010-02-12
Faster CREATE DATABASE by delaying fsync
Comment by rhaas on 2010-02-06: Can we agree on a way forward here?
Comment by rhaas on 2010-02-12: commit ping
Comment by rhaas on 2010-02-14: partially committed
Committed Andres Freund Greg Stark, Greg Smith 2010-02-14
Provide rowcount for utility SELECTs
Patch by zboszor on 2010-02-12: New docs.
Patch by rhaas on 2010-02-13: updated patch from bmomjian
Comment by bmomjian on 2010-02-16: Patch applied by Bruce.
Committed Boszormenyi Zoltan Greg Smith, Jaime Casanova, Robert Haas 2010-02-16
Package namespace and Safe init cleanup for plperl
Comment by alexhunsaker on 2010-01-30: I marked it as ready, but it might need a rebase to apply cleanly
Patch by timbunce on 2010-01-30: Revised patch. Rebased plus some small additions.
Patch by timbunce on 2010-02-02: Just adds a missing "# $PostgreSQL$"
Committed Tim Bunce Alex Hunsaker 2010-02-16
Listen / Notify rewrite
Patch by jwieland on 2010-02-10: Updated patch
Review by jwieland on 2010-02-14: Review by Simon Riggs
Patch by jwieland on 2010-02-14: New patch addressing Simon's feedback
Committed Joachim Wieland Jeff Davis 2010-02-16
Fix large object support in pg_dump
Patch by kaigai on 2010-01-27: A revised patch based on the comment.
Patch by kaigai on 2010-02-09: Fix option handling (--data-only and --schema-only).
Patch by itagaki on 2010-02-09: Fix option handling (--clean)
Committed KaiGai Kohei Itagaki Takahiro 2010-02-17

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
ambiguous schema resolution for fk errors
Patch by werkt on 2009-11-15: Initial version.
Review by gsmith on 2009-11-15: Clarification of TODO item and patch direction
Returned with Feedback George Gensure Bernd Helmle 2009-11-15
using parametrised query in psql
Patch by okbobcz on 2009-11-17: Initial version.
Review by rhaas on 2009-12-20: Purpose of this change is not clear. Needs to be discussed and documented.
Comment by rhaas on 2009-12-28: :'foo' and :"foo" syntax is agreed, in place of the change proposed here.
Returned with Feedback Pavel Stehule Robert Haas 2009-12-28
COPY to a UDF: "COPY ... TO FUNCTION ..."
Patch by gsmith on 2009-11-23: Initial version.
Comment by rhaas on 2009-12-29: Not sure where we are with this. Seems to need updating.
Comment by rhaas on 2009-12-29: author thinks we've decided to go in a different direction
Returned with Feedback Daniel Farina Robert Haas 2009-12-29
Add hstore_to_json()
Patch by theory on 2009-12-16: Initial version.
Comment by rhaas on 2009-12-29: I think we should add a json type first.
Comment by rhaas on 2010-01-05: author agrees with marking this returned with feedback
Returned with Feedback David E. Wheeler Nobody 2010-01-05
PL/Perl Feature Patch 1
Patch by timbunce on 2010-01-08: Initial version (with fixed commitfest msgid)
Comment by rhaas on 2010-01-12: adunstan suggests splittin this into 3 patches
Returned with Feedback Tim Bunce Nobody 2010-01-12
lock_timeout GUC
Comment by tgl on 2010-01-19: Serious portability problems yet :-(
Patch by zboszor on 2010-01-20: New patch trying to solve portability and supposed stability problems.
Comment by rhaas on 2010-01-21: Bump to next release.
Returned with Feedback Zoltán Böszörményi Jaime Casanova 2010-01-21
remove redundant owner check in EnableDisableRule
Patch by kaigai on 2009-12-17: Revised patch
Review by rhaas on 2010-01-10: I think this is OK, except I'd like to add a comment.
Comment by rhaas on 2010-01-23: plan is to fold this into a larger patch, for 9.1
Returned with Feedback KaiGai Kohei Robert Haas 2010-01-23
plpython3
Patch by jwpye on 2009-11-19: Initial version.
Comment by rhaas on 2010-02-01: Not enough interest in this to proceed for 9.0.
Returned with Feedback James William Pye Nathan Boley 2010-02-06
xpath non-nodeset result enabling
Comment by petere on 2010-01-11: I think this should be some separate functions.
Review by wulczer on 2010-01-17: looks good, needs unit tests and small changes
Patch by aribi on 2010-02-12: Version 2
Returned with Feedback Arie Bikker Jan Urbański 2010-02-06
knngist (WIP)
Comment by rhaas on 2009-12-30: patch needs updating, maybe should be targeted for 8.6
Patch by teodor on 2010-01-15: Updated and split patch. Patch set requires rbtree patch applied (point_ops was committed already)
Comment by rhaas on 2010-02-10: not enough time for 9.0
Returned with Feedback Teodor Sigaev, Oleg Bartunov Mark Cave-Ayland 2010-02-10
Writeable CTEs
Patch by johto on 2010-02-10: Patch v10
Comment by rhaas on 2010-02-10: author is throwing in the towel
Comment by rhaas on 2010-05-07: Until there is a new version of this patch, it should not be added to the open CF, as there is nothing to review.
Returned with Feedback Marko Tiikkaja Merlin Moncure 2010-05-20

Rejected Patches

No patches.