Log In - Home Page

CommitFest 2013-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 49, Returned with Feedback: 42, Rejected: 6. Total: 97.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
Add Makefile dep in bin/scripts for libpgport
Patch by phils on 2013-01-23: Initial version.
Committed Phil Sorber Nobody 2013-02-08
printing boolean domains in sql/xml function
Patch by okbobcz on 2013-02-22: bug fix (maybe for 9.3, if not to 9.4) - fix printing domain' values in SQL/XML function
Committed Pavel Stehule Nobody 2013-03-04
backup_label is critical, not merely informative.
Patch by jjanes on 2013-04-06: Initial version.
Comment by gsmith on 2013-04-26: Is it possible to flag when it's expected but missing in a way that doesn't generate too many false warnings?
Committed Jeff Janes Greg Smith 2013-05-07
Fix escaped connstring handling in libpq and do double escaping in pg_basebackup
Patch by zboszor on 2013-02-19: Initial version.
Comment by zboszor on 2013-02-28: Hari Babu tested these two patches.
Committed Zoltán Böszörményi Heikki Linnakangas 2013-05-20
Server side lo-funcs name
Patch by aglio on 2013-06-17: Initial version.
Committed Tatsuo Ishii Robert Haas 2013-06-12
pgbench: introduce a new automatic variable 'client_number'
Patch by aglio on 2013-06-17: Initial version.
Committed Gurjeet Singh Heikki Linnakangas 2013-06-14
Pass buffer_std to MarkBufferDirtyHint()
Patch by jdavis on 2013-06-14: FSM callers pass buffer_std=false.
Review by jdavis on 2013-06-14: Andres: Comment improvements, and suggested rename XLOG_HINT -> XLOG_FPI.
Patch by jdavis on 2013-06-15: Clarify comments and rename XLOG_HINT to XLOG_FPI.
Committed Jeff Davis Andres Freund 2013-06-17
Removal of pageinspect--1.0.sql
Patch by aglio on 2013-06-17: Initial version.
Comment by michael-kun on 2013-06-18: This has been already committed by Heikki as 230e92c.
Committed Michael Paquier Nobody 2013-06-17
Make static the on-line doc ids referenced by phpPgAdmin project
Patch by kop on 2013-05-07: Initial version.
Comment by petere on 2013-06-18: already done in 9.3
Committed Karl O. Pinc Nobody 2013-06-18
SET work_mem = '1TB'
Patch by aglio on 2013-06-17: Initial version.
Review by jjanes on 2013-06-18: submitted new patch with my suggestions. Marked ready for committer
Patch by masaofujii on 2013-06-18: Updated version; Changed postgresql.conf.sample
Committed Simon Riggs Jeff Janes 2013-06-20
standalone versus single-user backends
Patch by jjanes on 2013-06-13: Initial version.
Committed Jeff Janes Nobody 2013-06-21
Clean switchover
Review by masaofujii on 2013-06-13: Updated patch
Review by andresfreund on 2013-06-24: looks fine, minor, minor stylistic points
Patch by andresfreund on 2013-06-24: v2, addressing some stylistic issues
Committed Fujii Masao Andres Freund 2013-06-26
Fix postmaster messages encoding
Patch by law on 2013-03-13: Initial version.
Patch by nmisch on 2013-06-23: Reviewed the submission; heavy revisions attached.
Comment by law on 2013-06-25: Modified patch is much better that the initial version, so I think it should be commited.
Committed Alexander Lakhin Noah Misch 2013-06-26
MemoryContextAllocHuge(): selectively bypassing MaxAllocSize
Patch by nmisch on 2013-05-14: Initial version.
Comment by nmisch on 2013-06-01: Could particularly benefit from verification that I didn't miss newly-relevant overflow cases in tuplesort.c.
Committed Noah Misch Stephen Frost, Simon Riggs, Jeff Janes 2013-06-27
add long options to pgbench
Patch by calvin on 2013-06-20: v3, diff wrt current master
Review by rhaas on 2013-06-25: missed pgbench --help, suggestions for better long option names
Patch by calvin on 2013-06-25: v4, with --help update & other suggestions by Robert Haas.
Committed Fabien Coelho Fabrízio de Royes Mello 2013-06-27
[bug fix] backend hangs at immediate shutdown
Comment by maiku41 on 2013-06-21: Changed to Waiting on Author based on review feedback.
Patch by alvherre on 2013-06-24: new version, needs tweak from submitter
Patch by maiku41 on 2013-06-28: Patch by maumau
Committed MauMau Álvaro Herrera 2013-06-28
Spin Lock sleep resolution
Patch by jjanes on 2013-04-02: Initial version.
Patch by jjanes on 2013-04-02: patch actually attached this time
Comment by maiku41 on 2013-06-21: Moved to Waiting on Author based on reviewer comments.
Committed Jeff Janes Heikki Linnakangas 2013-06-28
ALTER TABLE ... ALTER CONSTRAINT
Patch by simon on 2013-06-16: Initial version.
Review by ams on 2013-06-24: Looks fine
Committed Simon Riggs Abhijit Menon-Sen 2013-06-29
Fix error code of lock_timeout
Patch by zboszor on 2013-06-28: Initial version.
Committed Zoltán Böszörményi Simon Riggs 2013-06-29
makeFuncArgs
Patch by dfetter on 2013-06-28: Updated to current master, remove gratuitous whitespace changes.
Patch by dfetter on 2013-07-01: Updated to current master reflecting de-reserving OVER as a keyword
Review by jeevan.chalke on 2013-07-01: Looks good to go in. Thanks David.
Committed David Fetter Jeevan Chalke 2013-07-01
Pglz compression optimizations
Patch by heikki on 2013-04-30: Initial version.
Comment by amitkapila on 2013-06-20: some of the performance test for large data shows negative results.
Comment by maiku41 on 2013-06-28: Patch still under discussion as of 6/26.
Committed Heikki Linnakangas Amit Kapila 2013-07-01
set VPATH for out-of-tree extension builds
Comment by myon on 2013-05-30: I'd propose a simplification here:

srcdir = $(dir $(firstword $(MAKEFILE_LIST)))
VPATH = $(srcdir)

No need to do the $(dir...) stuff twice, I'd say.
Patch by c2main on 2013-06-18: Updated accordingly
Comment by maiku41 on 2013-06-29: Still being discussed as of 6/24
Committed Cédric Villemain Andrew Dunstan 2013-07-01
Fix build of extension regression data with VPATH
Patch by c2main on 2013-05-29: Initial version.
Comment by c2main on 2013-06-18: Group all patches in a new thread.
Comment by maiku41 on 2013-06-28: Under discussion as of 6/26
Committed Cédric Villemain Andrew Dunstan 2013-07-01
fix SHLIB_PREREQS when building with USE_PGXS
Patch by c2main on 2013-05-29: Initial version.
Comment by c2main on 2013-06-18: Group all patches in a new thread.
Committed Cédric Villemain Andrew Dunstan 2013-07-01
adds support for VPATH with USE_PGXS
Patch by c2main on 2013-05-30: Initial version.
Comment by c2main on 2013-06-18: Group all patches in a new thread.
Committed Cédric Villemain Andrew Dunstan 2013-07-01
extensible external toast tuple support
Patch by andresfreund on 2013-06-27: Patch addressing bug found during review and improving some comment improvments
Patch by andresfreund on 2013-07-02: v03
Review by andresfreund on 2013-07-02: Review by Robert with the advice to decouple on bit of the code.
Committed Andres Freund Hitoshi Harada, Robert Haas 2013-07-02
MVCC catalog access
Patch by rhaas on 2013-06-28: v4
Patch by andresfreund on 2013-07-02: v5
Review by andresfreund on 2013-07-02: Looks good, might need more changes after commit but that seems fine
Committed Robert Haas Andres Freund 2013-07-02
Mention extra_float_digits in floating point numbers chapter
Patch by laurenz on 2013-03-06: More elaborate version.
Review by ams on 2013-06-24: Some concerns, rewording proposed.
Patch by laurenz on 2013-06-24: New version.
Committed Laurenz Albe Abhijit Menon-Sen 2013-07-02
access to new error fields from PLpgSQL
Patch by okbobcz on 2013-06-25: fixed formatting
Review by nmisch on 2013-06-27: Let's rename DATATYPE_NAME, update the protocol docs to allow free-form use of these error fields, and back-patch this to 9.3
Patch by nmisch on 2013-07-02: Revised based on review
Committed Pavel Stehule Rushabh Lathia 2013-07-03
Add more regression tests for CREATE OPERATOR
Review by rhaas on 2013-06-27: needs to adhere to regression user conventions
Patch by robins on 2013-06-30: Updated patch as per robert's comments. prepend regress to role names.
Patch by robins on 2013-07-01: Added two more tests (pending from the discussion thread). Nothing more to add here.
Committed Robins Tharakan Szymon Guz 2013-07-03
Add more regression tests for ASYNC
Patch by robins on 2013-05-23: Initial version.
Review by szymon on 2013-06-20: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Committed Robins Tharakan Szymon Guz 2013-07-03
Use posix_fallocate to build (new) WAL files
Patch by jdavis on 2013-06-18: New patch. Still has GUC in for testing purposes, which needs to be removed when Greg is finished with the performance evaluation.
Comment by aglio on 2013-06-28: Queried reviewers about testing progress.
Comment by jdavis on 2013-06-30: Responded to Greg Smith's request.
Committed Jon Nelson Andres Freund, Greg Smith, Jeff Davis 2013-07-05
Display number of changed rows since last analyze
Patch by markir on 2013-05-23: Initial version.
Review by laurenz on 2013-06-17: Patch is fine, documentation could be improved.
Committed Mark Kirkwood Laurenz Albe 2013-07-05
Fix conversion of Decimal arguments for plpython
Patch by ssinger on 2013-06-27: plpython_decimal_v6.patch - changes the numeric unit test so it outputs the same text in both cases (with and without) cdecimal installed
Patch by szymon on 2013-06-27: plpython_decimal_v7.patch - changes tests to check the class name
Patch by ssinger on 2013-06-28: plpython_decimal_v8.patch - changes tests to also include the value
Committed Szymon Guz, Ronan Dunklau Steve Singer 2013-07-06
XLogInsert scaling
Patch by heikki on 2013-06-19: Latest patch version.
Review by andresfreund on 2013-06-24: First read through the patch, some correctness, comment and algorithmic questions raised.
Comment by maiku41 on 2013-07-05: Under discussion as of 7/1
Committed Heikki Linnakangas Andres Freund, Abhijit Menon-Sen 2013-07-08
Add session_preload_libraries configuration parameter
Review by robins on 2013-06-29: Basic review of the patch
Comment by maiku41 on 2013-07-05: Needs additional reviewer to complete review.
Comment by dim on 2013-07-08: Ready for commit, let's have both local_preload_librairies and session_preload_librairies for awhile.
Committed Peter Eisentraut Dimitri Fontaine, Robins Tharakan 2013-07-13
Add regression tests for LOCK TABLE
Review by szymon on 2013-06-24: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Patch by robins on 2013-07-07: Updated as per Robert's feedback (prepend regress_xxx to ROLEs). Added to serial_schedule (missed out earlier).
Review by rhaas on 2013-07-15: Committed with significant changes
Committed Robins Tharakan Szymon Guz 2013-07-15
refresh materialized view concurrently
Review by umitanuki on 2013-07-09: One of the previous issues are not resolved yet. +1 issue.
Patch by kgrittn on 2013-07-09: Fixed all reported issues. Some question on whether error context for duplicate keys is OK.
Review by kgrittn on 2013-07-16: Brief review saying no problems found.
Committed Kevin Grittner Hitoshi Harada 2013-07-16
dynamic background workers
Review by maiku41 on 2013-06-21: Review by Michael Paquier: Minor comments and testing
Review by michael-kun on 2013-06-25: Review of 2nd patch: compilation, test and code review
Comment by maiku41 on 2013-07-05: Under discussion as of 4/3. Expecting updated patch.
Committed Robert Haas Michael Paquier 2013-07-16
add --progress option to pgbench
Review by calvin on 2013-07-01: Review by Mitsumasa.
Patch by calvin on 2013-07-01: v6 which includes Mitsumasa style suggestions.
Patch by calvin on 2013-07-11: v7 with updated error message, suggested by Tatsuo Ishii.
Committed Fabien Coelho Mitsumasa KONDO 2013-07-16
Add FILTER option to aggregates, as mandated by SQL standard.
Review by deanr on 2013-07-01: Review of updated patch. Looks good. Some minor doc issues.
Patch by dfetter on 2013-07-05: Updated docs per request
Patch by deanr on 2013-07-06: Fixes minor typo in docs. Marking ready for committer.
Committed David Fetter Dean Rasheed 2013-07-17
WITH CHECK OPTION for auto-updatable views
Patch by deanr on 2013-07-03: Rebased to apply cleanly to git master
Patch by deanr on 2013-07-05: Updated patch following Pavel's review.
Review by okbobcz on 2013-07-06: it ready for commiter
Committed Dean Rasheed Pavel Stehule 2013-07-18
simplify variadic "any"
Review by jeevan.chalke on 2013-06-27: Initial Review. Need few clarification on some changes.
Patch by okbobcz on 2013-06-30: more asserts, more comments
Review by jeevan.chalke on 2013-07-02: Looks good to go in now. Thanks Pavel.
Committed Pavel Stehule Jeevan Chalke 2013-07-18
Fix pgstattuple/pgstatindex to use regclass-type as the argument
Review by rlathia on 2013-07-16: Few comments in the code and documentation change ???
Comment by snaga on 2013-07-18: Comments by Masao Fujii.
Patch by snaga on 2013-07-18: Patch revised per review and comments.
Committed Satoshi Nagayasu Rushabh Lathia 2013-07-19
add --throttle to pgbench
Patch by calvin on 2013-07-17: v16 fixes conflicts introduced by a recent commit.
Patch by calvin on 2013-07-18: v17 with updated & extended documentation about "lag", asked by Tatsuo.
Patch by gsmith on 2013-07-22: v18 with more documentation updates
Committed Fabien Coelho Greg Smith 2013-07-22
logical changeset generation v5
Review by kgrittn on 2013-06-23: Each patch file in turn applies cleanly, builds without warning, and passes make check-world. More detailed review to come.
Comment by aglio on 2013-07-08: Ongoing discussion on use of the relcache and potential issues.
Comment by gsmith on 2013-07-23: Summary of partial commits completed
Committed Andres Freund Kevin Grittner, Robert Haas, Tom Lane, Steve Singer 2013-07-23
Add more regression tests mostly for ALTER OPERATOR FAMILY .. ADD/DROP
Patch by robins on 2013-05-23: Initial version.
Review by szymon on 2013-06-20: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Committed Robins Tharakan Szymon Guz 2013-07-23
access to calls stack from GET DIAGNOSTICS statement
Patch by okbobcz on 2013-02-03: Initial version.
Review by rlathia on 2013-06-24: Submitted review points to the patch mail thread.
Patch by okbobcz on 2013-06-26: updated patch
Committed Pavel Stehule Rushabh Lathia 2013-07-24
UNNEST() (and other functions) WITH ORDINALITY
Patch by dfetter on 2013-07-03: More re-jiggering to reflect what's gone on on master.
Patch by gsmith on 2013-07-23: Update with some bug fixes
Patch by rhodiumtoad on 2013-07-25: Updated patch with more comments.
Committed Andrew Gierth, David Fetter Dean Rasheed, Jeevan Chalke 2013-07-29

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Tablesample implementation
Patch by huangqi on 2012-08-21: Initial version.
Review by umitanuki on 2012-09-18: The patch needs to be updated.
Returned with Feedback Huang Qi Hitoshi Harada 2013-05-22
logical changeset generation v4
Comment by ringerc on 2013-01-21: Bug encountered (see mail); queried, W.A. pending confirmation
Comment by andresfreund on 2013-01-23: Aforementioned bug/usability problem has been fixed in new version (git repo, too big for a repost for a minor change), needs review
Review by ssinger on 2013-01-28: Review from a plugin users point-of-view. Raised a number of issues that need to be addressed
Returned with Feedback Andres Freund Dimitri Fontaine,Steve Singer 2013-06-14
Batch API for After Triggers
Patch by aglio on 2013-06-17: Initial version.
Comment by aglio on 2013-06-18: Withdrawn by Simon per email.
Comment by simon on 2013-07-04: Note this was never actually submitted to CF
Returned with Feedback Simon Riggs Nobody 2013-06-18
dividing privileges for replication role
Comment by ringerc on 2013-01-21: Waiting on author pending revision.
Comment by tomonari katsumata on 2013-01-22: answering the above comments.
Comment by aglio on 2013-06-24: Moving to Returned With Feedback due to author no-show.
Returned with Feedback Tomonari Katsumata Nobody 2013-06-24
minmax indexes
Patch by alvherre on 2013-06-14: Initial version.
Comment by maiku41 on 2013-06-25: Returned with Feedback: No patch attached. Ongoing discussion of proposed feature.
Returned with Feedback Álvaro Herrera Nobody 2013-06-25
MD5 aggregate function
Review by maiku41 on 2013-06-21: Review by David Fetter
Review by dfetter on 2013-06-22: On further testing, the performance decrease went away.
Review by nmisch on 2013-06-26: New aggregates don't belong in core. Instead of optimizing src/backend/libpq/md5.c, what about importing an already-efficient implementation?
Returned with Feedback Dean Rasheed David Fetter 2013-06-27
pgbench --startup
Patch by jjanes on 2013-06-20: coding style fix-up, conflict resolved.
Review by calvin on 2013-06-20: minor points.
Comment by rhaas on 2013-06-27: author will rewrite, but not for this CF
Returned with Feedback Jeff Janes Fabien Coelho, Robert Haas 2013-06-27
Move unused buffers to freelist
Patch by amitkapila on 2013-05-15: This patch is to make buffers available to backends from freelist by moving unused buffers to freelist by bgwriter/checkpointer
Patch by amitkapila on 2013-06-07: Patch modified, so that only bgwriter will put unused buffers to free list.
Detailed steps I have used to get performance data.
Review by rhaas on 2013-06-28: patch needs major revisions, marking returned with feedback
Returned with Feedback Amit Kapila Robert Haas 2013-06-28
ASYNC Privileges proposal
Patch by aglio on 2013-06-17: Initial version.
Comment by aglio on 2013-06-24: Need to address concerns raised by several commentors.
Comment by aglio on 2013-06-28: Needs more thought on the permissions model involved, and performance testing. Not committable as-is.
Returned with Feedback Chris Farmiloe Nobody 2013-06-28
GIN improvements part 1: additional information
Patch by smagen on 2013-06-13: Initial version.
Patch by smagen on 2013-06-17: Refactoring and bug fixes
Comment by maiku41 on 2013-06-28: Possible problems noted on 6/27
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-06-30
Index on regexes
Patch by smagen on 2013-06-13: Initial version.
Comment by maiku41 on 2013-06-28: Comments from reviewer.
Comment by heikki on 2013-06-30: This is dependent on the "additional information" patch. I bounced the "additional info" patch, so bouncing this too, until that one gets applied.
Returned with Feedback Alexander Korotkov Heikki Linnakangas 2013-06-30
GIN improvements part 2: fast scan
Patch by smagen on 2013-06-14: Initial version.
Patch by smagen on 2013-06-17: Refactoring and bug fixes
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-06-30
GIN improvements part 3: ordering in index
Patch by smagen on 2013-06-14: Initial version.
Patch by smagen on 2013-06-17: Refactoring and bug fixes
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-06-30
WIP: Levenshtein-Damerau edit distance
Patch by jconway on 2013-06-25: New version of patch in context diff form
Comment by aglio on 2013-07-03: Feedback from several hackers. Patch is not in committable form, needs changes.
Review by aglio on 2013-07-05: Review by Michael Paquier. Multiple issues with patch. Most importantly, licensing issue with upstream code.
Returned with Feedback Liming Hu Joe Conway 2013-07-03
fixing pg_ctl with relative paths
Patch by schmiddy on 2013-01-24: Initial version.
Review by schmiddy on 2013-06-26: initial review, two minor issues
Patch by schmiddy on 2013-06-26: v2 patch
Returned with Feedback Josh Kupershmidt Hari Babu, Fujii Masao 2013-07-04
Block write statistics WIP
Patch by aglio on 2013-06-17: Initial version.
Comment by snaga on 2013-07-01: Comment and design question.
Returned with Feedback Greg Smith Satoshi Nagayasu 2013-07-05
LDAP bugfix and don't use deprecated API
Patch by laurenz on 2013-02-06: Initial version.
Returned with Feedback Laurenz Albe Magnus Hagander 2013-07-05
Query result history in psql
Review by ilink on 2013-06-25: Patch looks good, but missing a few features/considerations.
Comment by aglio on 2013-06-28: Maciej planning to submit revised patch on 7/1
Patch by maciek_g on 2013-07-02: Revised patch
Returned with Feedback Maciej Gajewski Ian Link 2013-07-07
preserving forensic information when we freeze
Review by andresfreund on 2013-06-24: Nearly ready, some minor adjustments requested.
Comment by rhaas on 2013-07-02: responses to Andres' review comments
Comment by aglio on 2013-07-08: Robert Haas: Will work on this for next CF
Returned with Feedback Robert Haas Andres Freund 2013-07-08
Allows extensions to install header file
Patch by c2main on 2013-06-18: Initial version.
Comment by maiku41 on 2013-06-21: Set to Waiting on Author based on discussion.
Comment by aglio on 2013-07-11: Discussion stalled, no further work on patch. Returning.
Returned with Feedback Cédric Villemain Peter Eisentraut 2013-07-11
"Big" regression test separation
Patch by calvin on 2013-07-11: v5 fixes conflicts introduced by recent commits.
Review by samratr on 2013-07-11: According to author it is POC patch and under discussion
Comment by aglio on 2013-07-11: Marking "returned with feedback" since there's a lot of spec discussion required before commitability.
Returned with Feedback Fabien Coelho Samrat Revagade 2013-07-11
Improvement of checkpoint IO scheduler for stable transaction responses
Patch by mitsu-ko on 2013-07-09: create v2 patch
Patch by mitsu-ko on 2013-07-11: create v3 v4 v5 patches
Review by gsmith on 2013-07-14: Suggestions on checkpoint timing, additional data to monitor, past submission with similar code.
Returned with Feedback Mitsumasa KONDO Heikki Linnakangas, Greg Smith 2013-07-14
Remove PD_ALL_VISIBLE
Patch by jdavis on 2013-06-10: Rebased.
Comment by aglio on 2013-07-01: Moved to Returned with Feedback per Jeff Davis. Will be revisited next CF.
Comment by jdavis on 2013-07-02: My comment was misinterpreted; still looking for some progress here.
Returned with Feedback Jeff Davis Robins Tharakan 2013-07-15
Extension templates
Review by aglio on 2013-07-05: Extensive review by Markus Wanner. Found some issues with commands, pg_depends, and error messages. Needs revision.
Patch by dim on 2013-07-08: Patch v9, more cleaning up, including "Template" model analysis by Markus.
Comment by maiku41 on 2013-07-16: Ongoing discussion at end of CF. Returned with Feedback
Returned with Feedback Dimitri Fontaine Markus Wanner, Hitoshi Harada, Jaime Casanova 2013-07-16
TransactionIdIsInProgress() procno cache
Comment by aglio on 2013-07-10: Setting patch back to "needs review" since it hasn't actually had any performance testing.
Comment by aglio on 2013-07-12: Setting back to "ready for committer" per discussion on -performance.
Comment by ams on 2013-07-13: Can't reproduce performance gains
Returned with Feedback Simon Riggs Satoshi Nagayasu 2013-07-16
Make recovery.conf parameters into GUCs
Patch by gsmith on 2013-07-15: Updated prototype
Comment by maiku41 on 2013-07-16: Still in the works as of end of CF. Returned with Feedback.
Review by gsmith on 2013-07-18: Suggestions for how to handle the trigger file usefully.
Returned with Feedback Fujii Masao, Michael Paquier, edited by Simon Riggs Greg Smith 2013-07-16
pg_filedump 9.3: checksums (and a few other fixes)
Review by snaga on 2013-07-06: Reviewed with additional question.
Comment by maiku41 on 2013-07-16: Printing of flags still under discussion.
Comment by maiku41 on 2013-07-16: This patch doesn't need to be in the CF since it's not part of the community distribution. Marking as Returned with Feedback to close it out nicely.
Returned with Feedback Jeff Davis Satoshi Nagayasu 2013-07-16
Add visibility map information to pg_freespace.
Patch by horiguti on 2013-07-09: 2nd ver for pg_freespace and 1st ver for pgstattuple, without docs.
Review by snaga on 2013-07-16: Reviewed with a few comments.
Comment by maiku41 on 2013-07-16: Still waiting on author's response to review at end of CF. Returned with Feedback.
Returned with Feedback Kyotaro Horiguchi Satoshi Nagayasu 2013-07-16
Non-recursive processing of AND/OR lists
Patch by singh.gurjeet on 2013-06-30: Submitted patch v5, with updates as a result of the review.
Review by rhaas on 2013-07-02: recommend we do only half of what this patch does
Comment by maiku41 on 2013-07-16: Still under discussion at end of CF. Returned with Feedback
Returned with Feedback Gurjeet Singh Pavel Stehule, Robert Haas 2013-07-16
Remove useless USE_PGXS support in contrib
Review by c2main on 2013-06-19: Ready, Waiting more feedback from community
Comment by aglio on 2013-07-03: Moved to "waiting on author" because this patch is still under spec discussion.
Comment by maiku41 on 2013-07-16: Returned with Feedback
Returned with Feedback Peter Eisentraut Cédric Villemain 2013-07-16
updated emacs configuration
Comment by maiku41 on 2013-06-21: Moved to Waiting on Author based on reviewer comments.
Comment by maiku41 on 2013-06-28: Still under discussion as of 6/27.
Patch by petere on 2013-07-03: updated patch
Returned with Feedback Peter Eisentraut Dimitri Fontaine 2013-07-16
Reduce maximum error in tuples estimation after vacuum.
Comment by amitkapila on 2013-06-25: Could not reproduce the scenario for which improvement is proposed, more input is required from Author.
Comment by amitkapila on 2013-07-09: some scenario's where proposed algorithm is worse than Head.
Comment by maiku41 on 2013-07-16: Still waiting for author's response to reviewer's comments at end of CF. Returned with Feedback.
Returned with Feedback Kyotaro Horiguchi Amit Kapila 2013-07-16
Add more regression tests for SEQUENCE
Patch by robins on 2013-07-07: Updated as per 3rd July feedback
Comment by calvin on 2013-07-09: Wrong patch.
Patch by robins on 2013-07-15: Attached the correct patch this time.
Returned with Feedback Robins Tharakan Fabien Coelho 2013-07-16
Add more regression tests for SCHEMA
Patch by robins on 2013-07-07: Updated as per feedback
Comment by calvin on 2013-07-09: Patch format issue?
Patch by robins on 2013-07-15: Attached updated patch. (The last line(-ending?) seems to have been missing).
Returned with Feedback Robins Tharakan Fabien Coelho 2013-07-16
Add more regression tests for ROLE (USER)
Review by calvin on 2013-05-09: Ok!
Review by rhaas on 2013-07-03: too many unnecessary create/drop cycles
Patch by robins on 2013-07-15: Updated patch after removing most of CREATE ROLE / DROP ROLE changes.
Returned with Feedback Robins Tharakan Fabien Coelho 2013-07-16
Add basic regression tests for DISCARD
Review by fabriziomello on 2013-07-11: Final review of this patch. Ready for commiter.
Review by rhaas on 2013-07-15: Further review comments.
Comment by maiku41 on 2013-07-16: Still open at end of CF. Returned with Feedback.
Returned with Feedback Robins Tharakan Fabrízio de Royes Mello 2013-07-16
Add basic regression tests for SET xxx
Patch by robins on 2013-07-07: Updated as per Robert's feedback (prepend regress_xxx to ROLEs). Added to serial_schedule (missed out earlier).
Review by rhaas on 2013-07-15: Needs work.
Comment by maiku41 on 2013-07-16: Needs work at end of CF. Returned with Feedback.
Returned with Feedback Robins Tharakan Szymon Guz 2013-07-16
Pluggable toast compression
Patch by andresfreund on 2013-06-21: Version with lz4 support and various other things
Comment by maiku41 on 2013-07-05: Pending discussion.
Comment by aglio on 2013-07-17: Returned pending legal consultation regarding lz4/snappy. Expected to be reintroduced in CF3.
Returned with Feedback Andres Freund Hitoshi Harada 2013-07-17
Performance Improvement by reducing WAL for Update Operation
Patch by haribabu on 2013-07-02: Rebased patch as per latest PG LZ algorithm.
Patch by haribabu on 2013-07-19: Latest patch
Review by gsmith on 2013-07-22: Performance on "hundred tiny fields" cases are an issue, especially "half nulls" one.
Returned with Feedback Amit Kapila, Hari Babu Greg Smith 2013-07-22
Row-Level Security
Patch by gsmith on 2013-07-19: Updated to fix trivial bit rot. Suggestions on the skills needed to review the feature usefully.
Comment by gsmith on 2013-07-22: Suggested improvement for eliminating getrelid changes.
Patch by ringerc on 2013-10-23: v4 of the patch against 9.4
Returned with Feedback KaiGai Kohei Mike Blackwell, Atri Sharma, Dean Rasheed 2013-07-22
Add more regression tests for DBCommands
Review by szymon on 2013-06-20: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Patch by robins on 2013-07-07: Updated as per Robert's feedback (prepend regress_xxx to ROLEs). Added to serial_schedule (missed out earlier).
Review by rhaas on 2013-07-15: More review comments.
Returned with Feedback Robins Tharakan Szymon Guz 2013-07-23
Remove unused targets from plan (from 2013-01)
Review by alvherre on 2013-06-25: please add a few comments
Patch by efujita on 2013-07-03: Added some comments and improved the code a little bit.
Review by tgl on 2013-08-02: Should take the cost savings into account while choosing the plan, not just whack the tlist around afterwards...
Returned with Feedback Alexander Korotkov, Etsuro Fujita Hitoshi Harada, Álvaro Herrera 2013-08-02

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Process title for autovac worker
Patch by jjanes on 2013-04-06: Initial version.
Comment by jjanes on 2013-04-13: Some security concerns, and pg_stat_activity already provides this info
Rejected Jeff Janes Nobody 2013-04-13
Add regression tests for COLLATE
Patch by robins on 2013-05-23: Remove tests that cant work on all systems (for e.g. UTF8 tests). Used DROP COLLATION IF EXISTS where possible.
Comment by rhaas on 2013-07-03: some post-commit cleanup would be appreciated
Comment by rhaas on 2013-07-03: buildfarm sad; patch reverted
Rejected Robins Tharakan Fabien Coelho 2013-07-03
XidIsInProgress() cache
Patch by simon on 2013-05-11: Initial version.
Comment by maiku41 on 2013-06-21: Moved to Waiting on Author based on comments.
Comment by aglio on 2013-07-08: This patch entry is a duplicate of TransactionIDIsInProgress(). Deleting the duplicate patch entry to clean things up.
Rejected Simon Riggs Satoshi Nagayasu 2013-07-08
Add SPI_gettypmod() to return a field's typemod from a TupleDesc
Review by jeevan.chalke on 2013-06-26: Patch looks good. Its very simple and straight forward. Has documentation as well. No issue found in testing and code walk-through
Patch by nmisch on 2013-07-07: Latest version
Comment by nmisch on 2013-07-08: Recommend we not add more trivial SPI_* wrappers.
Rejected Mark Wong Jeevan Chalke 2013-07-12
clean up addRangeTableEntryForFunction
Review by rhaas on 2013-07-02: seems pointless
Comment by rhodiumtoad on 2013-07-02: This was obsoleted months ago - why was it even here, and why was it added by a third party? I had no idea it was still in play.
Comment by rhodiumtoad on 2013-07-16: Treat this as "withdrawn by author"
Rejected David Fetter and Andrew Gierth Etsuro Fujita, Robert Haas 2013-07-16
CREATE CAST ... AS EXPLICIT
Comment by aglio on 2013-07-08: Objection on approach, additional SQL keywords.
Comment by calvin on 2013-07-09: Measured impact is +8 bytes (and -4 KB!). Overall footprint of keywords could be reduced, but this is another issue.
Comment by aglio on 2013-07-17: Marking as rejected per offline conversation with Fabien and Tom.
Rejected Fabien Coelho Cédric Villemain 2013-07-16