Log In - Home Page

CommitFest 2012-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Needs Review: 1, Committed: 25, Returned with Feedback: 13, Rejected: 4. Total: 43.

Pending Patches

Patch Name Status Author Reviewers Last Activity

Miscellaneous

 
Removing PD_ALL_VISIBLE
Patch by ringerc on 2013-01-18: Initial version.
Comment by ringerc on 2013-01-18: New patch with simple WAL logging.
Needs Review Jeff Davis Robert Haas 2013-01-18

Committed Patches

Patch Name Status Author Reviewers Date Closed
Doc patch "only relevant" -> "relevant only"
Patch by kop on 2012-10-17: Initial version.
Committed Karl O. Pinc Peter Eisentraut 2012-11-12
Doc patch to See Also: CREATE TABLE AS in CREATE TABLE docs
Patch by kop on 2012-10-02: Initial version.
Committed Karl O. Pinc Peter Eisentraut 2012-11-13
Doc patch, use of commas in pg_restore docs
Patch by kop on 2012-10-17: Initial version.
Committed Karl O. Pinc Peter Eisentraut 2012-11-15
Doc patch, put pg_temp into the documentation's index
Patch by kop on 2012-10-02: Initial version.
Committed Karl O. Pinc Peter Eisentraut 2012-11-17
Reduce palloc's in numeric operations
Patch by horiguti on 2012-11-12: Initial version.
Review by okbobcz on 2012-11-19: I have no objection
Committed Kyotaro Horiguichi Pavel Stehule 2012-11-21
bug fix of pg_stat_replication.sync_state
Patch by masaofujii on 2012-11-09: Initial version.
Comment by heikki on 2012-11-23: Bug fix for 9.2 and 9.1.
Committed Kyotaro Horiguchi Fujii Masao 2012-11-23
split rmgr's rm_desc functions
Patch by alvherre on 2012-10-24: Initial version.
Patch by alvherre on 2012-11-23: v2, need agreement on file placement
Committed Álvaro Herrera Nobody 2012-11-28
binary heap library functions
Review by rhaas on 2012-11-15: Review.
Patch by ams on 2012-11-16: Updated patch (mostly style changes)
Patch by rhaas on 2012-11-20: Proposed patch for commit.
Committed Abhijit Menon-Sen Robert Haas 2012-11-29
libpq function PQconninfo
Patch by mha on 2012-11-21: Initial version.
Comment by mha on 2012-11-21: This is the broken-out part from the pg_basebackup patch that just deals with libpq.
Patch by zboszor on 2012-11-22: Small supplemental fixes.
Committed Zoltán Böszörményi Magnus Hagander 2012-11-30
Store the number of subtransactions in xl_running_xacts separately from toplevel xids
Patch by andresfreund on 2012-11-15: Initial version.
Comment by andresfreund on 2012-11-15: Looks ok, possibly too wide scope
Committed Andres Freund Simon Riggs 2012-12-02
LDAP URLs
Patch by petere on 2012-11-15: Initial version.
Committed Peter Eisentraut Nobody 2012-12-04
pgstatginindex
Comment by horiguti on 2012-11-20: One missing file, one comment on implement, another on specification.
Patch by masaofujii on 2012-11-23: Updated version.
Review by horiguti on 2012-11-28: Looks good. I'll send this to committers.
Committed Fujii Masao Kyotaro Horiguchi 2012-12-05
Extra Daemons, a.k.a. Background Workers
Review by markus on 2012-11-30: Additional review.
Patch by alvherre on 2012-12-04: v8
Comment by andresfreund on 2012-12-08: Committed, but open issues around EXEC_BACKEND remain
Committed Álvaro Herrera KaiGai Kohei 2012-12-06
plpgsql: returning row expression
Comment by okbobcz on 2012-12-05: no objection
Comment by tgl on 2012-12-05: Not happy with the coercion semantics this version embodies.
Patch by asif.rana on 2012-12-06: stripped-down version. removed the type coercions support from tupconvert.
Committed Asif Rehman Pavel Stehule 2012-12-07
Updatable views
Review by amitkapila on 2012-09-20: seems to be bugs in upgrade and acl. Some more work is required.
Patch by deanr on 2012-09-23: Updated patch - addresses review comments
Comment by andresfreund on 2012-12-08: Tom is working on it
Committed Dean Rasheed Amit Kapila 2012-12-08
autovacuum truncate lock
Patch by wieck on 2012-12-08: Updated patch without GUCs
Review by kgrittn on 2012-12-09: Remaining trivial issues can be fixed in commit.
Patch by wieck on 2012-12-11: Cleanup of all remaining trivial issues.
Committed Jan Wieck Kevin Grittner 2012-12-11
Switching timeline over streaming replication
Patch by heikki on 2012-11-19: Yet another patch version, fixing reported bugs
Review by amitkapila on 2012-11-21: few defects and some review comments needs to be handled.
Patch by andresfreund on 2012-12-08: new version of the patch by heikki
Committed Heikki Linnakangas Amit Kapila 2012-12-13
Doc patch, normalize search_path in index
Patch by kop on 2012-10-02: Initial version.
Patch by kop on 2012-11-14: Bundled this in with other changes to the way search_path is indexed since one applies on top of the other. So, this merges two commitfest entries. (!) https://commitfest.postgresql.org/action/patch_view?id=950
Committed Karl O. Pinc Peter Eisentraut 2012-12-14
Doc patch, index search_path where it's used to secure functions
Patch by kop on 2012-10-02: Initial version.
Comment by kop on 2012-10-02: v2 of patch
Patch by kop on 2012-11-14: Made recommended changes
Committed Karl O. Pinc Peter Eisentraut 2012-12-14
Doc patch to note which system catalogs have oids
Patch by kop on 2012-10-02: Corrects initial version -- the version which lists the oid column in the same fashion as all the other columns.
Patch by kop on 2012-10-02: This version of the patch puts the oid into the (doc's) table of all the columns but in a separate section to keep the oid from looking like a regular column.
I did a previous patch like this one but differing only in the column heading. I like this column heading better.

You may want to read through the thread to see who likes what version and why.
Patch by jdavis on 2012-12-14: Review and potential alternative patch from reviewer.
Committed Karl O. Pinc Jeff Davis 2012-12-15
Doc patch, put RAISE USING keywords into a table
Patch by kop on 2012-10-26: Initial version.
Patch by kop on 2012-10-26: Say "option" instead of "keyword".
Patch by kop on 2012-10-26: I prefer the previous patch. This version uses a variablelist instead of a table.
Committed Karl O. Pinc Peter Eisentraut 2012-12-18
Make pg_basebackup configure and start standby
Patch by zboszor on 2012-11-22: Small fixes.
Patch by zboszor on 2012-11-30: Rebased to the latest GIT HEAD and the committed PQconninfo() API.
Comment by mha on 2013-01-01: tar refactoring committed
Committed Zoltán Böszörményi Amit Kapila, Fujii Masao 2013-01-05
pgbench - custom logging step, estimate of remaining time
Comment by fuzzycz on 2012-12-04: Response to the review.
Patch by fuzzycz on 2012-12-09: Patch with the minor issues fixed.
Patch by fuzzycz on 2012-12-20: Fixed patch - probably a final version.
Committed Tomas Vondra Jeevan Chalke 2013-01-07
Support multiple --table options
Patch by schmiddy on 2012-10-31: Initial version.
Comment by kop on 2012-12-11: Note possible backwards incompatibility since the current pg_restore uses the last --table argument and ignores the rest. Otherwise, minor documentation fixes seem all that's needed.
Patch by kop on 2012-12-14: Final patch. (Remove tabs in docs.) I'm (the reviewer) not overly familiar with pg coding style and did not spend a lot of time looking at the code once patched to be sure that the style was perfect. It looked right to me. Tests out using test script attached to my 2nd message in the thread. Look also at the doc syntax summaries of clusterdb, reindexdb, and vacuumdb and see if the ellipsis are where you like them.
Committed Josh Kupershmidt Karl O. Pinc 2013-01-17
Slave enters in recovery and promotes when WAL stream with master is cut + delay master/slave
Review by ringerc on 2013-01-18: Pointed out fragile-looking code (Hekki)
Patch by ringerc on 2013-01-18: Revised after discussion (Hekki)
Review by ringerc on 2013-01-18: Looks good to me (Andres)
Committed Andres Freund Heikki Linnakangas 2013-01-18

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Doc patch, distinguish sections with an empty row in error code table
Review by rhaas on 2012-11-05: not the right approach
Patch by kop on 2012-11-06: V2 of patch to fix the problem the "right way" using <tgroup>. Does not work, unless I've made a stupid mistake somewhere.
Comment by kop on 2012-12-10: Reject this patch? (Am I supposed to do this?)
Returned with Feedback Karl O. Pinc Robert Haas, Tom Lane 2012-11-05
Suggestion for --truncate-tables to pg_restore
Patch by kop on 2012-11-12: New patch to apply to latest head.
Review by schmiddy on 2012-12-05: Review of v4 patch.
Comment by kop on 2012-12-10: Reject this patch?
Returned with Feedback Karl O. Pinc Josh Kupershmidt 2012-12-04
pg_dump --extension-script
Patch by dim on 2012-11-12: Initial version.
Review by ali on 2012-12-05: Comments and Observations
Returned with Feedback Dimitri Fontaine Ali Dar 2012-12-05
Doc patch, further describe additive nature of the permission system
Patch by kop on 2012-10-02: Additional paragraph added (as separate patch file) regards roles
Patch by kop on 2012-10-02: Fix typeo in second patch. Latest version of both patch files attached.
Patch by kop on 2012-12-11: Another try.
Returned with Feedback Karl O. Pinc Nobody 2012-12-11
pg_dump --format=split
Patch by johto on 2012-10-22: Initial version.
Comment by dim on 2012-11-27: Review raising questions, needs more review and advice from a pg_dump guru.
Comment by alvherre on 2012-11-28: needs to handle circular dependencies in homonymous objects
Returned with Feedback Marko Tiikkaja, Joel Jacobson Dimitri Fontaine 2012-12-14
Doc patch, Add big fat caution to pg_restore docs regards partial db restores
Patch by kop on 2012-10-02: Initial version.
Comment by kop on 2012-10-02: I have mixed feelings about putting something so obvious in the docs.
Returned with Feedback Karl O. Pinc Peter Eisentraut 2012-12-16
Trim trailing NULL columns
Review by amitkapila on 2012-10-16: few review comments needs to be addressed.
Patch by amitkapila on 2012-10-19: updated patch to handle review comments.
Comment by simon on 2013-01-11: Performance tests show a reasonable gain in the extreme cases, but they are sensitive to exact layout of values. Performance regression of 1% on normal pgbench. Impact > benefit, so rejected from this CF. More work is possible in future.
Returned with Feedback Jameison Martin Josh Berkus, Amit Kapila 2013-01-11
Patch for option in pg_resetxlog for restore from WAL files
Patch by amitkapila on 2012-07-23: Initial version.
Comment by amitkapila on 2012-07-23: This patch is for providing an option in pg_resetxlog to restore the control file values from WAL files.
Comment by heikki on 2012-09-24: This should be refactored to make use of the generic xlogreader facility.
Returned with Feedback Amit Kapila Nobody 2013-01-11
Timing Events WIP v1
Patch by gsmith on 2012-11-15: Initial version.
Returned with Feedback Greg Smith Nobody 2013-01-13
2d-mapping based GiST for ranges
Patch by heikki on 2012-12-05: Latest version of the patch
Review by heikki on 2012-12-05: Review comments from Jeff Davis
Comment by jdavis on 2012-12-18: Duplicate of "Adjacent in SP-GiST for range-types".
Returned with Feedback Alexander Korotkov Nobody 2013-01-15
Make hugepage TLB usable for mmap()ed shared memory
Patch by cjk on 2012-10-30: Initial version.
Patch by cjk on 2012-11-01: Updated patch
Review by andresfreund on 2012-12-03: some small issues remaining
Returned with Feedback cjk Andres Freund 2013-01-15
logical changeset generation v3
Review by ssinger on 2012-12-09: Review of patch 9/14. This patch is ready for a committer
Patch by andresfreund on 2012-12-10: New version of the patch series addressing review comments (including a rebase onto a different xlogreader)
Review by pgeoghegan on 2012-12-13: Extensive, relatively high level review that summarises the current state of the patch.
Returned with Feedback Andres Freund Peter Geoghegan 2013-01-15
pg_trgm partial-match
Patch by masaofujii on 2012-11-16: Initial version.
Review by fuzzycz on 2012-11-19: initial review - mostly minor issues
Comment by masaofujii on 2012-11-23: Needs to implement the infra patch first.
Returned with Feedback Fujii Masao Tomas Vondra 2013-01-16

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Always include encoding of database in pg_dumpall
Patch by jeremyevans on 2012-10-19: Initial version.
Rejected Jeremy Evans Nobody 2012-11-12
DEALLOCATE IF EXISTS
Patch by glaucous on 2012-11-09: Initial version.
Review by johto on 2012-11-20: Looks good to me
Rejected Vik Reykja Marko Tiikkaja 2012-12-05
Make libpq robust against messages in the openssl error queue
Patch by larskanis on 2012-10-25: Initial version.
Comment by larskanis on 2012-11-12: Further comments to question from Robert Haas.
Review by andresfreund on 2012-12-08: Tom doesn't think clearing up the error queue is libpq's job.
Rejected Lars Kanis Nobody 2012-12-08
allow assignment-casts to be used for signature matching when no overloading is in use
Patch by rhaas on 2012-11-13: Initial version.
Comment by wieck on 2012-12-09: Question about possible unwanted side effects
Comment by jdavis on 2012-12-14: Consensus on design not reached.
Rejected Robert Haas Nobody 2012-12-14