Log In - Home Page

CommitFest 2012-09 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 20, Returned with Feedback: 20, Rejected: 5. Total: 45.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
pgbench initialization: vacuum tables before index build
Patch by jjanes on 2012-07-20: Initial version.
Committed Jeff Janes Nobody 2012-07-23
Tab completion for INHERIT and NO INHERIT
Patch by jjanes on 2012-07-24: Initial version.
Committed Jeff Janes Nobody 2012-07-27
fsync backup_label on create
Patch by davidkerr on 2012-07-07: Initial version.
Committed David Kerr Robert Haas, Simon Riggs 2012-08-07
"CLUSTER VERBOSE" tab completion
Patch by jjanes on 2012-08-19: Initial version.
Patch by jjanes on 2012-08-19: v2, tab complete the initial "VERBOSE" reserved word as well
Committed Jeff Janes Nobody 2012-08-20
tab completion for drop constraint
Patch by jjanes on 2012-08-19: Initial version.
Committed Jeff Janes Nobody 2012-08-20
Change pg_ident.conf parsing to be the same as pg_hba.conf
Patch by amitkapila on 2012-07-04: Initial version.
Comment by amitkapila on 2012-07-04: This patch is based on Todo Item: Change pg_ident.conf parsing to be the same as pg_hba.conf
After this patch it will detect syntax errors in pg_ident.cong at startup or reload time rather then at authentication.
Committed Amit Kapila Heikki Linnakangas 2012-09-21
Alter enum add value if not exists
Patch by adunstan on 2012-08-20: Initial version.
Patch by adunstan on 2012-09-22: revised patch after comments
Committed Andrew Dunstan Tom Lane, Magnus Hagander 2012-09-22
Config Directories
Patch by selena on 2012-09-20: Initial version.
Patch by selena on 2012-09-20: v5
Patch by selena on 2012-09-20: v6
Committed Magnus Hagander Greg Smith, Selena Deckelmann, Noah Misch 2012-09-25
pg_signal_backend asymmetry
Patch by schmiddy on 2012-07-04: Initial version.
Review by nmisch on 2012-09-26: Please commit and backpatch; style nit to consider
Committed Josh Kupershmidt Noah Misch 2012-09-27
CREATE SCHEMA IF NOT EXISTS
Patch by fabriziomello on 2012-09-23: (v6) the attached patch skip only the schema creation and execute others statements
Comment by vog on 2012-09-29: The following INEs should be implemented, too:

CREATE [ TEMPORARY | TEMP ] SEQUENCE [ IF NOT EXISTS ] name ...
ALTER TABLE ... ADD [ COLUMN ] [ IF NOT EXISTS ] column_name ...
CREATE [ UNIQUE ] INDEX [ CONCURRENTLY ] [ IF NOT EXISTS ] [ name ] ON ...
Patch by fabriziomello on 2012-10-03: (v7) The attached patch throw an error if we use "IF NOT EXISTS" with schema elements.
Committed Fabrízio de Royes Mello Dickson S. Guedes 2012-10-03
pgbench - random sampling of transactions written into log
Patch by fuzzycz on 2012-08-24: Initial version.
Patch by fuzzycz on 2012-09-20: an updated version of the patch
Committed Tomas Vondra Jeff Janes, Robert Haas 2012-10-03
ToDo: allow to get a number of processed rows by COPY statement
Review by amitkapila on 2012-09-22: when "pg_stat_statements" extention is utilized COPY command is giving garbage values.
Patch by okbobcz on 2012-09-28: reduced patch
Patch by okbobcz on 2012-10-02: small revision - reflects Heikki proposal
Committed Pavel Stehule Amit Kapila 2012-10-03
64-bit API for large object
Patch by anzai on 2012-09-24: This is version 2 of the patch.
Comment by kaigai on 2012-09-27: various comments about 4TB boundary checks.
Patch by anzai on 2012-10-01: This is version 3 of the patch.
Committed Nozomi Anzai, Yugo Nagata KaiGai Kohei 2012-10-07
pg_test_fsync microsecs/op output
Patch by pgeoghegan on 2012-09-08: Initial version.
Committed Peter Geoghegan Simon Riggs 2012-10-09
Move postgresql_fdw_validator into dblink
Review by kaigai on 2012-09-20: Result of PQconndefaults() does not need to free.
Patch by hanada on 2012-10-09: v3 patch, fix obsolete comment.
Comment by tgl on 2012-10-10: I don't think we can apply the part of this patch that removes postgresql_fdw_validator from the core, because that would break upgrading databases that contain FDWs using postgresql_fdw_validator. We need some stepwise plan for letting people update their FDWs beforehand. I've committed the dblink changes though.
Committed Shigeru HANADA KaiGai Kohei 2012-10-10
timeout configuration parameter for walreceiver
Patch by amitkapila on 2012-09-14: Initial version. This Patch is to introduce a timeout configuration parameter for walreceiver. This timeout will indicate the maximum time walreceiver has to wait for communication from walsender. This will also fix bug 7534.
Patch by amitkapila on 2012-09-21: Version-2 to address the suggestion of sending heart-beat from sender so that receiver should not timeout incase sender is idle.
Patch by amitkapila on 2012-10-04: Updated Patch Version-3 as per Heikki's comments.
Committed Amit Kapila Heikki Linnakangas 2012-10-11
[04] Add embedded list interface (header only)
Review by rhaas on 2012-06-28: Some cosmetic issues to fix.
Patch by andresfreund on 2012-06-28: Updated patch hopefully fixing the issues found.
Patch by alvherre on 2012-10-10: Updated version, fixing the outstanding issues.
Committed Andres Freund Peter Geoghegan, Robert Haas 2012-10-17
Reworks for generic ALTER commands
Patch by kaigai on 2012-09-10: split the original one into three portion according to Robert's comment.
Patch by alvherre on 2012-10-10: One piece remains
Comment by alvherre on 2012-10-17: Marking as committed because 2/3 of the patch were; the remaining piece should be submitted to the next CF.
Committed KaiGai Kohei Álvaro Herrera 2012-10-17
pg_dump: Sort overloaded functions in deterministic order
Review by jwieland on 2012-09-27: Review, only one stylistic issue
Patch by joeljacobson on 2012-10-10: Fixed stylistic issue
Review by jwieland on 2012-10-17: Looks good now. Marking ready for committer.
Committed Joel Jacobson Joachim Wieland 2012-10-18
Extend argument of OAT_POST_CREATE
Patch by kaigai on 2012-09-10: Initial version.
Patch by kaigai on 2012-10-16: updated patch according to Alvaro's suggestion.
Committed KaiGai Kohei Nobody 2012-10-23

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Add hooks for pre- and post-processor executables for COPY and \copy
Patch by efujita on 2012-09-18: Initial version.
Returned with Feedback Etsuro Fujita Nobody 2012-09-20
WIP checksums patch
Patch by jdavis on 2012-09-15: Initial version.
Returned with Feedback Simon Riggs, Jeff Davis Nobody 2012-10-09
sortsupport for text
Patch by rhaas on 2012-03-02: Initial version.
Comment by sternocera on 2012-06-19: I'd like us to find a way to shoehorn the use of strxfrm() into this patch.
Comment by pgeoghegan on 2012-10-08: Can we please wrap this one up?
Returned with Feedback Robert Haas Peter Geoghegan 2012-10-09
Identity projection
Patch by horiguti on 2012-09-14: Initial version. I'll consider on this patch further and post next version.
Returned with Feedback Kyotaro Horiguchi Nobody 2012-10-17
Reduce palloc's in numeric operations.
Patch by horiguti on 2012-09-14: Initial version.
Review by heikki on 2012-09-19: Small amount of work needed.
Returned with Feedback Kyotaro Horiguchi Heikki Linnakangas 2012-10-17
BUG #6412: psql & fe-connect truncate passwords
Patch by rhaas on 2012-09-06: Initial version.
Review by heikki on 2012-09-20: Needs a little bit of work
Returned with Feedback Andy Grimm Heikki Linnakangas 2012-10-17
[06] Add support for a generic wal reading facility dubbed XLogReader
Review by heikki on 2012-06-18: Should refactor ReadRecord to use the new API.
Patch by andresfreund on 2012-08-02: Patch v2 addressing some/most of the review from Heikki and rebasing it after the recent xlog refactoring.
Patch by alvherre on 2012-10-10: Latest version from Heikki
Returned with Feedback Andres Freund Heikki Linnakangas 2012-10-18
pgbench - aggregation of info written into log
Patch by fuzzycz on 2012-08-24: Initial version.
Patch by fuzzycz on 2012-09-20: updated version of the patch - there are two things to fix right now (timestamps windows and handling the last interval)
Review by okbobcz on 2012-10-04: there are some issues still
Returned with Feedback Tomas Vondra Pavel Stehule 2012-10-18
dropping multiple tables in a transaction
Patch by fuzzycz on 2012-08-24: Initial version.
Review by hanada on 2012-10-17: It seems reasonable, but it needs some refactoring such as avoiding code duplicate.
Returned with Feedback Tomas Vondra Shigeru Hanada 2012-10-18
xlog filename formatting functions in recovery
Patch by fdr on 2012-07-03: Initial version.
Comment by heikki on 2012-09-21: Need to decide which tli to report
Returned with Feedback Daniel Farina Heikki Linnakangas 2012-10-18
pg_stat_lwlocks view - lwlocks statistics
Patch by snaga on 2012-10-13: The 2nd patch.
Fixed to support local and global (shared) statistics in the same system view.
Fixed to collect global statistics via pgstat collector process.
Fixed to split PgStat_GlobalStats for different uses, BgWriter stats and LWLock stats.
Patch by snaga on 2012-10-13: Fixed wrong array indexes.
Review by masaofujii on 2012-10-13: The patch causes measurable performance overhead. Needs mechanism to avoid that.
Returned with Feedback Satoshi Nagayasu Fujii Masao 2012-10-23
New statistics for WAL buffer dirty writes
Review by jjanes on 2012-08-11: Needs documentation.
Probably needs function to show reset time.
Is it OK for counts not to survive a restart?
Patch by snaga on 2012-09-25: Revised to use the stat collector process instead of writing shared memory directly. So, the statistics could be kept on restart, and could be reset by pg_stat_reset_shared('walwriter').
Review by alvherre on 2012-10-23: some remaining items
Returned with Feedback Satoshi Nagayasu Jeff Janes 2012-10-23
Visual Studio 2012 build support
Review by nmisch on 2012-10-02: Functionally flawless. Add/fix some comments; doc changes to consider
Review by nmisch on 2012-10-08: Problems for a 32-bit build
Review by nmisch on 2012-10-23: In an NLS build, IsoLocaleName() needs to account for a CRT internals change
Returned with Feedback Brar Piening Noah Misch 2012-10-23
pgbench - custom logging step, estimate of remaining time
Patch by fuzzycz on 2012-09-16: Initial version.
Review by alvherre on 2012-10-23: a command line switch seems awkward to use
Returned with Feedback Tomas Vondra Pavel Stehule 2012-10-23
Array ELEMENT Foreign Keys
Patch by mnencia on 2012-10-10: Refreshed patch, loose ends fixed
Patch by tgl on 2012-10-24: v3 patch, still very much WIP
Review by tgl on 2012-10-24: I think we can't commit without some solution for this performance issue.
Returned with Feedback Marco Nenciarini, Gabriele Bartolini, Gianni Ciolli Rafal Pietrak, Noah Misch 2012-10-24
wal decoding, attempt #2
Review by pgeoghegan on 2012-10-10: My initial thoughts on this patch.
Comment by pgeoghegan on 2012-10-18: New design document from Andres concerning the snapshot building aspect of the patch
Review by pgeoghegan on 2012-10-19: Further review focused on the snapshot building aspect of the patch.
Returned with Feedback Andres Freund Peter Geoghegan 2012-10-25
copy result to psql variables
Patch by okbobcz on 2012-10-17: fixed bug FETCH_COUNT=1 case.
Review by phils on 2012-10-24: Overall +1. Couple a points that I laid out in email.
Review by alvherre on 2012-10-25: avoid touching the lexer
Returned with Feedback Pavel Stehule Shigeru Hanada 2012-10-25
Performance Improvement by reducing WAL for Update Operation
Review by nmisch on 2012-10-25: CPU-bound performance numbers: LZ has a nontrivial penalty, delta encoding is OK
Patch by nmisch on 2012-10-26: v3 of delta encoding variant
Review by nmisch on 2012-10-26: Latest version does not address all prior review comments. Some new bugs.
Returned with Feedback Amit Kapila Noah Misch, Heikki Linnakangas 2012-10-26
Performance Improvement in Buffer Management for Select operation
Patch by amitkapila on 2012-09-11: Initial version.
Returned with Feedback Amit Kapila Nobody 2012-10-29
FOR KEY SHARE foreign keys
Patch by alvherre on 2012-08-31: v21
Patch by alvherre on 2012-10-18: v22
Comment by andresfreund on 2012-10-26: First round of code review
Returned with Feedback Álvaro Herrera Simon Riggs, Andres Freund 2012-11-05

Rejected Patches

Patch Name Status Author Reviewers Date Closed
remove canceled entries from FsyncRequest queue
Patch by jjanes on 2012-07-15: Initial version.
Comment by tgl on 2012-07-19: Fixed in another way in HEAD and 9.2, per subsequent discussion.
Rejected Jeff Janes Tom Lane, Robert Haas 2012-07-19
psql boolean display
Patch by phils on 2012-08-19: Initial version.
Rejected Phil Sorber Pavel Stehule 2012-09-20
shared variables
Patch by okbobcz on 2012-08-14: Initial version.
Rejected Pavel Stehule Heikki Linnakangas 2012-09-24
Libxml2 load error on Windows
Patch by talha bin rizwan on 2012-06-28: Initial version.
Review by nmisch on 2012-10-08: Made obsolete by commit 470d0b9789981bc91a8ef2654911d80ab6a6be57
Rejected Talha Bin Rizwan Noah Misch 2012-10-08
support INSERT INTO...RETURNING with partitioned table using rule
Comment by johnlumby on 2012-07-05: Please also see this follow-up posting
Comment by johnlumby on 2012-07-05: Please also see this follow-up posting
Comment by tgl on 2012-09-20: Not very impressed with this proposal ...
Rejected John Lumby Nobody 2012-10-23