Log In - Home Page

CommitFest 2012-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 35, Returned with Feedback: 26, Rejected: 8. Total: 69.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
Mark textanycat/quote_literal/quote_nullable functions as stable
Patch by intgr on 2012-02-08: Initial version.
Committed Marti Raudsepp Nobody 2012-02-08
PL/pgSQL leaking memory when stringifying datums
Patch by wulczer on 2012-02-07: Initial version.
Committed Jan Urbański Andres Freund 2012-02-11
psql: fix indent for inherited tables names in translated UTF-8 output
Patch by seb on 2012-02-28: Initial version.
Committed Sergey Burladyan Tom Lane 2012-03-08
PL/Python long-lived allocations in datum->dict transformation
Patch by wulczer on 2012-02-07: Initial version.
Committed Jan Urbański Tom Lane 2012-03-13
Update documentation wrt visibility map/index-only scans
Patch by intgr on 2012-03-16: Initial version.
Committed Marti Raudsepp Nobody 2012-03-21
pg_upgrade incorrectly equates pg_default and database tablespace
Patch by jdavis on 2012-04-07: Initial version by Ants Aasma.
Committed Ants Aasma Jeff Davis 2012-04-10
psql: tab completions for 'WITH'
Patch by schmiddy on 2012-04-05: Initial version.
Comment by tgl on 2012-04-10: basic bug fix is committed, the rest needs some work
Patch by schmiddy on 2012-04-12: Fixed completion for ALTER/CREATE ROLE rolename WITH
Committed Josh Kupershmidt Nobody 2012-04-18
unlink for DROPs after releasing locks
Patch by nmisch on 2012-06-10: Initial version.
Committed Noah Misch Robert Haas 2012-06-14
pg_is_in_backup() backup control function
Patch by darold on 2012-05-15: Version 4 of the patches that keep lines under 80 characters
Patch by mnencia on 2012-06-14: Rebased on curred head
Review by gbartolini on 2012-06-14: Tested again against current master. It works fine with me and it is ready for commit.
Committed Gilles Darold Gabriele Bartolini 2012-06-14
\conninfo and SSL
Patch by rhaas on 2012-06-06: Initial version.
Committed Alastair Turner Robert Haas 2012-06-14
pg_restore logging inconsistency
Patch by schmiddy on 2012-06-11: Initial version.
Committed Josh Kupershmidt Joachim Wieland 2012-06-19
pgbench with foreign key constraints
Patch by jjanes on 2012-05-13: Initial version.
Committed Jeff Janes Tom Lane 2012-06-19
Optimize referential integrity checks
Patch by glaucous on 2012-02-13: Initial version.
Review by deanr on 2012-06-16: Looks good
Comment by tgl on 2012-06-17: Hmm, I think we have some spec compliance issues here ...
Committed Vik Reykja Dean Rasheed 2012-06-20
Resource Owner reassign Locks for the sake of pg_dump
Patch by jjanes on 2012-06-10: Initial version.
Patch by heikki on 2012-06-18: Refactored patch. Waiting for Jeff/Amit to review it before commit.
Committed Jeff Janes Heikki Linnakangas 2012-06-21
WAL format changes
Patch by heikki on 2012-06-14: Initial version.
Comment by andresfreund on 2012-06-18: Needs rebasing to compile with current head
Committed Heikki Linnakangas Andres Freund 2012-06-24
avoid heavyweight locking on hash metapage
Patch by rhaas on 2012-05-30: Initial version.
Review by jjanes on 2012-06-16: Is it really deadlock free? And if so, is it in a future proof way?
Committed Robert Haas Jeff Janes 2012-06-26
measuring spinning
Patch by rhaas on 2012-06-14: Initial version.
Review by jjanes on 2012-06-16: Needs a short comment to clarify what it does.
Committed Robert Haas Jeff Janes 2012-06-26
pg_terminate_backend by not administrator user
Patch by fdr on 2012-03-21: Initial version.
Review by jdavis on 2012-03-26: Minor doc update required, otherwise ready.
Patch by jdavis on 2012-03-29: Updated patch by author
Committed Daniel Farina Jeff Davis 2012-06-26
Improve the DROP FUNCTION hint message
Patch by deanr on 2012-06-09: Initial version.
Committed Dean Rasheed Robert Haas 2012-06-26
Adjust commit_delay to only occur within group commit leader backend
Patch by sternocera on 2012-06-08: Initial version.
Comment by sternocera on 2012-06-08: I feel that we should change the name of commit_delay in light of this change. What that new name actually is seems less important.
Review by rhaas on 2012-06-27: Review.
Committed Peter Geoghegan Robert Haas 2012-07-02
Overhaul walsender wakeup handling
Patch by andresfreund on 2012-06-13: Initial version.
Patch by andresfreund on 2012-06-27: v2, rebased and addressing the comments from Robert.
Committed Andres Freund Robert Haas 2012-07-02
Conversion from pg_wchar to multibyte
Patch by smagen on 2012-05-24: Conversion from pg_wchar to mule is fixed
Review by rhaas on 2012-06-27: I think UTF8 and MULE need more work.
Patch by smagen on 2012-07-01: UTF8 fixed, MULE needs some more discussion
Committed Alexander Korotkov Robert Haas 2012-07-04
Provide fallback_application_name in contrib/pgbench, oid2name, and dblink
Patch by amitkapila on 2012-06-14: Initial version.
Comment by amitkapila on 2012-06-14: This patch is based on Todo Item:
Provide fallback_application_name in contrib/pgbench, oid2name, and dblink.
This is to ensure that fallback_application_name will be provided with above mentioned applications.
Committed Amit Kapila Shigeru Hanada 2012-07-04
Improve tab completion of function arguments
Patch by deanr on 2012-06-13: Initial version.
Review by schmiddy on 2012-06-18: Review of Dean's patch, and a small fix for function visibility test
Committed Dean Rasheed Josh Kupershmidt 2012-07-05
Pl/perl fix utf8isims when on SQL_ASCII
Patch by alexhunsaker on 2012-02-20: Initial version.
Patch by horiguti on 2012-07-03: Reviews patch and additional regression test set.
Committed Alex Hunsaker Kyotaro Horiguchi 2012-07-10
Support for array_remove and array_replace functions
Patch by mnencia on 2012-06-14: Initial version.
Review by alexhunsaker on 2012-06-30: looks good, new patch with minor cleanups
Patch by mnencia on 2012-07-01: new patch with minor fixes. Should be ready for committer eyes.
Committed Marco Nenciarini, Gabriele Bartolini Alex Hunsaker 2012-07-11
Selective binary conversion of CSV file foreign tables
Review by kaigai on 2012-06-19: needs patch rebase, and a few comments
Patch by efujita on 2012-06-21: Rebased to current head. bug fix and minor optimization.
Patch by efujita on 2012-06-26: Updated version fixing some bugs by Kaigai-san and me.
Committed Etsuro Fujita KaiGai Kohei 2012-07-12
initdb fsync
Review by andresfreund on 2012-06-18: quick code review, some suggestions/ideas nothing critical.
Patch by jdavis on 2012-06-18: Respond to review.
Patch by jdavis on 2012-06-18: Change back to using -N during regression, per Peter's comments.
Committed Jeff Davis Andres Freund 2012-07-13
Reporting WAL file containing checkpoint's REDO record in pg_controldata's result
Patch by MasaoFujii on 2012-03-28: Initial version.
Patch by MasaoFujii on 2012-06-26: Updated version
Committed Fujii Masao Nobody 2012-07-14
Common SIGALRM framework and lock_timeout
Patch by zboszor on 2012-06-20: All the requested tweaks applied.
Patch by zboszor on 2012-06-27: Added registration interface for timeout sources
Patch by tgl on 2012-07-12: Revised version of infrastructure patch.
Committed Zoltán Böszörményi Marc Cousin, Tom Lane 2012-07-17
Event Triggers Reduced
Patch by dim on 2012-07-11: Patch v9, seems like about the last round of review (polishing) :)
Patch by dim on 2012-07-12: Patch v10, fix a hash table key to being char[] rather than NameData.
Review by rhaas on 2012-07-20: Mostly committed.
Committed Dimitri Fontaine Robert Haas 2012-07-20
Rearrange and cross-reference notes on sequences and rollback exemption (Partially committed)
Patch by ringerc on 2012-08-03: Initial version.
Patch by ringerc on 2012-08-04: Correct editing error pointed out by Kevin
Review by ringerc on 2012-08-23: Robert Haas edited and selectively committed
Committed Craig Ringer Kevin Grittner, Robert Haas 2012-08-07
Ability to listen on more unix sockets
Patch by hhorak on 2012-06-15: Enhanced version, which doesn't allow port number in the first socket entry.
Review by tgl on 2012-07-02: There's nothing fundamentally wrong with this patch, but it could be implemented more cleanly.
Patch by hhorak on 2012-07-12: This is an enhanced patch with most of the Tom's comments from 07/02/12 implemented and with alternate-port-number support removed, as per Tom's e-mail from 07/03/12. It can be add in the future, if we really need it.
Committed Honza Horak Tom Lane 2012-08-10
SP-GiST for ranges based on 2d-mapping and quad-tree
Patch by rhaas on 2012-07-23: latest patch version from author
Review by heikki on 2012-08-16: Committed most of the patch. Adjacent-support still awaiting commit.
Comment by rhaas on 2012-08-20: please add adjacent-support patch to next CF as needed
Committed Alexander Korotkov Jeff Davis, Heikki Linnakangas 2012-08-20
Make sure mvcc.sgml documents transactional oddities like SEQUENCEs (patch 1/3)
Patch by ringerc on 2012-08-20: Initial version.
Patch by ringerc on 2012-08-20: Archiver mangled the first post. Re-posted with patches inline.
Review by ringerc on 2012-08-23: First patch merged by Robert Haas. Second in series will be moved to new entry.
Committed Craig Ringer Robert Haas 2012-08-23

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
smart shutdown at end of transaction
Patch by rhaas on 2012-04-27: Initial version.
Returned with Feedback Robert Haas Nobody 2012-06-07
ECPG FETCH readahead
Patch by zboszor on 2012-03-29: Fixed some cosmetic points, explained policy
Patch by zboszor on 2012-03-30: No 0-vs-1 distinction in the runtime. Less MOVEs. Documentation updates.
New 2nd patch without NO READAHEAD and modified docs.
Comment by meskes on 2012-04-24: Zoltan himself found a hole and has to redo parts of the patch
Returned with Feedback Zoltán Böszörményi Noah Misch 2012-06-13
autocomple - CREATE OR REPLACE FUNCTION
Patch by okbobcz on 2012-02-20: Initial version.
Review by petere on 2012-04-10: some problems to solve
Returned with Feedback Pavel Stehule Dean Rasheed 2012-06-13
[02][TRIVIAL] Add zeroRecPtr as a shortcut for initializing a local variable to {0, 0}
Patch by andresfreund on 2012-06-13: Initial version.
Review by rhaas on 2012-06-14: Redundant with existing InvalidXLogRecPtr
Returned with Feedback Andres Freund Robert Haas 2012-06-14
[03] Add a new syscache to fetch a pg_class entry via its relfilenode
Patch by andresfreund on 2012-06-13: Initial version.
Review by rhaas on 2012-06-14: Review.
Returned with Feedback Andres Freund Robert Haas 2012-06-14
Foreign keys with arrays
Comment by nmisch on 2012-06-10: No longer applies
Comment by mnencia on 2012-06-14: The patch wil be splitted and summitted to the next commitfest
Comment by mnencia on 2012-08-01: This patch has been abandoned in favour of the new "Array ELEMENT foreign key" patch
Returned with Feedback Marco Nenciarini, Gabriele Bartolini, Gianni Ciolli Noah Misch 2012-06-14
Making truncate MVCC-safe
Patch by jdavis on 2012-04-21: Initial version.
Patch by jdavis on 2012-04-21: New patch from Simon
Comment by nmisch on 2012-06-10: Author doubts
Returned with Feedback Marti Raudsepp, Simon Riggs Robert Haas 2012-06-20
[13] Introduction of pair of logical walreceiver/sender
Patch by andresfreund on 2012-06-13: Initial version.
Comment by andresfreund on 2012-06-29: Decoding/catalog syncing infrastructure isn't far along yet to make this interesting beyond whats already done so far.
Returned with Feedback Andres Freund Alexander Korotkov 2012-06-29
[15] Activate/Implement the "apply process" which applies received updates from another node
Patch by andresfreund on 2012-06-13: Initial version.
Comment by andresfreund on 2012-06-29: At this point it doesn't seem important to review this patch. Other things need to be decided beforehand.
Returned with Feedback Andres Freund Nobody 2012-06-29
Add SPI_gettypmod() to return a field's typemod from a TupleDesc
Patch by chetan on 2012-02-08: now uses the recommended name SPI_gettypmod().
Review by amitkapila on 2012-06-18: Documentation needs to be updated.
Comment by rhaas on 2012-06-28: ping
Returned with Feedback Chetan Suttraway Amit Kapila 2012-07-03
Prevent the specification of conflicting transaction read/write options
Patch by chetan on 2012-02-08: Initial version.
Review by amitkapila on 2012-06-18: Test regression needs to updated and the code needs to be changed for review comments.
Returned with Feedback Chetan Suttraway Amit Kapila 2012-07-03
relation metapages
Patch by rhaas on 2012-06-14: Initial version.
Review by aevernon on 2012-07-01: Does not apply cleanly to current Git master.
Returned with Feedback Robert Haas Albert Vernon 2012-07-16
[10] Introduce the concept that wal has a 'origin' node
Patch by andresfreund on 2012-06-13: Updated patch fixing a stupid mismerge.
Review by ssinger on 2012-06-18: Some naming suggestions, a places code from a later patch was included in this one
Comment by andresfreund on 2012-06-18: New version of patch in git-tree, addressed most comments in review (except configuration variable naming, it seems to be to early to settle on anything at this point ;))
Returned with Feedback Andres Freund Steve Singer, Simon Riggs 2012-07-17
[11] Add infrastructure for manipulating multiple streams of wal on a segment handling level
Patch by andresfreund on 2012-06-13: Initial version.
Review by zboszor on 2012-06-29: Doesn't apply cleanly to current GIT.
Returned with Feedback Andres Freund Nobody 2012-07-20
[14] Add module to apply changes from an apply-cache using low-level functions
Patch by andresfreund on 2012-06-13: Initial version.
Review by smagen on 2012-07-01: Review
Returned with Feedback Andres Freund Alexander Korotkov 2012-07-20
Allow CREATE FOREIGN TABLE to take LIKE
Patch by dfetter on 2012-03-28: Initial version.
Comment by deanr on 2012-06-23: Some review comments from Thom, Alvaro and me. Needs some doc additions. Should use RELKIND #defines instead of char literals. Supported like_options need a bit of work.
Returned with Feedback David Fetter Dean Rasheed 2012-07-20
transforms
Patch by petere on 2012-06-14: Initial version.
Review by andresfreund on 2012-06-18: a first review while reading the patch to get an idea what it actually does
Patch by rhaas on 2012-07-20: new patch, but petere says this won't be done this CF
Returned with Feedback Peter Eisentraut Andres Freund 2012-07-20
pgsql_fdw contrib module
Patch by hanada on 2012-04-07: v20 patch, use libpq row processor API, and support ANALYZE.
Patch by hanada on 2012-06-14: Rebased for 9.3, with some fixes.
Review by kaigai on 2012-06-26: This patch has many improvements from the previous commit fest, but still some problems are remained.
Returned with Feedback Hanada Shigeru KaiGai Kohei, Laurenz Albe 2012-07-20
pg_prewarm
Patch by rhaas on 2012-04-09: v2, with documentation improvements.
Review by jjanes on 2012-07-07: review
Review by singh.gurjeet on 2012-08-21: Review of the code implementation.
Returned with Feedback Robert Haas singh.gurjeet, Jeff Janes 2012-07-20
autocomplete SELECT fx
Comment by petere on 2012-04-10: There was some debate about this.
Review by schmiddy on 2012-06-19: Review of Pavel's and Peter's overlapping patches. Some small technical issues in Peter's patch, plus the debate Peter noted.
Comment by schmiddy on 2012-07-23: Peter not satisfied with function autocomplete.
Returned with Feedback Pavel Stehule, Peter Eisentraut Josh Kupershmidt 2012-07-23
Allow breaking out of hung connection attempts
Review by hanada on 2012-07-10: Need to resolve CPU consumption issue.
Patch by jjanes on 2012-07-13: linking v6 patch into commitfest app
Review by heikki on 2012-07-18: A couple of issues remain
Returned with Feedback Ryan Kelly Shigeru Hanada, Heikki Linnakangas 2012-07-23
[08] Introduce the ApplyCache module which can reassemble transactions from a stream of interspersed changes
Patch by andresfreund on 2012-06-13: Initial version.
Review by ssinger on 2012-06-21: design review covering options on how transactions can be grouped for apply
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
[09] Decode wal (with wal_level=logical) into changes in an ApplyCache instance
Patch by andresfreund on 2012-06-13: Initial version.
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
[12] Add state to keep track of logical replication
Patch by andresfreund on 2012-06-13: Initial version.
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
[07] Log enough data into the wal to reconstruct logical changes from it if wal_level=logical
Patch by andresfreund on 2012-06-20: Initial version.
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
FOR KEY SHARE
Patch by alvherre on 2012-06-25: v14 fixes the make failures and merges to current master
Patch by jjanes on 2012-07-13: update commit fest app to newest v17 patch
Comment by rhaas on 2012-08-20: already added to next CF
Returned with Feedback Álvaro Herrera Kevin Grittner 2012-08-20

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Optimize IS DISTINCT FROM NULL => IS NOT NULL
Patch by intgr on 2012-03-08: Initial version.
Review by intgr on 2012-03-09: Tom thinks we should keep this simple
Rejected Marti Raudsepp Tom Lane 2012-03-08
Fix little typo in a comment in contrib/file_fdw
Patch by efujita on 2012-04-11: Initial version.
Comment by schmiddy on 2012-04-21: Tom says fine as-is
Rejected Etsuro Fujita Tom Lane 2012-04-11
pgbench new transaction type
Patch by gsmith on 2011-06-13: Initial version.
Review by gsmith on 2011-06-19: Performance confirmed, needs docs and some adjustments
Patch by jjanes on 2012-06-14: updated patch
Rejected Jeff Janes Greg Smith, Heikki Linnakangas 2012-06-20
Make checkpointer look checkpoint_segments on standbys
Patch by horiguti on 2012-06-08: Initial version.
Rejected Kyotaro Horiguchi Greg Smith, Simon Riggs 2012-06-29
Lazy hashaggregate when no aggregation is needed
Patch by antsaasma on 2012-03-28: Initial version.
Comment by rhaas on 2012-06-26: ping
Rejected Ants Aasma Etsuro Fujita 2012-07-02
Restrict ALTER FUNCTION CALLED ON NULL INPUT
Patch by nmisch on 2012-06-11: Initial version.
Review by rhaas on 2012-07-20: no consensus on this approach; further discussion of what to do
Rejected Noah Misch Tom Lane 2012-07-20
Add value_to_json(anyelement) to allow conversion/escaping of scalars to JSON
Patch by ringerc on 2012-08-13: Initial version.
Review by ringerc on 2012-08-13: Bounced; the `json' type isn't supposed to ever have SQL-visible scalar values.
Rejected Craig Ringer Tom Lane 2012-08-13
NOT NULL violation error handling in file_fdw
Patch by efujita on 2012-04-18: fix a bug in fileGetOptions(), rename the validation option and clean up
Patch by jjanes on 2012-07-13: link v4 of patch into commitfest app
Comment by rhaas on 2012-08-20: there is no consensus that we want this; both tgl and I have expressed reservations
Rejected Etsuro Fujita Dimitri Fontaine 2012-08-20