Log In - Home Page

CommitFest 2011-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 31, Returned with Feedback: 20, Rejected: 2. Total: 53.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
PQconnectdbParams keywords and values args "const char *const*"
Patch by lmamane on 2011-09-21: Initial version.
Patch by lmamane on 2011-09-21: Revised patch to use "const char *const * " instead of "char const* const*", as per comments on bug list, and as per existing use in that file for paramValues arg of PQexecParams and friends.
Committed Lionel Elie Mamane Craig Ringer 2011-09-25
Document DELETE/UPDATE command tag vs triggers
Patch by intgr on 2011-09-25: Initial version.
Committed Marti Raudsepp Robert Haas 2011-10-10
EXECUTE tab completion
Patch by doublehyphen on 2011-10-01: Initial version.
Patch by doublehyphen on 2011-10-20: Updated to fit head.
Committed Andreas Karlsson Josh Kupershmidt 2011-10-23
Don't allow join removal for deferrable unique constraints
Patch by intgr on 2011-10-19: Initial version.
Patch by tgl on 2011-10-23: Committed a greatly simplified version, per Robert's comments.
Committed Marti Raudsepp Robert Haas 2011-10-23
Don't treat a superuser as a member of every group for hba.
Patch by adunstan on 2011-11-02: Initial version.
Committed Andrew Dunstan Robert Haas 2011-11-03
remove hstore's =>(text, text)
Patch by rhaas on 2011-11-02: Initial version.
Comment by rhaas on 2011-11-02: Motivation for this change is that the SQL standard defines an incompatible meaning for =>
Committed Robert Haas Dimitri Fontaine, David Wheeler, Tom Lane 2011-11-08
make psql retain blank lines within commands in history
Patch by rhaas on 2011-11-14: Initial version.
Committed Robert Haas Nobody 2011-11-18
Add permission check on SELECT INTO
Patch by kaigai on 2011-11-02: Initial version.
Review by laurenz on 2011-11-18: Error message is bad and probably indicates a code problem. Regression test does not test functionality.
Patch by kaigai on 2011-11-19: Bug fix, and revised test cases
Committed KaiGai Kohei Laurenz Albe 2011-11-22
Out of band storage for PGPROC members
Comment by rhaas on 2011-11-18: Performance test results.
Patch by rhaas on 2011-11-22: New version with more cleanup, and a question about GetSnapshotData().
Comment by kgrittn on 2011-11-24: Some benchmarks on 32-core Intel box.
Committed Pavan Deolasee Heikki Linnakangas, Robert Haas 2011-11-25
Displaying accumulated autovacuum cost
Patch by gsmith on 2011-11-16: Initial version.
Committed Noah Misch and Greg Smith Álvaro Herrera 2011-11-25
plperl verify utf8 strings
Patch by alexhunsaker on 2011-10-07: Initial version.
Review by alexhunsaker on 2011-10-07: review
Committed Alex Hunsaker Amit Khandekar 2011-11-26
Perl xsubpp from cpan
Patch by alexhunsaker on 2011-11-03: Initial version.
Patch by alexhunsaker on 2011-11-03: v3, assorted fixes
Committed David E. Wheeler Alex Hunsaker 2011-11-26
Disable SSL compression
Patch by laurenz on 2011-11-15: Initial version.
Patch by laurenz on 2011-11-17: Fixed a bug and improved documentation.
Comment by mha on 2011-11-28: Committed.
Committed Laurenz Albe Magnus Hagander 2011-11-28
Include detailed information about a row failing a CHECK constraint into the error message
Patch by jkt on 2011-11-09: Initial version.
Patch by jkt on 2011-11-10: Updated patch which trims each printed column to at most 64 characters to prevent huge error messages on tables with big data.
Review by royce on 2011-11-16: Regression tests need updating, some minor comments on the DETAIL line's format. Otherwise good.
Committed Jan Kundrát (jkt) Royce Ausburn 2011-11-29
Make the handling of invalid-page table safer
Patch by MasaoFujii on 2011-10-11: Initial version.
Committed Fujii Masao Heikki Linnakangas 2011-12-02
setenv builtin command for psql
Patch by adunstan on 2011-11-02: Initial version.
Review by schmiddy on 2011-11-21: Review of v2 patch
Patch by adunstan on 2011-11-26: revised patch to deal with reviewer comments.
Committed Andrew Dunstan Josh Kupershmidt 2011-12-04
PL/Python using SPI cursors
Review by ssinger on 2011-11-20: I found a few bugs that need to be addressed.
Patch by wulczer on 2011-11-23: v2 with the bugs hopefully fixed
Review by ssinger on 2011-11-26: Revised version of the patch seems fine
Committed Jan Urbański Steve Singer 2011-12-05
allow src/tools/scripts to work w/no postgres database
Patch by rhaas on 2011-11-13: Initial version.
Review by mha on 2011-12-06: Another review (one or more in the thread before that too)
Committed Robert Haas Bruce Momjian, Magnus Hagander 2011-12-06
Cancel query if the connection is lost
Patch by fgp on 2011-10-17: Initial version.
Comment by fgp on 2011-10-17: Originally meant to prevent a walsender process from lingering indefinitely if archive_mode=on but no archive_command is set (or fails indefinitely) and pg_basebackup is cancelled while it waits for pg_stop_backup() to suceed. The patch is more general than that, though, and cancelles any query if the client connection vanishes. That detection only works if we actually attempt to send something, e.g. a NOTICE, though.
Comment by gregj on 2011-10-19: So I looked at the patch, and first thing that pops out, is lack of the volatile keyword before the ClientConnectionLostPending variable is defined.

I haven't tested the code, just reviewed the patch itself.
Committed Florian Pflug Greg Jaskiewicz, Heikki Linnakangas 2011-12-09
cursor calling with named parameters
Review by kgrittn on 2011-12-03: Overall good. A few minor points to fix.
Patch by yhavinga on 2011-12-11: Added mixed notation.
Review by kgrittn on 2011-12-12: All concerns addressed.
Committed Yeb Havinga Kevin Grittner 2011-12-14
exclude-table-data option for pg_dump
Review by aglio on 2011-11-03: Functional Review
Review by mha on 2011-12-06: Newer review, with comments
Patch by adunstan on 2011-12-12: Documentation updated per comments from rhaas.
Committed Andrew Dunstan Peter Geoghegan 2011-12-14
includeifexists in configuration file
Patch by gsmith on 2011-11-16: Initial version.
Patch by gsmith on 2011-12-15: Updated v2 patch, fixes all open suggestions
Committed Greg Smith Euler Taveira de Oliveira 2011-12-15
type privileges
Review by gsmith on 2011-12-10: Additional review questions
Patch by yhavinga on 2011-12-14: Updated patch
Comment by yhavinga on 2011-12-14: No further major points. smallint vs smallint[] in a permission denied remains todo.
Committed Peter Eisentraut Yeb Havinga 2011-12-16
pg_dump switch --section=pre-data|data|post-data
Review by aglio on 2011-12-07: Functionality review from 11/16
Review by gsmith on 2011-12-10: Code formatting/location suggestions, documentation/usage warning suggestions.
Patch by adunstan on 2011-12-12: Revised patch in response to reviewer comments.
Committed Andrew Dunstan Joachim Wieland 2011-12-16
WIP: SP-GiST, Space-Partitioned GiST
Patch by gsmith on 2011-12-16: Updated patch from Tom. Split off discussion about VACUUM issues.
Comment by gsmith on 2011-12-16: VACUUM discussion started here.
Comment by gsmith on 2011-12-16: Second side discussion about index-only scans
Committed Teodor Sigaev, Oleg Bartunov Tom Lane 2011-12-17
splitting plpython into smaller parts
Patch by wulczer on 2011-11-14: Initial version.
Patch by wulczer on 2011-12-05: Rebased against master after the cursors patch landed.
Committed Jan Urbański Peter Eisentraut 2011-12-18
Non-inheritable check constraints
Comment by Nikhils on 2011-10-08: Alex has provided a rebased patch with some more modifications and cleanup. We both feel that it is "Ready for Committer" now.
Patch by alexhunsaker on 2011-10-09: v3
Review by gsmith on 2011-12-10: Initial committer review, question about implementation
Committed Nikhil Sontakke Alex Hunsaker 2011-12-19
Prep object creation hooks
Patch by kaigai on 2011-11-15: Initial version.
Patch by kaigai on 2011-12-02: Revised patches using ProcessUtility / ExecutorStart hook, instead of new hooks
Patch by gsmith on 2011-12-16: Explanations of DDL permissions on creation time added by these patches, added a few regression test cases.
Committed KaiGai Kohei Dimitri Fontaine 2011-12-21
avoid taking two snapshots per query
Patch by rhaas on 2011-11-14: New version: still reduces simple protocol from 2 snapshots to 1; now also reduces extended protocol from 3 snapshots to 2.
Comment by dim on 2011-11-26: more comments needs adjusting.
Comment by rhaas on 2011-12-15: Update.
Committed Robert Haas Dimitri Fontaine 2011-12-21
Fix Leaky Views Problem, again
Patch by rhaas on 2011-12-07: cleaned-up version
Review by rhaas on 2011-12-08: uh-oh. selectivity estimators are a possible attack vector.
Patch by gsmith on 2011-12-19: Updated v8 with selectivity changes
Committed KaiGai Kohei Robert Haas 2011-12-22
Add Support for building with Visual Studio 2010
Comment by adunstan on 2011-12-09: Waiting on rearrangement of code to make it cleaner and more symmetric.
Patch by brar on 2011-12-27: Updated patch - rearranged code as suggested.
Patch by brar on 2012-01-01: Updated patch - Fixed problems in src/include/port/win32.h that prevented postgres built with VS 2010 from connecting.
Committed Brar Piening Craig Ringer 2012-01-03

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Adding CORRESPONDING to Set Operations
Comment by keremkat on 2011-10-19: The referenced message is the first message about this topic. This patch is my first submission.
Patch by keremkat on 2011-10-25: (v3) CORRESPONDING BY column ordering changed to match the standard draft 20nn, thanks to Erik Rijkers
Review by umitanuki on 2011-11-17: Quick review comments. Need to rework in design.
Returned with Feedback Kerem KAT Hitoshi Harada 2011-11-22
DROP/ALTER SET SCHEMA/RENAME TO Refactoring
Comment by rhaas on 2011-11-18: Committed part 1 with minor revisions.
Review by rhaas on 2011-11-18: Not sure parts 2 through 4 are going in the right direction.
Comment by kaigai on 2011-12-01: Another approach may consolidate the code well.
Returned with Feedback KaiGai Kohei Robert Haas 2011-12-01
Foreign keys with arrays
Comment by gbartolini on 2011-11-04: Useful reference: thread started by Peter Eisentraut on hackers
Review by nmisch on 2011-11-17: Various failing test cases, etc.
Comment by gsmith on 2011-12-10: Discussion of feature specification
Returned with Feedback Gabriele Bartolini, Marco Nenciarini Noah Misch 2011-12-10
%TYPE and array declaration
Patch by wmula on 2011-10-23: Initial version.
Review by gsmith on 2011-11-30: Initial review: some bit rot, code suggestions, and concerns over large regression tests.
Comment by gsmith on 2011-12-10: Tom is concerned about the grammar rewrite and overall code impact of the patch.
Returned with Feedback Wojciech Muła Pavel Stehule 2011-12-10
Online base backup from the hot-standby
Patch by Jun Ishizuka on 2011-11-01: Initial version. but this is infrastructure.
Review by ssinger on 2011-11-15: Please post an updated patch with some of the recently committed xlog refactoring merged in
Returned with Feedback Fujii Masao and Jun Ishiduka Steve Singer 2011-12-12
pg_terminate_backend and pg_cancel_backend by not administrator user
Comment by fdr on 2011-11-16: The limited form already posted would still have good value, without extension.
Comment by gsmith on 2011-12-01: More agreement that a simple same-user cancel mechanism is good enough for now.
Comment by pvh on 2011-12-12: Any improvement here will have major operational benefits for non-superuser users who need to be able to forcibly abort in progress statements.
Returned with Feedback Torello Querci Josh Kupershmidt 2011-12-13
Configuration include directory
Review by nmisch on 2011-12-06: Initial review
Patch by gsmith on 2011-12-12: Updated patch to address feedback, add docs.
Review by nmisch on 2011-12-13: Many things now fixed, some remain
Returned with Feedback Magnus Hagander and Greg Smith Noah Misch 2011-12-13
Command Triggers
Comment by gsmith on 2011-12-15: Thoughts on why Command Triggers are not DDL triggers, and the expected scope limit of the approach used.
Comment by gsmith on 2011-12-15: Thoughts on potential Slony use of this feature
Comment by gsmith on 2011-12-15: Suggested improvements for DDL triger like support, followed by descent into ProcessUtility scope.
Returned with Feedback Dimitri Fontaine Andres Freund 2011-12-15
FlexLocks
Comment by kgrittn on 2011-12-01: Confirms fixes and clean apply. Note a few more minor issues missed before.
Review by kgrittn on 2011-12-02: Finished review, including extraWaits and related semaphores. Suggested a few micro-optimizations. Could be "Ready for Committer" if we split modularity issue to a separate patch.
Patch by rhaas on 2011-12-15: Updated patch set... but not going to apply this right now.
Returned with Feedback Robert Haas Kevin Grittner 2011-12-15
Separate pg_stat_activity into current_query into state and query columns
Comment by smead on 2011-11-17: query_start column needs consideration now that state / query are broken apart, telling the difference between how long a query has been in the system and how long we've been 'idle in transaction' for.
Patch by smead on 2011-11-19: * Updated documentation
* Updated regression
* Renamed procpid => pid
* Added state_change (timestamp) to follow
the 'state' column
* Fixed minor bugs
- See message for details
Review by mha on 2011-12-06: Another review, requiring some further changes
Returned with Feedback Scott Mead Magnus Hagander, Greg Smith 2011-12-15
Measuring relation free space
Review by jjanes on 2011-11-26: Reported value needs to be a percentage rather than fraction.
Is the behavior correct for non-BTree index?
Comment by gsmith on 2011-12-15: Summary of issues to work on
Comment by gsmith on 2011-12-19: Detailed notes on crossover with pgstattuple
Returned with Feedback Jaime Casanova and Greg Smith Jeff Janes 2011-12-15
CHECK FUNCTION statement
Review by laurenz on 2011-12-15: crashes on functions defined with a SET clause
Patch by laurenz on 2011-12-15: new patch without "quiet" option, fix for the crash and improvements for SECURITY DEFINER functions
Review by laurenz on 2011-12-16: Bug if CHECK FUNCTION ALL finds no function, oddness about option "fatal_errors"
Returned with Feedback Pavel Stehule Laurenz Albe 2011-12-16
pg_last_xact_insert_timestamp
Comment by tgl on 2011-10-29: Pushing to next commitfest to give time for Simon to give a counterproposal, while not taking this patch off the table.
Review by gsmith on 2011-12-10: Concerns about the accuracy of this data, alternate timestamp driven approach outlined.
Patch by gsmith on 2011-12-15: Alternate implementation using an approach with keepalives from WALsender to WALreceiver.
Returned with Feedback Fujii Masao Kyotaro Horiguchi 2011-12-16
unite recovery.conf and postgresql.conf
Patch by MasaoFujii on 2011-10-11: Updated version
Comment by tgl on 2011-10-29: This is stalled for lack of consensus on how much backwards compatibility we need.
Comment by gsmith on 2011-12-14: Suggestions for a forward path
Returned with Feedback Fujii Masao Nobody 2011-12-16
Tuplesort comparison overhead reduction
Patch by sternocera on 2011-11-23: Added revision of patch
Patch by sternocera on 2011-11-26: Further revision of patch, which manufactures inlining and non-inlining variants
Comment by rhaas on 2011-12-15: Author will rebase.
Returned with Feedback Peter Geoghegan Robert Haas 2011-12-16
GiST for range types improvements
Patch by smagen on 2011-12-02: Rebased with head.
Review by jdavis on 2011-12-12: A few comments and some cleanup.
Patch by gsmith on 2011-12-16: Updated patch with fixes merged
Returned with Feedback Alexander Korotkov Jeff Davis 2011-12-16
Caching constant stable expressions per execution
Patch by gsmith on 2011-12-10: Version 4. Open questions about extending ExecInitExpr.
Patch by gsmith on 2011-12-12: Version 5
Patch by gsmith on 2011-12-16: Performance test case program
Returned with Feedback Marti Raudsepp Jaime Casanova 2011-12-16
Join push-down for foreign tables
Patch by hanada on 2011-11-15: Initial version.
Comment by heikki on 2011-12-02: Ongoing discussion here
Comment by heikki on 2012-01-05: Need to work on the API
Returned with Feedback Shigeru Hanada Heikki Linnakangas 2012-01-05
Collect frequency statistics and selectivity estimation for arrays
Review by nmisch on 2011-12-29: Strategy works, implementation needs refinement
Patch by smagen on 2012-01-09: Revised version of patch
Review by nmisch on 2012-01-12: Close to ready, a few more things to nail down
Returned with Feedback Alexander Korotkov Nathan Boley, Noah Misch 2012-01-12
Allow substitute allocator for PGresult.
Patch by horiguti on 2011-12-08: This is the documentaion.
Review by rhaas on 2011-12-21: A few review comments.
Comment by gsmith on 2012-01-13: Author comments on renaming, PGresAttValue, TupleStore use.
Returned with Feedback Kyotaro Horiguchi Tom Lane 2012-01-14

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Unremovable tuple count on pg_stat_*_tables
Patch by royce on 2011-10-04: Initial version.
Patch by royce on 2011-10-04: Patch version 2
Review by yhavinga on 2011-11-15: In good shape, some bikeshedding about the name 'n_unremovable_tup' and maybe some documentation on n_dead_tup vs n_unremovable_tup could be useful.
Rejected Royce Ausburn Yeb Havinga 2011-11-18
Emacs Lisp facility to add outfuncs/readfuncs support for nodes
Patch by dim on 2011-11-16: Initial version.
Comment by mha on 2011-12-06: Per this note, the tool will live in it's own repository outside pg, thus rejecting this patch.
Rejected Dimitri Fontaine Nobody 2011-12-06