Incorrect handling of OOM in WAL replay leading to data loss

Title

Topic

Bug Fixes

Created

2023-09-26 06:50:13

Last modified

2023-10-24 04:56:34 (1 year ago)

Latest email

2023-10-24 04:56:10 (1 year ago)

Status

2023-11: Withdrawn

Target version

Authors

Michael Paquier (michael-kun)

Reviewers

Committer

Links

Checkout latest CFbot patchset

Go to your local checkout of the PostgreSQL repository and run:

git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/4590
git checkout commitfest/cf/4590

Emails

Incorrect handling of OOM in WAL replay leading to data loss: First at 2023-08-01 03:43:21 by Michael Paquier <michael at paquier.xyz>
Latest at 2023-10-24 04:56:10 by Michael Paquier <michael at paquier.xyz>
Latest attachment (v5-0001-Revert-Fail-hard-on-out-of-memory-failures-in-xlo.patch) at 2023-10-03 07:20:45 from Michael Paquier <michael at paquier.xyz>
    Attachment (v5-0001-Revert-Fail-hard-on-out-of-memory-failures-in-xlo.patch) at 2023-10-03 07:20:45 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (v4-0001-Add-infrastructure-to-report-error-codes-in-WAL-r.patch) at 2023-09-26 06:48:07 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (v3-0001-Add-infrastructure-to-report-error-codes-in-WAL-r.patch) at 2023-08-09 08:44:49 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (v2-0001-Add-infrastructure-to-report-error-codes-in-WAL-r.patch) at 2023-08-09 06:03:21 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (v1-0001-Add-infrastructure-to-report-error-codes-in-WAL-r.patch) at 2023-08-08 07:29:49 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (PoC_continue_record_verification_after_OOM.txt) at 2023-08-02 04:16:02 from Kyotaro Horiguchi <horikyota.ntt at gmail.com> (Patch: Yes)
    Attachment (xlogreader_oom.bash) at 2023-08-01 03:43:21 from Michael Paquier <michael at paquier.xyz> (Patch: No)

History

When	Who	What
2023-10-24 04:56:34	Michael Paquier (michael-kun)	Closed in commitfest 2023-11 with status: Withdrawn
2023-09-26 06:50:24	Michael Paquier (michael-kun)	Changed authors to Michael Paquier (michael-kun)
2023-09-26 06:50:24	Michael Paquier (michael-kun)	Changed targetversion to 17
2023-09-26 06:50:13	Michael Paquier (michael-kun)	Attached mail thread ZMh/WV+CuknqePQQ@paquier.xyz
2023-09-26 06:50:13	Michael Paquier (michael-kun)	Created patch record