Fixes for non-atomic read of read of control file on ext4 + ntfs

Edit
ID 4025
Title Fixes for non-atomic read of read of control file on ext4 + ntfs
Topic Bug Fixes
Created 2022-11-24 21:50:05
Last modified 2024-02-01 18:19:37 (8 months, 2 weeks ago)
Latest email 2024-02-01 18:19:39 (8 months, 2 weeks ago)
Status
2024-01: Returned with feedback
2023-11: Moved to next CF
2023-09: Moved to next CF
2023-07: Moved to next CF
2023-03: Moved to next CF
2023-01: Moved to next CF
Target version
Authors Thomas Munro (macdice)
Reviewers Robert Haas (rhaas), Anton Melnikov (antonmel)Become reviewer
Committer
Links CFbot results (CirrusCI) CFbot GitHub
Checkout latest CFbot patchset Go to your local checkout of the PostgreSQL repository and run:
git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/4025
git checkout commitfest/cf/4025
Emails
odd buildfarm failure - "pg_ctl: control file appears to be corrupt"
First at 2022-11-23 01:42:24 by Andres Freund <andres at anarazel.de>
Latest at 2024-02-01 18:19:39 by vignesh C <vignesh21 at gmail.com>
Latest attachment (v7-0001-Update-control-file-atomically-during-backups.patch) at 2023-10-16 22:45:21 from Thomas Munro <thomas.munro at gmail.com>
    Attachment (v7-0001-Update-control-file-atomically-during-backups.patch) at 2023-10-16 22:45:21 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (alg_level_up.pdf) at 2023-07-30 19:30:50 from "Anton A. Melnikov" <aamelnikov at inbox.ru> (Patch: No)
    Attachment (alg_level_up.pdf) at 2023-07-30 19:22:49 from "Anton A. Melnikov" <aamelnikov at inbox.ru> (Patch: No)
    Attachment (v6-0001-Update-control-file-atomically-during-backups.patch) at 2023-07-26 04:06:31 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (v5-0001-Acquire-ControlFileLock-in-base-backups.patch) at 2023-07-25 00:25:25 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (v4-0001-Acquire-ControlFileLock-in-base-backups.patch) at 2023-07-22 00:51:58 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (v3-0001-Lock-pg_control-while-reading-or-writing.patch) at 2023-03-03 21:39:20 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (0001-Lock-pg_control-while-reading-or-writing.patch) at 2023-02-17 03:21:14 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (0001-Apply-wal_sync_method-to-pg_control-file.patch) at 2023-02-01 06:45:34 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (0001-Lock-pg_control-while-reading-or-writing.patch) at 2023-01-31 11:38:33 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
    Attachment (0001-XXX-Dirty-hack-to-clobber-control-file-for-testing.patch) at 2022-11-24 01:02:54 from Thomas Munro <thomas.munro at gmail.com> (Patch: Yes)
History
When Who What
2024-02-01 18:19:37 vigneshwaran C (vignesh.postgres) Closed in commitfest 2024-01 with status: Returned with feedback
2024-01-11 14:20:37 vigneshwaran C (vignesh.postgres) New status: Waiting on Author
2024-01-05 17:10:34 Robert Haas (rhaas) Added rhaas as reviewer
2023-12-04 08:50:30 John Naylor (john.naylor) Closed in commitfest 2023-11 with status: Moved to next CF
2023-10-02 11:06:35 Peter Eisentraut (petere) Closed in commitfest 2023-09 with status: Moved to next CF
2023-08-01 18:40:47 Daniel Gustafsson (d_gustafsson) Closed in commitfest 2023-07 with status: Moved to next CF
2023-07-26 04:42:56 Thomas Munro (macdice) New status: Needs review
2023-07-22 01:12:27 Thomas Munro (macdice) Changed name to Fixes for non-atomic read of read of control file on ext4 + ntfs
2023-07-20 14:37:24 Daniel Gustafsson (d_gustafsson) New status: Waiting on Author
2023-04-07 12:39:48 Thomas Munro (macdice) Closed in commitfest 2023-03 with status: Moved to next CF
2023-02-17 04:40:20 Anton Melnikov (antonmel) New status: Needs review
2023-01-31 16:34:20 vigneshwaran C (vignesh.postgres) Closed in commitfest 2023-01 with status: Moved to next CF
2023-01-31 01:11:35 Anton Melnikov (antonmel) Added antonmel as reviewer
2023-01-31 01:11:30 Anton Melnikov (antonmel) New status: Waiting on Author
2022-11-24 21:50:12 Thomas Munro (macdice) Changed authors to Thomas Munro (macdice)
2022-11-24 21:50:05 Thomas Munro (macdice) Attached mail thread 20221123014224.xisi44byq3cf5psi@awork3.anarazel.de
2022-11-24 21:50:05 Thomas Munro (macdice) Created patch record
Edit