Incremental sort

Edit
Title Incremental sort
Topic Performance
Created 2017-02-18 10:32:29
Last modified 2017-04-03 22:29:58 (7 years ago)
Latest email 2020-04-08 13:54:42 (4 years ago)
Status
2017-03: Returned with feedback
Target version
Authors Alexander Korotkov (smagen)
Reviewers Heikki Linnakangas (heikki)Become reviewer
Committer
Links
Emails
PoC: Partial sort
First at 2013-12-14 09:59:02 by Alexander Korotkov <aekorotkov at gmail.com>
Latest at 2017-01-31 05:53:05 by Michael Paquier <michael.paquier at gmail.com>
Latest attachment (partial-sort-basic-9.patch) at 2016-09-13 08:32:51 from Alexander Korotkov <aekorotkov at gmail.com>
    Attachment (partial-sort-basic-9.patch) at 2016-09-13 08:32:51 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-basic-8.patch) at 2016-03-30 15:02:06 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-basic-7.patch) at 2016-03-13 17:45:12 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-basic-6.patch) at 2016-03-01 15:06:37 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-basic-5.patch) at 2016-01-24 11:11:00 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (partial-sort-basic-4.patch) at 2015-10-20 11:17:26 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-basic-3.patch) at 2015-10-16 16:11:42 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-basic-2.patch) at 2014-09-13 09:04:00 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-basic-1_rebased.patch) at 2014-08-19 10:02:57 from David Rowley <dgrowleyml at gmail.com> (Patch: Yes)
    Attachment (fix-cost_sort.patch) at 2014-02-12 21:54:08 from Marti Raudsepp <marti at juffo.org> (Patch: Yes)
    Attachment (partial-sort-basic-1.patch.gz) at 2014-02-10 18:59:48 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: No)
    Attachment (partial-sort-7.patch.gz) at 2014-01-27 19:26:39 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: No)
    Attachment (0001-Whitespace-coding-style-fixes.patch) at 2014-01-26 19:03:55 from Marti Raudsepp <marti at juffo.org> (Patch: Yes)
    Attachment (partial-sort-6.patch.gz) at 2014-01-20 12:43:27 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: No)
    Attachment (0001-Partial-sort-skip-comparisons-for-known-equal-column.patch) at 2014-01-18 19:47:39 from Marti Raudsepp <marti at juffo.org> (Patch: Yes)
    Attachment (0001-Batched-sort-skip-comparisons-for-known-equal-column.patch) at 2014-01-18 17:22:50 from Marti Raudsepp <marti at juffo.org> (Patch: Yes)
    Attachment (0001-Add-enable_partialsort-GUC-for-disabling-partial-sor.patch) at 2014-01-13 20:54:42 from Marti Raudsepp <marti at juffo.org> (Patch: Yes)
    Attachment (partial-sort-5.patch.gz) at 2014-01-13 18:01:20 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: No)
    Attachment (partial-sort-4-reset.patch) at 2013-12-31 01:41:32 from Andreas Karlsson <andreas at proxel.se> (Patch: Yes)
    Attachment (partial-sort-4.patch) at 2013-12-28 15:51:01 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-3.patch) at 2013-12-28 08:28:04 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-2.patch) at 2013-12-22 15:38:05 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)
    Attachment (partial-sort-1.patch) at 2013-12-14 09:59:02 from Alexander Korotkov <aekorotkov at gmail.com> (Patch: Yes)

Annotations

When Who Mail Annotation
2015-11-04 01:45:11 Peter Geoghegan (pgeoghegan) From Peter Geoghegan <pg@heroku.com>
at 2015-11-04 01:44:14
Review
2016-03-24 00:41:00 Peter Geoghegan (pgeoghegan) From Peter Geoghegan <pg@heroku.com>
at 2016-03-24 00:39:30
Review of V7, which was built on top of new upper planner pathification stuff
[PATCH] Incremental sort (was: PoC: Partial sort)
First at 2017-02-18 10:31:29 by Alexander Korotkov <a.korotkov at postgrespro.ru>
Latest at 2020-04-08 13:54:42 by James Coleman <jtc331 at gmail.com>
Latest attachment (v1-0001-comment-typos-and-others-Incremental-Sort.patch) at 2020-04-07 04:25:21 from Justin Pryzby <pryzby at telsasoft.com>
    Attachment (v1-0001-comment-typos-and-others-Incremental-Sort.patch) at 2020-04-07 04:25:21 from Justin Pryzby <pryzby at telsasoft.com> (Patch: Yes)
    Attachment (v1-0002-Comment-show_incremental_sort_info-assumtions.patch) at 2020-04-07 00:47:54 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (fix_explain_parallel.patch) at 2020-04-06 21:27:44 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (results-join-v54-i5.ods) at 2020-04-06 19:57:22 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: No)
    Attachment (v54-0001-Consider-low-startup-cost-when-adding-partial-path.patch) at 2020-04-05 13:01:10 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (v53-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-04-03 01:40:45 from James Coleman <jtc331 at gmail.com> (Patch: No)
    Attachment (v52-0003-Consider-incremental-sort-paths-in-additional-pl.patch) at 2020-04-02 12:41:11 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v51-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-04-02 02:09:20 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (run-pgbench.sh) at 2020-04-01 21:42:15 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: No)
    Attachment (v50-0004-add-fast-path-to-partial-path-consideration.patch) at 2020-04-01 13:05:27 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v49-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-04-01 03:07:13 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (perfstat.txt) at 2020-03-31 22:45:37 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: No)
    Attachment (v48-0003-Consider-incremental-sort-paths-in-additional-pl.patch) at 2020-03-31 18:23:15 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (build-indexes.py) at 2020-03-31 01:14:07 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: No)
    Attachment (v47-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-30 22:53:47 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v46-0001-Consider-low-startup-cost-when-adding-partial-path.patch) at 2020-03-30 01:44:42 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (v45-0004-A-couple-more-places-for-incremental-sort.patch) at 2020-03-29 14:21:06 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v44-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-29 02:47:49 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (simplify_useful_pathkeys.txt) at 2020-03-28 22:59:22 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (use_truncate_useless_pathkeys.patch.txt) at 2020-03-28 14:19:04 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v43-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-28 01:36:55 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v42-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-27 16:51:34 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v41-0003-fix-rescan.patch) at 2020-03-25 02:08:54 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v40-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-24 03:13:59 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v39-0001-Consider-low-startup-cost-when-adding-partial-path.patch) at 2020-03-21 00:56:40 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (v38-0004-A-couple-more-places-for-incremental-sort.patch) at 2020-03-15 19:33:51 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (tuplesort-fix.patch) at 2020-03-14 19:58:22 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (updated_aset_bt.txt) at 2020-03-14 18:41:09 from James Coleman <jtc331 at gmail.com> (Patch: No)
    Attachment (assertion_bt.txt) at 2020-03-13 20:31:16 from James Coleman <jtc331 at gmail.com> (Patch: No)
    Attachment (assertion_bt.txt) at 2020-03-13 18:23:10 from James Coleman <jtc331 at gmail.com> (Patch: No)
    Attachment (v37-0004-A-couple-more-places-for-incremental-sort.patch) at 2020-03-13 17:50:25 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v36-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-13 17:16:44 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v35-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-13 17:06:33 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (0001-fix-typo.patch) at 2020-03-12 21:53:11 from Alvaro Herrera <alvherre at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Consider-low-startup-cost-when-adding-parti-20200310.patch) at 2020-03-11 02:43:55 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (v34-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-08 02:07:55 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (v33-0001-Consider-low-startup-cost-when-adding-partial-pa.patch) at 2020-03-07 22:47:00 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (0001-Consider-low-startup-cost-when-adding-partial-pa-v32.patch) at 2019-12-01 00:47:16 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (001-consider-startup-cost-in-add-partial-path_v1.patch) at 2019-09-28 00:31:30 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (incremental-sort-30.patch) at 2019-07-20 14:33:02 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (incremental-sort-cost-debug.patch) at 2019-07-20 13:22:44 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-fix-pathkey-processing-in-generate_gather_p-20190709.patch) at 2019-07-09 12:11:25 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (parallel-incremental-sort-v3.patch) at 2019-07-09 01:44:44 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (0001-fix-pathkey-processing-in-generate_gather_paths.patch) at 2019-07-09 01:37:03 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (bt.txt) at 2019-07-07 21:02:05 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: No)
    Attachment (regression.diffs) at 2019-07-07 13:01:43 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (parallel-incremental-sort-v2.patch) at 2019-07-07 12:34:49 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (incremental-sort-29.patch) at 2019-07-04 13:25:08 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (parallel-incremental-sort.patch) at 2019-06-25 23:22:05 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (incremental-sort-28.patch) at 2019-06-24 12:59:16 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (incremental-sort-27.patch) at 2019-05-31 19:51:57 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (incremental-sort-26.patch) at 2018-05-31 20:11:00 from James Coleman <jtc331 at gmail.com> (Patch: Yes)
    Attachment (incremental-sort-26.patch) at 2018-04-07 16:23:21 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-25.patch) at 2018-04-07 14:10:44 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-24.patch) at 2018-04-07 13:56:07 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-23.patch) at 2018-04-06 20:40:59 from Alexander Kuzmenkov <a.kuzmenkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-v22-review.diff) at 2018-04-06 17:26:23 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (incremental-sort-22.patch) at 2018-04-05 23:43:18 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (0001-comments.patch) at 2018-03-31 20:43:52 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: Yes)
    Attachment (incremental-sort-21.patch) at 2018-03-29 19:13:08 from Alexander Kuzmenkov <a.kuzmenkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-20.patch) at 2018-03-28 15:12:57 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-19.patch) at 2018-03-21 22:49:42 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-18.patch) at 2018-03-20 16:33:42 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (sort-10000.tgz) at 2018-03-07 23:49:39 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: No)
    Attachment (incremental-sort-17.patch) at 2018-03-05 22:07:18 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (plan.txt) at 2018-03-05 10:19:05 from Tomas Vondra <tomas.vondra at 2ndquadrant.com> (Patch: No)
    Attachment (incremental-sort-16.patch) at 2018-03-01 12:23:31 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-15.patch) at 2018-01-08 19:17:55 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-14.patch) at 2018-01-05 08:36:37 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-13.patch) at 2018-01-04 21:36:57 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-12.patch) at 2017-12-08 13:06:45 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-11.patch) at 2017-11-30 21:24:10 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-10.patch) at 2017-11-20 23:34:49 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-9.patch) at 2017-11-14 18:42:27 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (results2.csv) at 2017-10-02 16:37:03 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: No)
    Attachment (incsort_test.py) at 2017-09-15 23:46:05 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: No)
    Attachment (incremental-sort-8.patch) at 2017-09-13 23:48:42 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-7.patch) at 2017-05-05 15:13:42 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-6.patch) at 2017-04-26 15:39:44 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-5.patch) at 2017-04-03 19:03:56 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-4.patch) at 2017-03-29 14:14:51 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-3.patch) at 2017-03-20 09:33:26 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-2.patch) at 2017-02-27 14:59:01 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
    Attachment (incremental-sort-1.patch) at 2017-02-18 10:31:29 from Alexander Korotkov <a.korotkov at postgrespro.ru> (Patch: Yes)
History
When Who What
2017-04-03 22:29:58 Alexander Korotkov (smagen) Closed in commitfest 2017-03 with status: Returned with feedback
2017-04-03 22:29:17 Alexander Korotkov (smagen) Closed in commitfest 2017-03 with status: Rejected
2017-04-03 18:34:08 Andres Freund (andresfreund) Closed in commitfest 2017-03 with status: Returned with feedback
2017-03-30 15:11:11 Alexander Korotkov (smagen) New status: Needs review
2017-03-20 14:41:43 Heikki Linnakangas (heikki) New status: Waiting on Author
2017-03-20 14:41:32 Heikki Linnakangas (heikki) Added heikki as reviewer
2017-02-18 10:33:57 Alexander Korotkov (smagen) Attached mail thread CAPpHfdscOX5an71nHd8WSUH6GNOCf=V7wgDaTXdDd9=goN-gfA@mail.gmail.com
2017-02-18 10:32:39 Alexander Korotkov (smagen) Changed authors to Alexander Korotkov (smagen)
2017-02-18 10:32:29 Alexander Korotkov (smagen) Attached mail thread CAPpHfds1waRZ=NOmueYq0sx1ZSCnt+5QJvizT8ndT2=etZEeAQ@mail.gmail.com
2017-02-18 10:32:29 Alexander Korotkov (smagen) Created patch record
Edit