Transaction traceability - txid_convert_if_recent(bigint)

Edit
ID 748
Title Transaction traceability - txid_convert_if_recent(bigint)
Topic Replication & Recovery
Created 2016-08-29 03:51:33
Last modified 2016-12-28 14:03:48 (7 years, 9 months ago)
Latest email 2017-03-31 17:28:15 (7 years, 6 months ago)
Status
2016-09: Returned with feedback
Target version
Authors Craig Ringer (ringerc)
Reviewers Become reviewer
Committer
Links CFbot results (CirrusCI) CFbot GitHub
Checkout latest CFbot patchset Go to your local checkout of the PostgreSQL repository and run:
git remote add commitfest https://github.com/postgresql-cfbot/postgresql.git
git fetch commitfest cf/748
git checkout commitfest/cf/748
Emails
[PATCH] Transaction traceability - txid_status(bigint)
First at 2016-08-20 13:24:47 by Craig Ringer <craig at 2ndquadrant.com>
Latest at 2017-03-31 17:28:15 by Robert Haas <robertmhaas at gmail.com>
Latest attachment (0002-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2017-03-24 06:27:44 from Craig Ringer <craig at 2ndquadrant.com>
    Attachment (0002-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2017-03-24 06:27:44 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (011_crash_recovery.pl) at 2017-03-23 04:22:23 from Craig Ringer <craig at 2ndquadrant.com> (Patch: No)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2017-03-23 03:25:07 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Fix-race-between-clog-truncation-and-lookup.patch) at 2017-03-22 03:35:12 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Fix-race-between-clog-truncation-and-lookup.patch) at 2017-03-20 05:38:18 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Fix-race-between-clog-truncation-and-lookup.patch) at 2017-01-25 07:02:26 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Fix-race-between-clog-truncation-and-lookup.patch) at 2017-01-25 05:44:04 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Fix-race-between-clog-truncation-and-lookup.patch) at 2017-01-23 06:32:13 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-12-28 10:00:37 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-12-22 05:12:10 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-12-22 01:55:06 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-12-21 08:02:15 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (txid-status-rmh.patch) at 2016-09-20 14:46:39 from Robert Haas <robertmhaas at gmail.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-09-20 01:54:28 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Install-the-Perl-TAP-tests.patch) at 2016-09-16 00:52:17 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-09-02 13:01:58 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-09-02 12:16:53 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-09-01 05:29:50 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-09-01 05:08:45 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-08-29 07:53:34 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Release-SLRU-control-lock-before-reporting-I-O-error.patch) at 2016-08-29 03:25:39 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-txid_status-v3.patch) at 2016-08-23 16:59:35 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-08-23 00:55:00 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-08-20 13:46:55 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)
    Attachment (0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch) at 2016-08-20 13:24:47 from Craig Ringer <craig at 2ndquadrant.com> (Patch: Yes)

Annotations

When Who Mail Annotation
2016-08-29 03:42:06 Craig Ringer (ringerc) From Robert Haas <robertmhaas@gmail.com>
at 2016-08-23 19:10:37
First review by Robert, committed txid_current_if_assigned()
2016-08-29 03:42:31 Craig Ringer (ringerc) From Robert Haas <robertmhaas@gmail.com>
at 2016-08-22 17:03:25
Second review by Robert, comments on txid_status()
2016-08-29 03:42:49 Craig Ringer (ringerc) From Craig Ringer <craig@2ndquadrant.com>
at 2016-08-20 13:24:47
Updated patch addressing review comments
2016-09-02 13:56:03 Craig Ringer (ringerc) From Craig Ringer <craig@2ndquadrant.com>
at 2016-09-02 13:01:58
This patch is wrong, do not use
2016-09-02 13:57:23 Craig Ringer (ringerc) From Craig Ringer <craig@2ndquadrant.com>
at 2016-09-02 12:16:53
Rename get_xid_in_recent_past(...) to TransactionIdInRecentPast(...) and move to xlog.c
2016-09-02 13:57:42 Craig Ringer (ringerc) From Craig Ringer <craig@2ndquadrant.com>
at 2016-09-02 13:46:19
Explain why TransactionIdInRecentPast isn't in transam.c instead
2016-09-16 01:11:30 Craig Ringer (ringerc) From Craig Ringer <craig@2ndquadrant.com>
at 2016-09-16 00:52:17
Ready for a final review
2016-09-29 02:44:57 Craig Ringer (ringerc) From Craig Ringer <craig@2ndquadrant.com>
at 2016-09-27 01:23:21
Robert found a race with oldestXid advance and clog truncation that's not simple to fix, bumping patch down the road for now
2016-12-28 14:03:48 Craig Ringer (ringerc) From Craig Ringer <craig@2ndquadrant.com>
at 2016-12-28 10:00:37
Redesign to close the race Robert identified
History
When Who What
2016-12-28 14:03:48 Craig Ringer (ringerc) Added annotation "Redesign to close the race Robert identified" to CAMsr+YFhw+SSsu7hoXEz6wirjHdUJRbq0pzB1j=w+U8Xe_yLhw@mail.gmail.com
2016-09-29 02:44:57 Craig Ringer (ringerc) Added annotation "Robert found a race with oldestXid advance and clog truncation that's not simple to fix, bumping patch down the road for now" to CAMsr+YHz+nDyqGZSk_SPS2fVTNXbuP_3swJ5DSfpoZCkJ8fE9g@mail.gmail.com
2016-09-29 02:44:01 Craig Ringer (ringerc) Closed in commitfest 2016-09 with status: Returned with feedback
2016-09-16 01:11:30 Craig Ringer (ringerc) Added annotation "Ready for a final review" to CAMsr+YFVOyAqqCpaHNaJTDjZ+5dvPf_0FHLkhFgm4YHU9K84fg@mail.gmail.com
2016-09-02 13:57:42 Craig Ringer (ringerc) Added annotation "Explain why TransactionIdInRecentPast isn't in transam.c instead" to CAMsr+YFCOT8NUdAxs86u_271CaQ2s6eBzMXkNTVpTnEvLW1ABg@mail.gmail.com
2016-09-02 13:57:23 Craig Ringer (ringerc) Added annotation "Rename get_xid_in_recent_past(...) to TransactionIdInRecentPast(...) and move to xlog.c" to CAMsr+YEYJ5bbiXwm6=xteac6hc_RcsGtJ6svdoN4iVkNHC79qA@mail.gmail.com
2016-09-02 13:56:03 Craig Ringer (ringerc) Added annotation "This patch is wrong, do not use" to CAMsr+YEhUFP4Lv+5xOGK6LPAToARb=f4O=NuuZeTzYX08vkTHA@mail.gmail.com
2016-08-29 03:51:42 Craig Ringer (ringerc) Changed authors to Craig Ringer (ringerc)
2016-08-29 03:51:33 Craig Ringer (ringerc) Attached mail thread CAMsr+YHQiWNEi0daCTboS40T+V5s_+dst3PYv_8v2wNVH+Xx4g@mail.gmail.com
2016-08-29 03:51:33 Craig Ringer (ringerc) Created patch record
Edit